fix: add missing Response param to all rate-limited auth endpoints, completing slowapi compatibility across OTP and auth flows

docs/hflogs/runtimeerror.txt

@@ -1,29 +1,43 @@
-===== Application Startup at 2025-11-16 12:16:24 =====
+===== Application Startup at 2025-11-16 12:22:34 =====
 
-INFO:     Started server process [8]
+INFO:     Started server process [7]
 INFO:     Waiting for application startup.
-INFO: 2025-11-16T12:16:33 - app.main: ============================================================
-INFO: 2025-11-16T12:16:33 - app.main: 🚀 SwiftOps API v1.0.0 | PRODUCTION
-INFO: 2025-11-16T12:16:33 - app.main: ============================================================
-INFO: 2025-11-16T12:16:33 - app.main: 📦 Database:
-INFO: 2025-11-16T12:16:37 - app.main:    ✓ Connected | 42 tables | 10 users
-INFO: 2025-11-16T12:16:37 - app.main: 💾 Cache & Sessions:
-INFO: 2025-11-16T12:16:38 - app.services.otp_service: ✅ OTP Service initialized with Redis storage
-INFO: 2025-11-16T12:16:38 - app.main:    ✓ Redis: Connected
-INFO: 2025-11-16T12:16:38 - app.main: 🔌 External Services:
-INFO: 2025-11-16T12:16:39 - app.main:    ✓ Cloudinary: Connected
-INFO: 2025-11-16T12:16:39 - app.main:    ✓ Resend: Configured
-INFO: 2025-11-16T12:16:39 - app.main:    ✓ WASender: Connected
-INFO: 2025-11-16T12:16:39 - app.main:    ✓ Supabase: Connected | 6 buckets
-INFO: 2025-11-16T12:16:39 - app.main: ============================================================
-INFO: 2025-11-16T12:16:39 - app.main: ✅ Startup complete | Ready to serve requests
-INFO: 2025-11-16T12:16:39 - app.main: ============================================================
+INFO: 2025-11-16T12:22:44 - app.main: ============================================================
+INFO: 2025-11-16T12:22:44 - app.main: 🚀 SwiftOps API v1.0.0 | PRODUCTION
+INFO: 2025-11-16T12:22:44 - app.main: ============================================================
+INFO: 2025-11-16T12:22:44 - app.main: 📦 Database:
+INFO: 2025-11-16T12:22:47 - app.main:    ✓ Connected | 42 tables | 10 users
+INFO: 2025-11-16T12:22:47 - app.main: 💾 Cache & Sessions:
+INFO: 2025-11-16T12:22:48 - app.services.otp_service: ✅ OTP Service initialized with Redis storage
+INFO: 2025-11-16T12:22:49 - app.main:    ✓ Redis: Connected
+INFO: 2025-11-16T12:22:49 - app.main: 🔌 External Services:
+INFO: 2025-11-16T12:22:50 - app.main:    ✓ Cloudinary: Connected
+INFO: 2025-11-16T12:22:50 - app.main:    ✓ Resend: Configured
+INFO: 2025-11-16T12:22:50 - app.main:    ✓ WASender: Connected
+INFO: 2025-11-16T12:22:50 - app.main:    ✓ Supabase: Connected | 6 buckets
+INFO: 2025-11-16T12:22:50 - app.main: ============================================================
+INFO: 2025-11-16T12:22:50 - app.main: ✅ Startup complete | Ready to serve requests
+INFO: 2025-11-16T12:22:50 - app.main: ============================================================
 INFO:     Application startup complete.
 INFO:     Uvicorn running on http://0.0.0.0:7860 (Press CTRL+C to quit)
-INFO:     10.16.39.23:21217 - "GET /health HTTP/1.1" 200 OK
-INFO: 2025-11-16T12:17:25 - app.services.otp_service: OTP sent via whatsapp for password_reset (storage: redis)
-INFO: 2025-11-16T12:17:26 - app.services.audit_service: Audit log created: create on otp by system
-INFO:     10.16.39.23:46042 - "POST /api/v1/otp/send-public HTTP/1.1" 500 Internal Server Error
+INFO:     10.16.24.211:6043 - "GET /?logs=container HTTP/1.1" 200 OK
+INFO:     10.16.39.23:26777 - "GET /?logs=container HTTP/1.1" 200 OK
+INFO: 2025-11-16T12:23:02 - app.services.otp_service: OTP sent via whatsapp for password_reset (storage: redis)
+INFO: 2025-11-16T12:23:03 - app.services.audit_service: Audit log created: create on otp by system
+INFO:     10.16.6.135:36185 - "POST /api/v1/otp/send-public HTTP/1.1" 200 OK
+INFO: 2025-11-16T12:23:22 - app.services.otp_service: OTP verified successfully for password_reset (storage: redis)
+INFO: 2025-11-16T12:23:24 - app.services.audit_service: Audit log created: update on otp by system
+INFO:     10.16.39.23:57790 - "POST /api/v1/otp/verify-public HTTP/1.1" 200 OK
+INFO: 2025-11-16T12:25:53 - app.services.otp_service: OTP sent via whatsapp for password_reset (storage: redis)
+INFO: 2025-11-16T12:25:54 - app.services.audit_service: Audit log created: create on otp by system
+INFO:     10.16.39.23:17864 - "POST /api/v1/otp/send-public HTTP/1.1" 200 OK
+INFO: 2025-11-16T12:26:08 - app.services.otp_service: OTP verified successfully for password_reset (storage: redis)
+INFO: 2025-11-16T12:26:09 - app.services.audit_service: Audit log created: update on otp by system
+INFO:     10.16.25.32:65235 - "POST /api/v1/otp/verify-public HTTP/1.1" 200 OK
+INFO: 2025-11-16T12:26:11 - app.services.notification_service: Email sent to lesley@example.com: Reset Your SwiftOps Password
+INFO: 2025-11-16T12:26:11 - app.services.password_reset_service: Password reset requested for: lesley@example.com
+INFO: 2025-11-16T12:26:12 - app.services.audit_service: Audit log created: create on auth by system
+INFO:     10.16.39.23:11335 - "POST /api/v1/auth/forgot-password HTTP/1.1" 500 Internal Server Error
 ERROR:    Exception in ASGI application
 Traceback (most recent call last):
   File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 426, in run_asgi

src/app/api/v1/auth.py

@@ -1,7 +1,7 @@
 """
 Authentication Endpoints - Supabase Auth Integration
 """
-from fastapi import APIRouter, Depends, HTTPException, status, Request
+from fastapi import APIRouter, Depends, HTTPException, status, Request, Response
 from sqlalchemy.orm import Session
 from app.api.deps import get_db, get_current_active_user
 from app.core.rate_limit import limiter
@@ -22,7 +22,7 @@ router = APIRouter(prefix="/auth", tags=["Authentication"])
 
 @router.post("/register", response_model=TokenResponse, status_code=status.HTTP_201_CREATED)
 @limiter.limit("5/hour")  # 5 registrations per hour per IP
-async def register(request: Request, user_data: UserCreate, db: Session = Depends(get_db)):
+async def register(request: Request, response: Response, user_data: UserCreate, db: Session = Depends(get_db)):
     """
     Register a new user account via Supabase Auth
     
@@ -120,7 +120,7 @@ async def register(request: Request, user_data: UserCreate, db: Session = Depend
 
 @router.post("/login", response_model=TokenResponse)
 @limiter.limit("10/minute")  # 10 login attempts per minute per IP
-async def login(request: Request, credentials: LoginRequest, db: Session = Depends(get_db)):
+async def login(request: Request, response: Response, credentials: LoginRequest, db: Session = Depends(get_db)):
     """
     Login with email and password via Supabase Auth
     
@@ -296,6 +296,7 @@ async def update_profile(
 @limiter.limit("5/hour")  # 5 password changes per hour per user
 async def change_password(
     request: Request,
+    response: Response,
     password_data: PasswordChange,
     current_user: User = Depends(get_current_active_user),
     db: Session = Depends(get_db)
@@ -361,6 +362,7 @@ async def change_password(
 @limiter.limit("3/hour")  # 3 password reset requests per hour per IP
 async def forgot_password(
     request: Request,
+    response: Response,
     request_data: ForgotPasswordRequest,
     db: Session = Depends(get_db)
 ):
@@ -396,6 +398,7 @@ async def forgot_password(
 @limiter.limit("5/hour")  # 5 password reset attempts per hour per IP
 async def reset_password(
     request: Request,
+    response: Response,
     reset_data: ResetPasswordRequest,
     db: Session = Depends(get_db)
 ):

tests/integration/reset-password-otp.js

@@ -143,7 +143,13 @@ async function sendOTP() {
 
     console.log(`${colors.green}✓ OTP sent successfully!${colors.reset}`);
     console.log(`${colors.dim}Message: ${response.message}${colors.reset}`);
-    console.log(`${colors.dim}Expires in: ${response.expires_in_seconds} seconds${colors.reset}\n`);
+    if (response.expires_in_minutes) {
+      console.log(`${colors.dim}Expires in: ${response.expires_in_minutes} minutes${colors.reset}`);
+    }
+    if (response.masked_contact) {
+      console.log(`${colors.dim}Sent to: ${response.masked_contact}${colors.reset}`);
+    }
+    console.log();
     
     return true;
   } catch (error) {
@@ -165,12 +171,16 @@ async function verifyOTP(code) {
       purpose: 'password_reset'
     });
 
-    if (response.is_valid) {
+    if (response.verified) {
       console.log(`${colors.green}✓ OTP verified successfully!${colors.reset}\n`);
       return true;
     } else {
       console.log(`${colors.red}✗ Invalid OTP${colors.reset}`);
-      console.log(`${colors.dim}Message: ${response.message}${colors.reset}\n`);
+      console.log(`${colors.dim}Message: ${response.message}${colors.reset}`);
+      if (response.attempts_remaining !== undefined) {
+        console.log(`${colors.dim}Attempts remaining: ${response.attempts_remaining}${colors.reset}`);
+      }
+      console.log();
       return false;
     }
   } catch (error) {