Update app.py

app.py

@@ -190,7 +190,8 @@ def generate_and_display_conversations(num_conversations_input, custom_prompts_i
                                      commit_subject, commit_body, selected_model_name_input):
     num_conversations = int(num_conversations_input)
     if num_conversations <= 0:
-        yield gr.JSON.update(value={}), "Please enter a number of conversations greater than zero.\n"
+        # Use gr.NoOp() for the output that shouldn't be updated
+        yield gr.NoOp(), "Please enter a number of conversations greater than zero.\n"
         return
 
     os.makedirs(OUTPUT_DIR, exist_ok=True)
@@ -203,7 +204,8 @@ def generate_and_display_conversations(num_conversations_input, custom_prompts_i
                 try:
                     existing_conversations.append(json.loads(line.strip()))
                 except json.JSONDecodeError as e:
-                    yield gr.JSON.update(value={}), f"Skipping malformed JSON line in {DATA_FILE}: {line.strip()} - {e}\n"
+                    # Use gr.NoOp() for the output that shouldn't be updated
+                    yield gr.NoOp(), f"Skipping malformed JSON line in {DATA_FILE}: {line.strip()} - {e}\n"
                     
     # Deduplicate existing conversations
     seen_conversations = set()
@@ -224,14 +226,16 @@ def generate_and_display_conversations(num_conversations_input, custom_prompts_i
         if len(conv_list) == expected_msg_len(5): # Fixed to 5 exchanges for generation
             validated_existing_conversations.append(conv_entry)
         else:
-            yield gr.JSON.update(value={}), f"Skipping incomplete/malformed existing conversation (length {len(conv_list)} != {expected_msg_len(5)}): {conv_entry}\n"
+            # Use gr.NoOp() for the output that shouldn't be updated
+            yield gr.NoOp(), f"Skipping incomplete/malformed existing conversation (length {len(conv_list)} != {expected_msg_len(5)}): {conv_entry}\n"
 
     all_conversations = list(validated_existing_conversations) # Start with clean existing ones
 
     current_time_loc = datetime.datetime.now().strftime('%Y-%m-%d %H:%M:%S') + " (An Nhơn, Binh Dinh, Vietnam)"
-    yield gr.JSON.update(value={}), f"Starting conversation generation at {current_time_loc}\n"
-    yield gr.JSON.update(value={}), f"Loaded and cleaned {len(validated_existing_conversations)} existing conversations (initially {initial_cleaned_count} before validation).\n"
-    yield gr.JSON.update(value={}), f"Generating {num_conversations} *new* conversations.\n"
+    # Use gr.NoOp() for the output that shouldn't be updated
+    yield gr.NoOp(), f"Starting conversation generation at {current_time_loc}\n"
+    yield gr.NoOp(), f"Loaded and cleaned {len(validated_existing_conversations)} existing conversations (initially {initial_cleaned_count} before validation).\n"
+    yield gr.NoOp(), f"Generating {num_conversations} *new* conversations.\n"
     
     model_names_to_use = list(AVAILABLE_MODELS.keys())
     if selected_model_name_input and selected_model_name_input in model_names_to_use:
@@ -240,7 +244,7 @@ def generate_and_display_conversations(num_conversations_input, custom_prompts_i
     else:
         model_selection_info = f"No specific model selected or invalid. Models will be chosen randomly per conversation from: {', '.join(model_names_to_use)}\n"
         selected_model_for_this_conv_batch = None # Indicate random selection per loop
-    yield gr.JSON.update(value={}), model_selection_info
+    yield gr.NoOp(), model_selection_info
 
 
     current_prompts = DEFAULT_INITIAL_PROMPTS
@@ -266,7 +270,7 @@ def generate_and_display_conversations(num_conversations_input, custom_prompts_i
 
         selected_model_for_this_conv = selected_model_for_this_conv_batch if selected_model_for_this_conv_batch else random.choice(model_names_to_use)
             
-        yield gr.JSON.update(value={}), f"[{datetime.datetime.now().strftime('%H:%M:%S')}] Generating conv {i+1}/{num_conversations} with '{selected_model_for_this_conv}' (System: '{system[:50]}...')\n"
+        yield gr.NoOp(), f"[{datetime.datetime.now().strftime('%H:%M:%S')}] Generating conv {i+1}/{num_conversations} with '{selected_model_for_this_conv}' (System: '{system[:50]}...')\n"
         
         conversation = chat(system, prompt, selected_model_for_this_conv, seed=seed, num_exchanges=5)
 
@@ -277,30 +281,30 @@ def generate_and_display_conversations(num_conversations_input, custom_prompts_i
                 all_conversations.append(new_conv_entry)
                 new_conversations_generated.append(new_conv_entry)
                 seen_conversations.add(new_conv_str)
-                yield gr.JSON.update(value={}), f"[{datetime.datetime.now().strftime('%H:%M:%S')}] Successfully generated and added conv {i+1}/{num_conversations}.\n"
+                yield gr.NoOp(), f"[{datetime.datetime.now().strftime('%H:%M:%S')}] Successfully generated and added conv {i+1}/{num_conversations}.\n"
             else:
-                yield gr.JSON.update(value={}), f"[{datetime.datetime.now().strftime('%H:%M:%S')}] Skipped conv {i+1}/{num_conversations} as it's a duplicate.\n"
+                yield gr.NoOp(), f"[{datetime.datetime.now().strftime('%H:%M:%S')}] Skipped conv {i+1}/{num_conversations} as it's a duplicate.\n"
         else:
-            yield gr.JSON.update(value={}), f"[{datetime.datetime.now().strftime('%H:%M:%S')}] Skipping conv {i+1}/{num_conversations} due to error or incorrect length ({len(conversation)} messages, expected {expected_conversation_length}).\n"
+            yield gr.NoOp(), f"[{datetime.datetime.now().strftime('%H:%M:%S')}] Skipping conv {i+1}/{num_conversations} due to error or incorrect length ({len(conversation)} messages, expected {expected_conversation_length}).\n"
             if conversation and conversation[-1].get("from") == "error":
-                yield gr.JSON.update(value={}), f"  Error details: {conversation[-1]['value']}\n"
+                yield gr.NoOp(), f"  Error details: {conversation[-1]['value']}\n"
 
     # Save all (cleaned existing + newly generated unique) conversations to JSONL
     with open(DATA_FILE, "w") as f:
         for conv in all_conversations:
             f.write(json.dumps(conv) + "\n")
 
-    yield gr.JSON.update(value={}), f"Saved {len(new_conversations_generated)} *new unique* conversations to {DATA_FILE} (total unique and validated: {len(all_conversations)}).\n"
-    yield gr.JSON.update(value={}), "Attempting to push main conversations file to Hugging Face Dataset...\n"
+    yield gr.NoOp(), f"Saved {len(new_conversations_generated)} *new unique* conversations to {DATA_FILE} (total unique and validated: {len(all_conversations)}).\n"
+    yield gr.NoOp(), "Attempting to push main conversations file to Hugging Face Dataset...\n"
 
     # --- Auto-push main conversations to Hugging Face Dataset ---
     # Use the custom commit message
     commit_message = f"{commit_subject.strip()}\n\n{commit_body.strip()}" if commit_body.strip() else commit_subject.strip()
     push_status = push_file_to_huggingface_dataset(DATA_FILE, "conversations.jsonl", commit_message)
-    yield gr.JSON.update(value={}), push_status + "\n"
+    yield gr.NoOp(), push_status + "\n"
     final_log_message = f"Process complete at {datetime.datetime.now().strftime('%Y-%m-%d %H:%M:%S')} (An Nhơn, Binh Dinh, Vietnam)\n"
     
-    # Final return for both outputs
+    # Final return for both outputs: The first output (JSON) is now updated, the second (log) gets the final message.
     yield json.dumps(all_conversations, indent=2), final_log_message
 
 # --- Community Prompts Functions ---
@@ -509,7 +513,7 @@ with gr.Blocks() as demo:
             generate_button = gr.Button("Generate & Push Conversations")
 
             output_conversations = gr.JSON(label="Generated Conversations (Content of conversations.jsonl)")
-            # Changed output_log to stream
+            # Set streaming=True for the output_log Textbox
             output_log = gr.Textbox(label="Process Log", interactive=False, lines=10, max_lines=20, streaming=True)
 
             # Link commit template dropdown to update fields
@@ -536,7 +540,7 @@ with gr.Blocks() as demo:
                     model_selector_dropdown # Pass selected model name
                 ],
                 outputs=[output_conversations, output_log],
-                # show_progress=True is handled internally by yielding
+                # show_progress=True is handled internally by yielding a generator
             )
 
         with gr.Tab("Community Prompts"):