fix: proxy pool review fixes — security, validation, robustness

- Skip disabled proxies in healthCheckAll (avoid unnecessary network calls)
- Validate proxy URL scheme (only http/https/socks5/socks5h allowed)
- Deduplicate proxy URLs on add (return existing ID if URL already exists)
- Mask proxy credentials server-side via getAllMasked() (remove client-side maskUrl)
- Add try-catch to all use-proxies hook operations (prevent unhandled rejections)
- Fix misleading route ordering comment in proxies.ts

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

shared/hooks/use-proxies.ts

@@ -82,24 +82,36 @@ export function useProxies(): ProxiesState {
 
   const checkProxy = useCallback(
     async (id: string) => {
-      await fetch(`/api/proxies/${encodeURIComponent(id)}/check`, {
-        method: "POST",
-      });
+      try {
+        await fetch(`/api/proxies/${encodeURIComponent(id)}/check`, {
+          method: "POST",
+        });
+      } catch {
+        // network error — refresh will show stale state
+      }
       await refresh();
     },
     [refresh],
   );
 
   const checkAll = useCallback(async () => {
-    await fetch("/api/proxies/check-all", { method: "POST" });
+    try {
+      await fetch("/api/proxies/check-all", { method: "POST" });
+    } catch {
+      // network error
+    }
     await refresh();
   }, [refresh]);
 
   const enableProxy = useCallback(
     async (id: string) => {
-      await fetch(`/api/proxies/${encodeURIComponent(id)}/enable`, {
-        method: "POST",
-      });
+      try {
+        await fetch(`/api/proxies/${encodeURIComponent(id)}/enable`, {
+          method: "POST",
+        });
+      } catch {
+        // network error
+      }
       await refresh();
     },
     [refresh],
@@ -107,9 +119,13 @@ export function useProxies(): ProxiesState {
 
   const disableProxy = useCallback(
     async (id: string) => {
-      await fetch(`/api/proxies/${encodeURIComponent(id)}/disable`, {
-        method: "POST",
-      });
+      try {
+        await fetch(`/api/proxies/${encodeURIComponent(id)}/disable`, {
+          method: "POST",
+        });
+      } catch {
+        // network error
+      }
       await refresh();
     },
     [refresh],
@@ -117,11 +133,15 @@ export function useProxies(): ProxiesState {
 
   const assignProxy = useCallback(
     async (accountId: string, proxyId: string) => {
-      await fetch("/api/proxies/assign", {
-        method: "POST",
-        headers: { "Content-Type": "application/json" },
-        body: JSON.stringify({ accountId, proxyId }),
-      });
+      try {
+        await fetch("/api/proxies/assign", {
+          method: "POST",
+          headers: { "Content-Type": "application/json" },
+          body: JSON.stringify({ accountId, proxyId }),
+        });
+      } catch {
+        // network error
+      }
       await refresh();
     },
     [refresh],
@@ -129,9 +149,13 @@ export function useProxies(): ProxiesState {
 
   const unassignProxy = useCallback(
     async (accountId: string) => {
-      await fetch(`/api/proxies/assign/${encodeURIComponent(accountId)}`, {
-        method: "DELETE",
-      });
+      try {
+        await fetch(`/api/proxies/assign/${encodeURIComponent(accountId)}`, {
+          method: "DELETE",
+        });
+      } catch {
+        // network error
+      }
       await refresh();
     },
     [refresh],
@@ -139,11 +163,15 @@ export function useProxies(): ProxiesState {
 
   const setIntervalMinutes = useCallback(
     async (minutes: number) => {
-      await fetch("/api/proxies/settings", {
-        method: "PUT",
-        headers: { "Content-Type": "application/json" },
-        body: JSON.stringify({ healthCheckIntervalMinutes: minutes }),
-      });
+      try {
+        await fetch("/api/proxies/settings", {
+          method: "PUT",
+          headers: { "Content-Type": "application/json" },
+          body: JSON.stringify({ healthCheckIntervalMinutes: minutes }),
+        });
+      } catch {
+        // network error
+      }
       await refresh();
     },
     [refresh],

src/proxy/proxy-pool.ts

@@ -78,11 +78,18 @@ export class ProxyPool {
   // ── CRUD ──────────────────────────────────────────────────────────
 
   add(name: string, url: string): string {
+    const trimmedUrl = url.trim();
+    // Reject duplicate URLs
+    for (const existing of this.proxies.values()) {
+      if (existing.url === trimmedUrl) {
+        return existing.id;
+      }
+    }
     const id = randomHex(8);
     const entry: ProxyEntry = {
       id,
       name: name.trim(),
-      url: url.trim(),
+      url: trimmedUrl,
       status: "active",
       health: null,
       addedAt: new Date().toISOString(),
@@ -121,6 +128,11 @@ export class ProxyPool {
     return Array.from(this.proxies.values());
   }
 
+  /** Returns all proxies with credentials masked in URLs. */
+  getAllMasked(): ProxyEntry[] {
+    return this.getAll().map((p) => ({ ...p, url: maskProxyUrl(p.url) }));
+  }
+
   getById(id: string): ProxyEntry | undefined {
     return this.proxies.get(id);
   }
@@ -285,17 +297,17 @@ export class ProxyPool {
   }
 
   async healthCheckAll(): Promise<void> {
-    const ids = Array.from(this.proxies.keys());
-    if (ids.length === 0) return;
+    const targets = Array.from(this.proxies.values()).filter(
+      (p) => p.status !== "disabled",
+    );
+    if (targets.length === 0) return;
 
-    console.log(`[ProxyPool] Health checking ${ids.length} proxies...`);
-    await Promise.allSettled(ids.map((id) => this.healthCheck(id)));
+    console.log(`[ProxyPool] Health checking ${targets.length} proxies...`);
+    await Promise.allSettled(targets.map((p) => this.healthCheck(p.id)));
 
-    const active = Array.from(this.proxies.values()).filter(
-      (p) => p.status === "active",
-    ).length;
+    const active = targets.filter((p) => p.status === "active").length;
     console.log(
-      `[ProxyPool] Health check complete: ${active}/${ids.length} active`,
+      `[ProxyPool] Health check complete: ${active}/${targets.length} active`,
     );
   }
 
@@ -438,6 +450,16 @@ export class ProxyPool {
 
 // ── Helpers ─────────────────────────────────────────────────────────
 
+function maskProxyUrl(url: string): string {
+  try {
+    const u = new URL(url);
+    if (u.password) u.password = "***";
+    return u.toString();
+  } catch {
+    return url;
+  }
+}
+
 function randomHex(bytes: number): string {
   const arr = new Uint8Array(bytes);
   crypto.getRandomValues(arr);

src/routes/proxies.ts

@@ -20,10 +20,10 @@ import type { ProxyPool } from "../proxy/proxy-pool.js";
 export function createProxyRoutes(proxyPool: ProxyPool): Hono {
   const app = new Hono();
 
-  // List all proxies + assignments
+  // List all proxies + assignments (credentials masked)
   app.get("/api/proxies", (c) => {
     return c.json({
-      proxies: proxyPool.getAll(),
+      proxies: proxyPool.getAllMasked(),
       assignments: proxyPool.getAllAssignments(),
       healthCheckIntervalMinutes: proxyPool.getHealthIntervalMinutes(),
     });
@@ -39,9 +39,14 @@ export function createProxyRoutes(proxyPool: ProxyPool): Hono {
       return c.json({ error: "url is required" });
     }
 
-    // Basic URL validation
+    // URL validation + scheme check
     try {
-      new URL(url);
+      const parsed = new URL(url);
+      const allowed = ["http:", "https:", "socks5:", "socks5h:"];
+      if (!allowed.includes(parsed.protocol)) {
+        c.status(400);
+        return c.json({ error: `Unsupported protocol "${parsed.protocol}". Use http, https, socks5, or socks5h.` });
+      }
     } catch {
       c.status(400);
       return c.json({ error: "Invalid proxy URL format" });
@@ -114,12 +119,12 @@ export function createProxyRoutes(proxyPool: ProxyPool): Hono {
     return c.json({ success: true, proxy: proxyPool.getById(id) });
   });
 
-  // Health check all — must be before /:id routes
+  // Health check all (no route conflict — different path structure from /:id/*)
   app.post("/api/proxies/check-all", async (c) => {
     await proxyPool.healthCheckAll();
     return c.json({
       success: true,
-      proxies: proxyPool.getAll(),
+      proxies: proxyPool.getAllMasked(),
     });
   });
 

web/src/components/ProxyPool.tsx

@@ -18,18 +18,6 @@ const statusStyles: Record<string, [string, TranslationKey]> = {
   ],
 };
 
-function maskUrl(url: string): string {
-  try {
-    const u = new URL(url);
-    if (u.password) {
-      u.password = "***";
-    }
-    return u.toString();
-  } catch {
-    return url;
-  }
-}
-
 interface ProxyPoolProps {
   proxies: ProxiesState;
 }
@@ -177,7 +165,7 @@ export function ProxyPool({ proxies }: ProxyPoolProps) {
                         </span>
                       </div>
                       <p class="text-xs text-slate-400 dark:text-text-dim font-mono truncate mt-0.5">
-                        {maskUrl(proxy.url)}
+                        {proxy.url}
                       </p>
                     </div>
                   </div>