File size: 10,481 Bytes
9aa5185 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 | """Tests for hermes tools disable/enable/list command (backend)."""
from argparse import Namespace
from unittest.mock import patch
from hermes_cli.tools_config import tools_disable_enable_command
# ── Built-in toolset disable ────────────────────────────────────────────────
class TestToolsDisableBuiltin:
def test_disable_removes_toolset_from_platform(self):
config = {"platform_toolsets": {"cli": ["web", "memory", "terminal"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(Namespace(tools_action="disable", names=["web"], platform="cli"))
saved = mock_save.call_args[0][0]
assert "web" not in saved["platform_toolsets"]["cli"]
assert "memory" in saved["platform_toolsets"]["cli"]
def test_disable_multiple_toolsets(self):
config = {"platform_toolsets": {"cli": ["web", "memory", "terminal"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(Namespace(tools_action="disable", names=["web", "memory"], platform="cli"))
saved = mock_save.call_args[0][0]
assert "web" not in saved["platform_toolsets"]["cli"]
assert "memory" not in saved["platform_toolsets"]["cli"]
assert "terminal" in saved["platform_toolsets"]["cli"]
def test_disable_already_absent_is_idempotent(self):
config = {"platform_toolsets": {"cli": ["memory"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(Namespace(tools_action="disable", names=["web"], platform="cli"))
saved = mock_save.call_args[0][0]
assert "web" not in saved["platform_toolsets"]["cli"]
# ── Built-in toolset enable ─────────────────────────────────────────────────
class TestToolsEnableBuiltin:
def test_enable_adds_toolset_to_platform(self):
config = {"platform_toolsets": {"cli": ["memory"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(Namespace(tools_action="enable", names=["web"], platform="cli"))
saved = mock_save.call_args[0][0]
assert "web" in saved["platform_toolsets"]["cli"]
def test_enable_already_present_is_idempotent(self):
config = {"platform_toolsets": {"cli": ["web"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(Namespace(tools_action="enable", names=["web"], platform="cli"))
saved = mock_save.call_args[0][0]
assert saved["platform_toolsets"]["cli"].count("web") == 1
# ── MCP tool disable ────────────────────────────────────────────────────────
class TestToolsDisableMcp:
def test_disable_adds_to_exclude_list(self):
config = {"mcp_servers": {"github": {"command": "npx"}}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(
Namespace(tools_action="disable", names=["github:create_issue"], platform="cli")
)
saved = mock_save.call_args[0][0]
assert "create_issue" in saved["mcp_servers"]["github"]["tools"]["exclude"]
def test_disable_already_excluded_is_idempotent(self):
config = {"mcp_servers": {"github": {"tools": {"exclude": ["create_issue"]}}}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(
Namespace(tools_action="disable", names=["github:create_issue"], platform="cli")
)
saved = mock_save.call_args[0][0]
assert saved["mcp_servers"]["github"]["tools"]["exclude"].count("create_issue") == 1
def test_disable_unknown_server_prints_error(self, capsys):
config = {"mcp_servers": {}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config"):
tools_disable_enable_command(
Namespace(tools_action="disable", names=["unknown:tool"], platform="cli")
)
out = capsys.readouterr().out
assert "MCP server 'unknown' not found in config" in out
# ── MCP tool enable ──────────────────────────────────────────────────────────
class TestToolsEnableMcp:
def test_enable_removes_from_exclude_list(self):
config = {"mcp_servers": {"github": {"tools": {"exclude": ["create_issue", "delete_branch"]}}}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(
Namespace(tools_action="enable", names=["github:create_issue"], platform="cli")
)
saved = mock_save.call_args[0][0]
assert "create_issue" not in saved["mcp_servers"]["github"]["tools"]["exclude"]
assert "delete_branch" in saved["mcp_servers"]["github"]["tools"]["exclude"]
# ── Mixed targets ────────────────────────────────────────────────────────────
class TestToolsMixedTargets:
def test_disable_builtin_and_mcp_together(self):
config = {
"platform_toolsets": {"cli": ["web", "memory"]},
"mcp_servers": {"github": {"command": "npx"}},
}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(Namespace(
tools_action="disable",
names=["web", "github:create_issue"],
platform="cli",
))
saved = mock_save.call_args[0][0]
assert "web" not in saved["platform_toolsets"]["cli"]
assert "create_issue" in saved["mcp_servers"]["github"]["tools"]["exclude"]
# ── List output ──────────────────────────────────────────────────────────────
class TestToolsList:
def test_list_shows_enabled_toolsets(self, capsys):
config = {"platform_toolsets": {"cli": ["web", "memory"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config):
tools_disable_enable_command(Namespace(tools_action="list", platform="cli"))
out = capsys.readouterr().out
assert "web" in out
assert "memory" in out
def test_list_shows_mcp_excluded_tools(self, capsys):
config = {
"mcp_servers": {"github": {"tools": {"exclude": ["create_issue"]}}},
}
with patch("hermes_cli.tools_config.load_config", return_value=config):
tools_disable_enable_command(Namespace(tools_action="list", platform="cli"))
out = capsys.readouterr().out
assert "github" in out
assert "create_issue" in out
# ── Validation ───────────────────────────────────────────────────────────────
class TestToolsValidation:
def test_unknown_platform_prints_error(self, capsys):
config = {}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config"):
tools_disable_enable_command(
Namespace(tools_action="disable", names=["web"], platform="invalid_platform")
)
out = capsys.readouterr().out
assert "Unknown platform 'invalid_platform'" in out
def test_unknown_toolset_prints_error(self, capsys):
config = {"platform_toolsets": {"cli": ["web"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config"):
tools_disable_enable_command(
Namespace(tools_action="disable", names=["nonexistent_toolset"], platform="cli")
)
out = capsys.readouterr().out
assert "Unknown toolset 'nonexistent_toolset'" in out
def test_unknown_toolset_does_not_corrupt_config(self):
config = {"platform_toolsets": {"cli": ["web", "memory"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(
Namespace(tools_action="disable", names=["nonexistent_toolset"], platform="cli")
)
saved = mock_save.call_args[0][0]
assert "web" in saved["platform_toolsets"]["cli"]
assert "memory" in saved["platform_toolsets"]["cli"]
def test_mixed_valid_and_invalid_applies_valid_only(self):
config = {"platform_toolsets": {"cli": ["web", "memory"]}}
with patch("hermes_cli.tools_config.load_config", return_value=config), \
patch("hermes_cli.tools_config.save_config") as mock_save:
tools_disable_enable_command(
Namespace(tools_action="disable", names=["web", "bad_toolset"], platform="cli")
)
saved = mock_save.call_args[0][0]
assert "web" not in saved["platform_toolsets"]["cli"]
assert "memory" in saved["platform_toolsets"]["cli"]
|