refactor: standardize user ID display format and enhance benchmark result handling in create_submit_tab function

app.py

@@ -369,7 +369,7 @@ def create_submit_tab(tab_id: int, demo: gr.Blocks):
 
         # ========== Login Section (First Step) ==========
         login_button = gr.LoginButton()
-        current_user_display = gr.Markdown(value="**Submitter ID:** Loading...")
+        current_user_display = gr.Markdown(value="Submitter ID: Loading...")
 
         with gr.Row():
             gr.Markdown(SUBMISSION_INSTRUCTIONS_TEXT, elem_classes="markdown-text")
@@ -379,11 +379,11 @@ def create_submit_tab(tab_id: int, demo: gr.Blocks):
             """Get current HuggingFace user ID from the visiting user (not the server token)"""
             if oauth_profile is None:
                 # User is not logged in
-                return "**Submitter ID:** Not logged in"
+                return "Submitter ID: Not logged in"
             # User is logged in, get user ID from OAuth profile
             # OAuth profile contains 'sub' (user ID) and 'preferred_username' fields
             user_id = oauth_profile.get("preferred_username") or oauth_profile.get("sub", "Unknown")
-            return f"**Submitter ID:** {user_id}"
+            return f"Submitter ID: **{user_id}**"
 
         # Container for all form sections - will be hidden if user is not logged in
         form_container = gr.Column(visible=False)
@@ -537,7 +537,7 @@ def create_submit_tab(tab_id: int, demo: gr.Blocks):
             revision: str,
             precision: str,
             benchmark_checkbox_values: list[bool],
-            benchmark_result_values: list[float],
+            benchmark_result_values: list[float | None],
         ) -> str:
             """Build JSON from form inputs"""
             if not model_name or not model_name.strip():
@@ -567,6 +567,7 @@ def create_submit_tab(tab_id: int, demo: gr.Blocks):
                 strict=True,
             ):
                 if checkbox_checked:
+                    # TODO: metric
                     results[benchmark.key] = {"acc": float(result_value) if result_value is not None else None}
 
             if not results:
@@ -588,16 +589,15 @@ def create_submit_tab(tab_id: int, demo: gr.Blocks):
             model_type: str,
             json_str: str,
             commit_message: str,
+            current_user_display: str,
             *benchmark_values: list[bool | float],
-            oauth_profile: gr.OAuthProfile | None = None,
         ):
             """Submit with either form data or JSON"""
             # Check if user is logged in
-            if oauth_profile is None:
+            user_id_match = re.match(r"\*\*(.+)\*\*", current_user_display)
+            if not user_id_match:
                 return styled_error("Please log in before submitting.")
-
-            # Extract user_id from OAuth profile
-            user_id = oauth_profile.get("preferred_username") or oauth_profile.get("sub", None)
+            user_id = user_id_match.group(1)
             if not user_id:
                 return styled_error("Unable to get user ID. Please try logging in again.")
 
@@ -626,14 +626,20 @@ def create_submit_tab(tab_id: int, demo: gr.Blocks):
 
                 # Split into checkbox values and result values
                 benchmark_checkbox_values: list[bool] = []
-                benchmark_result_values: list[float] = []
-                for checkbox_value, result_value in benchmark_values:
-                    benchmark_checkbox_values.append(checkbox_value)
-                    benchmark_result_values.append(result_value)  # pyright: ignore[reportArgumentType]
+                benchmark_result_values: list[float | None] = []
+                for i, value in enumerate(benchmark_values):
+                    if i % 2 == 0:
+                        benchmark_checkbox_values.append(bool(value))
+                    else:
+                        benchmark_result_values.append(float(value) if value is not None else None)  # pyright: ignore[reportArgumentType]
 
                 try:
                     final_json = build_json_from_form(
-                        model, revision, precision, benchmark_checkbox_values, benchmark_result_values
+                        model,
+                        revision,
+                        precision,
+                        benchmark_checkbox_values,
+                        benchmark_result_values,
                     )
                 except ValueError as e:
                     return styled_error(str(e))
@@ -699,6 +705,7 @@ def create_submit_tab(tab_id: int, demo: gr.Blocks):
                 model_type,
                 json_str,
                 commit_textbox,
+                current_user_display,
                 *benchmark_values,
             ],
             outputs=submission_result,