Update app.py

app.py

@@ -1,50 +1,41 @@
-# app.py - Fixed PDF Generator with Unicode support and Title + Plan layout
+# app.py - Fixed PDF Generator with proper temp file handling
 
 import gradio as gr
 from fpdf import FPDF
 import os
 import tempfile
 import re
+import pandas as pd
+import requests
 from pathlib import Path
+import io
 
 class UnicodePDF(FPDF):
     def __init__(self):
         super().__init__()
-        self.add_font('DejaVu', '', 'DejaVuSans.ttf', uni=True)
-        self.add_font('DejaVu', 'B', 'DejaVuSans-Bold.ttf', uni=True)
-        self.default_font = 'DejaVu'
-    
-    def set_default_font(self):
+        self.add_font('DejaVu', '', '/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf', uni=True)
+        self.add_font('DejaVu', 'B', '/usr/share/fonts/truetype/dejavu/DejaVuSans-Bold.ttf', uni=True)
         self.set_font('DejaVu', '', 12)
-
-def download_dejavu_fonts():
-    """Download DejaVu fonts if not present (for Hugging Face Spaces)"""
-    import urllib.request
-    import os
-    
-    font_dir = "fonts"
-    os.makedirs(font_dir, exist_ok=True)
     
-    fonts = {
-        'DejaVuSans.ttf': 'https://github.com/dejavu-fonts/dejavu-fonts/raw/master/ttf/DejaVuSans.ttf',
-        'DejaVuSans-Bold.ttf': 'https://github.com/dejavu-fonts/dejavu-fonts/raw/master/ttf/DejaVuSans-Bold.ttf'
-    }
-    
-    for font_name, url in fonts.items():
-        font_path = os.path.join(font_dir, font_name)
-        if not os.path.exists(font_path):
-            try:
-                urllib.request.urlretrieve(url, font_path)
-                print(f"Downloaded {font_name}")
-            except:
-                print(f"Failed to download {font_name}, using built-in fonts")
+    def footer(self):
+        self.set_y(-15)
+        self.set_font('DejaVu', 'I', 8)
+        self.cell(0, 10, f'Page {self.page_no()}', 0, 0, 'C')
+
+def ensure_fonts():
+    """Ensure Unicode fonts are available"""
+    font_paths = [
+        '/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf',
+        '/usr/share/fonts/truetype/dejavu/DejaVuSans-Bold.ttf'
+    ]
+    return all(os.path.exists(path) for path in font_paths)
 
 def generate_pdf(title, plan, names, image_files):
     # Validate inputs
-    if not title or title.strip() == "":
+    if not title or not title.strip():
         return None, "❌ Please enter a title!"
     
-    if not plan or plan.strip() == "":
+    if not plan or not plan.strip():
         return None, "❌ Please enter the plan details!"
     
     names_list = [n.strip() for n in names.split(',') if n.strip()]
@@ -53,163 +44,150 @@ def generate_pdf(title, plan, names, image_files):
         return None, "❌ Please upload at least one image!"
     
     if len(names_list) != len(image_files):
-        return None, f"❌ Mismatch! {len(names_list)} names but {len(image_files)} images. Please match counts."
+        return None, f"❌ Mismatch! {len(names_list)} names but {len(image_files)} images."
     
     try:
-        # Download fonts if needed (for HF Spaces)
-        download_dejavu_fonts()
-        
         pdf = UnicodePDF()
         pdf.set_margins(20, 20, 20)
         pdf.set_auto_page_break(auto=True, margin=20)
         
+        # Clean title and plan for PDF compatibility
+        clean_title = re.sub(r'[^\w\s\-–—]', ' ', title)[:100]
+        clean_plan = re.sub(r'[^\w\s\-\n\.\,\!\?\(\)]', ' ', plan)
+        
         # Title Page
         pdf.add_page()
         pdf.set_font('DejaVu', 'B', 24)
-        pdf.set_text_color(30, 30, 30)
-        pdf.cell(0, 20, title.upper(), ln=1, align='C')
+        pdf.cell(0, 20, clean_title, ln=1, align='C')
         
         pdf.ln(10)
-        pdf.set_font('DejaVu', '', 14)
-        pdf.multi_cell(0, 8, plan, align='C')
+        pdf.set_font('DejaVu', '', 12)
+        pdf.multi_cell(0, 8, clean_plan)
         
         pdf.ln(10)
-        pdf.set_font('DejaVu', 'I', 12)
-        pdf.cell(0, 10, f"Generated on: {pd.Timestamp.now().strftime('%Y-%m-%d %H:%M')}", ln=1, align='C')
-        pdf.cell(0, 10, f"Total Participants: {len(names_list)}", ln=1, align='C')
+        pdf.set_font('DejaVu', 'I', 10)
+        pdf.cell(0, 10, f"Generated: {pd.Timestamp.now().strftime('%Y-%m-%d %H:%M')}", ln=1, align='C')
+        pdf.cell(0, 10, f"Participants: {len(names_list)}", ln=1, align='C')
         
         # Content Pages
         for i, (name, img_path) in enumerate(zip(names_list, image_files)):
             pdf.add_page()
             
-            # Name header
+            # Clean name for PDF
+            clean_name = re.sub(r'[^\w\s\-]', ' ', name)[:50].strip()
             pdf.set_font('DejaVu', 'B', 18)
-            pdf.set_text_color(50, 50, 150)
-            clean_name = re.sub(r'[^\w\s-]', '', name)  # Clean special chars
             pdf.cell(0, 15, clean_name.upper(), ln=1, align='C')
             
-            # Participant info
             pdf.set_font('DejaVu', '', 12)
-            pdf.cell(0, 8, f"Participant #{i+1} of {len(names_list)}", ln=1, align='C')
+            pdf.cell(0, 8, f"Participant #{i+1}/{len(names_list)}", ln=1, align='C')
             
-            # Add image
+            # Add image with proper error handling
             try:
-                page_width = pdf.w - 40  # Account for margins
-                img_width = min(140, page_width * 0.8)
-                x_pos = (page_width - img_width) / 2 + 20  # Center with margins
-                
-                pdf.image(img_path, x=x_pos, y=50, w=img_width)
-                
-                # Add image caption
-                pdf.set_font('DejaVu', 'I', 10)
-                pdf.set_xy(x_pos, pdf.get_y() + 5)
-                pdf.multi_cell(img_width, 5, f"Image for {clean_name}", align='C')
-                
+                # Read image file properly
+                if os.path.exists(img_path):
+                    img_width = 120
+                    x_pos = (pdf.w - img_width) / 2
+                    pdf.image(img_path, x=x_pos, y=50, w=img_width)
+                    
+                    # Add caption
+                    pdf.set_font('DejaVu', 'I', 10)
+                    pdf.set_xy(x_pos, pdf.get_y() + 5)
+                    pdf.multi_cell(img_width, 5, f"Photo: {clean_name}", align='C')
+                else:
+                    raise FileNotFoundError(f"Image file not found: {img_path}")
+                    
             except Exception as img_error:
                 pdf.set_font('DejaVu', '', 12)
-                pdf.set_text_color(200, 50, 50)
-                pdf.cell(0, 10, f"⚠️ Could not load image for {clean_name}", ln=1, align='C')
-                pdf.cell(0, 10, f"Error: {str(img_error)[:100]}...", ln=1, align='C')
+                pdf.cell(0, 10, f"⚠️ Image unavailable for {clean_name}", ln=1, align='C')
+                pdf.set_font('DejaVu', 'I', 10)
+                pdf.cell(0, 10, f"Error: {str(img_error)[:80]}", ln=1, align='C')
         
-        # Create output file
-        with tempfile.NamedTemporaryFile(delete=False, suffix='.pdf', delete=True) as tmp_file:
+        # Save PDF to BytesIO (more reliable than temp files)
+        pdf_output = io.BytesIO()
+        pdf_output.write(pdf.output(dest='S').encode('latin1'))  # FPDF outputs bytes
+        pdf_output.seek(0)
+        
+        # Create proper temp file from bytes
+        with tempfile.NamedTemporaryFile(suffix='.pdf', delete=False) as tmp_file:
+            tmp_file.write(pdf_output.getvalue())
+            tmp_file.flush()
             output_path = tmp_file.name
-            pdf.output(output_path)
         
-        success_msg = f"✅ PDF generated successfully!\n📄 Title: {title}\n📋 Plan included\n👥 {len(names_list)} participants"
+        success_msg = f"✅ PDF Generated Successfully!\n📄 Title: {clean_title}\n👥 {len(names_list)} Participants"
         return output_path, success_msg
         
     except Exception as e:
-        return None, f"❌ PDF Generation Error: {str(e)}\n\nPlease check your inputs and try again."
+        return None, f"❌ Error: {str(e)}\nPlease check inputs and try again."
 
-# UI with enhanced layout
+# Enhanced UI
 with gr.Blocks(
-    title="📄 Professional PDF Generator",
+    title="📄 Pro PDF Generator",
     theme=gr.themes.Soft(),
     css="""
     .gradio-container {max-width: 900px; margin: auto;}
-    .status-message {font-size: 16px; padding: 15px; border-radius: 8px; margin: 10px 0;}
-    .success {background: linear-gradient(135deg, #d4edda, #c3e6cb); color: #155724; border: 1px solid #c3e6cb;}
-    .error {background: linear-gradient(135deg, #f8d7da, #f5c6cb); color: #721c24; border: 1px solid #f5c6cb;}
-    .input-section {background: #f8f9fa; padding: 20px; border-radius: 10px; margin: 10px 0;}
-    .btn-primary {background: linear-gradient(45deg, #007bff, #0056b3);}
+    .status {padding: 15px; border-radius: 8px; margin: 10px 0;}
+    .success {background: #d4edda; color: #155724; border-left: 4px solid #28a745;}
+    .error {background: #f8d7da; color: #721c24; border-left: 4px solid #dc3545;}
+    .input-group {background: #f8f9fa; padding: 15px; border-radius: 8px; margin: 10px 0;}
     """
 ) as demo:
     
-    gr.Markdown("""
-    # 📄 Professional PDF Generator
-    ### Create structured PDFs with Title, Plan, Names & Images
-    
-    **How to use:**
-    1. **Title**: Enter your document title
-    2. **Plan**: Add detailed plan/instructions 
-    3. **Names**: Comma-separated participant names
-    4. **Images**: Upload matching number of images
-    5. **Generate**: Create professional PDF
-    """)
+    gr.Markdown("# 📄 Professional PDF Generator")
+    gr.Markdown("Create PDFs with **Title**, **Plan**, **Names**, and **Images**")
     
     with gr.Tabs():
-        with gr.TabItem("📝 Document Setup"):
+        with gr.TabItem("📝 Document Content", icon="edit"):
             with gr.Row():
-                with gr.Column(scale=1):
+                with gr.Column(scale=2):
                     title_input = gr.Textbox(
-                        label="📛 Document Title", 
-                        placeholder="Enter your main title here...",
+                        label="📛 Document Title *", 
+                        placeholder="Enter main title (required)",
                         lines=1
                     )
-                    
                     plan_input = gr.Textbox(
-                        label="📋 Plan/Details", 
-                        placeholder="Enter your plan, instructions, or additional details...",
+                        label="📋 Plan/Details *", 
+                        placeholder="Enter plan, instructions, or description (required)",
                         lines=4
                     )
                 
                 with gr.Column(scale=1):
                     names_input = gr.Textbox(
-                        label="👥 Participant Names", 
+                        label="👥 Names (comma-separated) *",
                         placeholder="John Doe, Jane Smith, Bob Wilson",
                         lines=3
                     )
             
-            with gr.Row():
-                images_input = gr.File(
-                    label="🖼️ Upload Images", 
-                    file_count="multiple",
-                    file_types=["image"],
-                    elem_classes="input-section"
-                )
+            images_input = gr.File(
+                label="🖼️ Upload Images *", 
+                file_count="multiple",
+                file_types=[".jpg", ".jpeg", ".png"],
+                elem_classes="input-group"
+            )
         
-        with gr.TabItem("⚙️ Preview & Generate"):
-            gr.Markdown("### 📊 Input Summary")
-            summary = gr.Markdown("No inputs yet. Fill the form above!")
-            
+        with gr.TabItem("⚙️ Controls"):
             with gr.Row():
-                generate_btn = gr.Button("🚀 Generate Professional PDF", variant="primary", size="lg")
-                clear_btn = gr.Button("🗑️ Clear All", variant="secondary")
-                validate_btn = gr.Button("🔍 Validate Inputs", variant="secondary")
+                generate_btn = gr.Button("🚀 Generate PDF", variant="primary", size="lg")
+                validate_btn = gr.Button("🔍 Validate", variant="secondary")
+                clear_btn = gr.Button("🗑️ Clear All", variant="stop")
+            
+            status_output = gr.Markdown("Ready to generate PDF", elem_classes="status")
     
-    status_output = gr.Markdown("", elem_classes="status-message")
-    pdf_output = gr.File(label="📥 Download Professional PDF", elem_classes="input-section")
+    pdf_output = gr.File(label="📥 Download PDF", elem_classes="input-group")
     
     # Event handlers
     def validate_inputs(title, plan, names, images):
-        issues = []
+        errors = []
         names_list = [n.strip() for n in names.split(',') if n.strip()]
         
-        if not title.strip():
-            issues.append("❌ Title is required")
-        if not plan.strip():
-            issues.append("❌ Plan is required")
-        if len(names_list) != len(images or []):
-            issues.append(f"❌ Names ({len(names_list)}) and images ({len(images or [])}) count mismatch")
+        if not title.strip(): errors.append("• Title is required")
+        if not plan.strip(): errors.append("• Plan is required") 
+        if not names.strip(): errors.append("• Names are required")
+        if len(names_list) != len(images or []): 
+            errors.append(f"• Names ({len(names_list)}) ≠ Images ({len(images or [])})")
         
-        if issues:
-            return "\n".join(issues), gr.update(visible=False)
-        else:
-            return "✅ All inputs valid! Ready to generate PDF.", gr.update(visible=True)
-    
-    def clear_all():
-        return ("", "", "", None, "Ready to create new document!", gr.update(value=None), "No inputs yet.")
+        if errors:
+            return f"❌ **Validation Errors:**\n" + "\n".join(errors), gr.update(visible=False)
+        return "✅ **All inputs valid!** Click Generate PDF.", gr.update(visible=True)
     
     generate_btn.click(
         fn=generate_pdf,
@@ -224,8 +202,8 @@ with gr.Blocks(
     )
     
     clear_btn.click(
-        fn=clear_all,
-        outputs=[title_input, plan_input, names_input, images_input, status_output, pdf_output, summary]
+        fn=lambda: ("", "", "", None, "Form cleared. Ready to create new PDF!"),
+        outputs=[title_input, plan_input, names_input, images_input, status_output]
     )
 
 if __name__ == "__main__":