Update app.py

app.py

@@ -1,4 +1,4 @@
-# app.py - Fixed PDF Generator with proper temp file handling
+# app.py - Fixed PDF Generator (Runtime Error Free)
 
 import gradio as gr
 from fpdf import FPDF
@@ -6,188 +6,170 @@ import os
 import tempfile
 import re
 import pandas as pd
-import requests
 from pathlib import Path
 import io
 
 class UnicodePDF(FPDF):
     def __init__(self):
         super().__init__()
-        self.add_font('DejaVu', '', '/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf', uni=True)
-        self.add_font('DejaVu', 'B', '/usr/share/fonts/truetype/dejavu/DejaVuSans-Bold.ttf', uni=True)
-        self.set_font('DejaVu', '', 12)
+        # Use Arial Unicode MS or fallback to core fonts
+        self.set_font('Arial', '', 12)
     
     def footer(self):
         self.set_y(-15)
-        self.set_font('DejaVu', 'I', 8)
+        self.set_font('Arial', 'I', 8)
         self.cell(0, 10, f'Page {self.page_no()}', 0, 0, 'C')
 
-def ensure_fonts():
-    """Ensure Unicode fonts are available"""
-    font_paths = [
-        '/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf',
-        '/usr/share/fonts/truetype/dejavu/DejaVuSans-Bold.ttf'
-    ]
-    return all(os.path.exists(path) for path in font_paths)
+def clean_text(text, max_length=100):
+    """Clean text for PDF compatibility"""
+    # Remove or replace problematic Unicode characters
+    replacements = {
+        '–': '-', '—': '-', '“': '"', '”': '"', '‘': "'", '’': "'",
+        '•': '*', '°': 'deg', '™': '(TM)', '®': '(R)', '©': '(C)'
+    }
+    for old, new in replacements.items():
+        text = text.replace(old, new)
+    
+    # Remove remaining problematic characters
+    text = re.sub(r'[^\w\s\-.,!?\(\)\[\]:;0-9]', ' ', text)
+    return ' '.join(text.split())[:max_length]
 
 def generate_pdf(title, plan, names, image_files):
-    # Validate inputs
+    # Input validation
     if not title or not title.strip():
-        return None, "❌ Please enter a title!"
+        return None, "❌ Title is required!"
     
     if not plan or not plan.strip():
-        return None, "❌ Please enter the plan details!"
+        return None, "❌ Plan is required!"
     
     names_list = [n.strip() for n in names.split(',') if n.strip()]
     
+    if not names_list:
+        return None, "❌ At least one name is required!"
+    
     if not image_files:
-        return None, "❌ Please upload at least one image!"
+        return None, "❌ At least one image is required!"
     
     if len(names_list) != len(image_files):
-        return None, f"❌ Mismatch! {len(names_list)} names but {len(image_files)} images."
+        return None, f"❌ Mismatch: {len(names_list)} names vs {len(image_files)} images"
     
     try:
         pdf = UnicodePDF()
         pdf.set_margins(20, 20, 20)
-        pdf.set_auto_page_break(auto=True, margin=20)
         
-        # Clean title and plan for PDF compatibility
-        clean_title = re.sub(r'[^\w\s\-–—]', ' ', title)[:100]
-        clean_plan = re.sub(r'[^\w\s\-\n\.\,\!\?\(\)]', ' ', plan)
+        # Clean inputs
+        clean_title = clean_text(title, 80)
+        clean_plan = clean_text(plan, 500)
         
         # Title Page
         pdf.add_page()
-        pdf.set_font('DejaVu', 'B', 24)
+        pdf.set_font('Arial', 'B', 22)
         pdf.cell(0, 20, clean_title, ln=1, align='C')
         
         pdf.ln(10)
-        pdf.set_font('DejaVu', '', 12)
+        pdf.set_font('Arial', '', 12)
         pdf.multi_cell(0, 8, clean_plan)
         
-        pdf.ln(10)
-        pdf.set_font('DejaVu', 'I', 10)
+        pdf.ln(15)
+        pdf.set_font('Arial', 'I', 10)
         pdf.cell(0, 10, f"Generated: {pd.Timestamp.now().strftime('%Y-%m-%d %H:%M')}", ln=1, align='C')
-        pdf.cell(0, 10, f"Participants: {len(names_list)}", ln=1, align='C')
+        pdf.cell(0, 10, f"Total Participants: {len(names_list)}", ln=1, align='C')
         
-        # Content Pages
+        # Individual participant pages
         for i, (name, img_path) in enumerate(zip(names_list, image_files)):
             pdf.add_page()
             
-            # Clean name for PDF
-            clean_name = re.sub(r'[^\w\s\-]', ' ', name)[:50].strip()
-            pdf.set_font('DejaVu', 'B', 18)
+            # Clean name
+            clean_name = clean_text(name, 50)
+            pdf.set_font('Arial', 'B', 18)
             pdf.cell(0, 15, clean_name.upper(), ln=1, align='C')
             
-            pdf.set_font('DejaVu', '', 12)
-            pdf.cell(0, 8, f"Participant #{i+1}/{len(names_list)}", ln=1, align='C')
+            pdf.set_font('Arial', '', 12)
+            pdf.cell(0, 10, f"Participant #{i+1} of {len(names_list)}", ln=1, align='C')
             
-            # Add image with proper error handling
+            # Try to add image
             try:
-                # Read image file properly
                 if os.path.exists(img_path):
                     img_width = 120
                     x_pos = (pdf.w - img_width) / 2
                     pdf.image(img_path, x=x_pos, y=50, w=img_width)
                     
-                    # Add caption
-                    pdf.set_font('DejaVu', 'I', 10)
-                    pdf.set_xy(x_pos, pdf.get_y() + 5)
-                    pdf.multi_cell(img_width, 5, f"Photo: {clean_name}", align='C')
+                    # Image caption
+                    pdf.set_xy(x_pos, pdf.get_y() + 10)
+                    pdf.set_font('Arial', 'I', 10)
+                    pdf.multi_cell(img_width, 6, f"Photo ID: {i+1}", align='C')
                 else:
-                    raise FileNotFoundError(f"Image file not found: {img_path}")
-                    
-            except Exception as img_error:
-                pdf.set_font('DejaVu', '', 12)
-                pdf.cell(0, 10, f"⚠️ Image unavailable for {clean_name}", ln=1, align='C')
-                pdf.set_font('DejaVu', 'I', 10)
-                pdf.cell(0, 10, f"Error: {str(img_error)[:80]}", ln=1, align='C')
+                    raise FileNotFoundError("Image file not accessible")
+            except Exception as img_err:
+                pdf.set_font('Arial', '', 12)
+                pdf.set_text_color(150, 150, 150)
+                pdf.cell(0, 10, f"Image unavailable for {clean_name}", ln=1, align='C')
+                pdf.set_text_color(0, 0, 0)
         
-        # Save PDF to BytesIO (more reliable than temp files)
-        pdf_output = io.BytesIO()
-        pdf_output.write(pdf.output(dest='S').encode('latin1'))  # FPDF outputs bytes
-        pdf_output.seek(0)
+        # Generate PDF file properly
+        output_buffer = io.BytesIO()
+        pdf_output = pdf.output(dest='S')
+        output_buffer.write(pdf_output.encode('latin1'))
+        output_buffer.seek(0)
         
-        # Create proper temp file from bytes
-        with tempfile.NamedTemporaryFile(suffix='.pdf', delete=False) as tmp_file:
-            tmp_file.write(pdf_output.getvalue())
-            tmp_file.flush()
+        # Create temp file
+        with tempfile.NamedTemporaryFile(mode='wb', suffix='.pdf', delete=False) as tmp_file:
+            tmp_file.write(output_buffer.getvalue())
             output_path = tmp_file.name
         
-        success_msg = f"✅ PDF Generated Successfully!\n📄 Title: {clean_title}\n👥 {len(names_list)} Participants"
+        success_msg = f"✅ Success!\n📄 Title: {clean_title[:50]}...\n👥 {len(names_list)} participants\n📄 {len(names_list) + 1} pages"
         return output_path, success_msg
         
     except Exception as e:
-        return None, f"❌ Error: {str(e)}\nPlease check inputs and try again."
+        return None, f"❌ Error: {str(e)}\nPlease check your inputs."
 
-# Enhanced UI
-with gr.Blocks(
-    title="📄 Pro PDF Generator",
-    theme=gr.themes.Soft(),
-    css="""
-    .gradio-container {max-width: 900px; margin: auto;}
-    .status {padding: 15px; border-radius: 8px; margin: 10px 0;}
-    .success {background: #d4edda; color: #155724; border-left: 4px solid #28a745;}
-    .error {background: #f8d7da; color: #721c24; border-left: 4px solid #dc3545;}
-    .input-group {background: #f8f9fa; padding: 15px; border-radius: 8px; margin: 10px 0;}
-    """
-) as demo:
-    
+# Clean Gradio UI without problematic parameters
+with gr.Blocks(title="PDF Generator Pro") as demo:
     gr.Markdown("# 📄 Professional PDF Generator")
-    gr.Markdown("Create PDFs with **Title**, **Plan**, **Names**, and **Images**")
-    
-    with gr.Tabs():
-        with gr.TabItem("📝 Document Content", icon="edit"):
-            with gr.Row():
-                with gr.Column(scale=2):
-                    title_input = gr.Textbox(
-                        label="📛 Document Title *", 
-                        placeholder="Enter main title (required)",
-                        lines=1
-                    )
-                    plan_input = gr.Textbox(
-                        label="📋 Plan/Details *", 
-                        placeholder="Enter plan, instructions, or description (required)",
-                        lines=4
-                    )
-                
-                with gr.Column(scale=1):
-                    names_input = gr.Textbox(
-                        label="👥 Names (comma-separated) *",
-                        placeholder="John Doe, Jane Smith, Bob Wilson",
-                        lines=3
-                    )
+    gr.Markdown("""
+    **Create PDFs with:**
+    - Document Title & Plan
+    - Individual participant pages
+    - Names + Images
+    """)
+    
+    with gr.Row():
+        with gr.Column(scale=2):
+            title_input = gr.Textbox(
+                label="📛 Document Title *",
+                placeholder="Enter your document title",
+                lines=2
+            )
+            
+            plan_input = gr.Textbox(
+                label="📋 Plan / Description *",
+                placeholder="Enter detailed plan or description",
+                lines=5
+            )
             
+            names_input = gr.Textbox(
+                label="👥 Names (comma-separated) *",
+                placeholder="John Doe, Jane Smith, Bob Wilson",
+                lines=3
+            )
+        
+        with gr.Column(scale=1):
             images_input = gr.File(
-                label="🖼️ Upload Images *", 
+                label="🖼️ Upload Images *",
                 file_count="multiple",
-                file_types=[".jpg", ".jpeg", ".png"],
-                elem_classes="input-group"
+                file_types=[".jpg", ".jpeg", ".png", ".webp"]
             )
-        
-        with gr.TabItem("⚙️ Controls"):
-            with gr.Row():
-                generate_btn = gr.Button("🚀 Generate PDF", variant="primary", size="lg")
-                validate_btn = gr.Button("🔍 Validate", variant="secondary")
-                clear_btn = gr.Button("🗑️ Clear All", variant="stop")
-            
-            status_output = gr.Markdown("Ready to generate PDF", elem_classes="status")
     
-    pdf_output = gr.File(label="📥 Download PDF", elem_classes="input-group")
+    with gr.Row():
+        generate_btn = gr.Button("🚀 Generate PDF", variant="primary", size="lg")
+        clear_btn = gr.Button("🗑️ Clear All", variant="secondary")
+    
+    status_output = gr.Markdown("Ready to generate PDF")
+    pdf_output = gr.File(label="📥 Download PDF")
     
     # Event handlers
-    def validate_inputs(title, plan, names, images):
-        errors = []
-        names_list = [n.strip() for n in names.split(',') if n.strip()]
-        
-        if not title.strip(): errors.append("• Title is required")
-        if not plan.strip(): errors.append("• Plan is required") 
-        if not names.strip(): errors.append("• Names are required")
-        if len(names_list) != len(images or []): 
-            errors.append(f"• Names ({len(names_list)}) ≠ Images ({len(images or [])})")
-        
-        if errors:
-            return f"❌ **Validation Errors:**\n" + "\n".join(errors), gr.update(visible=False)
-        return "✅ **All inputs valid!** Click Generate PDF.", gr.update(visible=True)
+    def clear_all():
+        return ("", "", "", None, "Form cleared!")
     
     generate_btn.click(
         fn=generate_pdf,
@@ -195,16 +177,21 @@ with gr.Blocks(
         outputs=[pdf_output, status_output]
     )
     
-    validate_btn.click(
-        fn=validate_inputs,
-        inputs=[title_input, plan_input, names_input, images_input],
-        outputs=[status_output, generate_btn]
-    )
-    
     clear_btn.click(
-        fn=lambda: ("", "", "", None, "Form cleared. Ready to create new PDF!"),
+        fn=clear_all,
         outputs=[title_input, plan_input, names_input, images_input, status_output]
     )
+    
+    # Real-time validation
+    def validate_names(names):
+        names_list = [n.strip() for n in names.split(',') if n.strip()]
+        return f"Found {len(names_list)} names"
+    
+    names_input.change(
+        fn=validate_names,
+        inputs=[names_input],
+        outputs=[status_output]
+    )
 
 if __name__ == "__main__":
     demo.launch()