Update app.py

app.py

@@ -1,41 +1,140 @@
-# app.py for Hugging Face Spaces
+# app.py - Fixed PDF Generator with better error handling and UI
 
 import gradio as gr
 from fpdf import FPDF
+import os
+import tempfile
+from pathlib import Path
 
 def generate_pdf(names, image_files):
+    # Clean and validate names
+    if not names or names.strip() == "":
+        return None, "❌ Please enter at least one name!"
+    
     names_list = [n.strip() for n in names.split(',') if n.strip()]
     
+    # Validate images
     if not image_files:
-        return "Please upload at least one image."
+        return None, "❌ Please upload at least one image!"
     
+    # Check if number of names matches number of images
     if len(names_list) != len(image_files):
-        return f"Mismatch: {len(names_list)} names but {len(image_files)} images. Please provide matching numbers."
-    
-    pdf = FPDF()
-    
-    for name, img_path in zip(names_list, image_files):
-        pdf.add_page()
-        pdf.set_font('helvetica', 'B', 16)
-        pdf.cell(0, 10, name, ln=1, align='C')
-        try:
-            pdf.image(img_path, x=50, y=30, w=100)  # Adjust positions and size as needed
-        except Exception as e:
-            return f"Error adding image: {str(e)}"
-    
-    output_path = "output.pdf"
-    pdf.output(output_path)
-    return output_path
+        return None, f"❌ Mismatch! You have {len(names_list)} names but {len(image_files)} images. Please match the counts."
+    
+    try:
+        pdf = FPDF()
+        pdf.set_auto_page_break(auto=True, margin=15)
+        
+        for i, (name, img_path) in enumerate(zip(names_list, image_files)):
+            # Add new page for each item
+            pdf.add_page()
+            
+            # Add title/name
+            pdf.set_font('helvetica', 'B', 20)
+            pdf.set_text_color(50, 50, 50)
+            pdf.cell(0, 15, name.upper(), ln=1, align='C')
+            
+            # Add subtitle
+            pdf.set_font('helvetica', '', 12)
+            pdf.cell(0, 10, f"ID: {i+1}", ln=1, align='C')
+            
+            # Add image with error handling
+            try:
+                # Get image dimensions for better scaling
+                img_width = 120
+                img_height = pdf.get_string_width(name) * 0.8  # Approximate
+                
+                # Calculate position to center image
+                page_width = pdf.w
+                x_pos = (page_width - img_width) / 2
+                
+                pdf.image(img_path, x=x_pos, y=40, w=img_width)
+                
+            except Exception as img_error:
+                # If image fails, add placeholder text
+                pdf.set_font('helvetica', 'I', 14)
+                pdf.set_text_color(200, 50, 50)
+                pdf.cell(0, 10, f"Image {i+1} could not be loaded", ln=1, align='C')
+                pdf.cell(0, 10, str(img_error), ln=1, align='C')
+        
+        # Create temporary file for output
+        with tempfile.NamedTemporaryFile(delete=False, suffix='.pdf') as tmp_file:
+            output_path = tmp_file.name
+            pdf.output(output_path)
+        
+        success_msg = f"✅ Successfully generated PDF with {len(names_list)} pages!"
+        return output_path, success_msg
+        
+    except Exception as e:
+        return None, f"❌ Error generating PDF: {str(e)}"
 
-with gr.Blocks() as demo:
-    gr.Markdown("# PDF Generator App")
-    gr.Markdown("Enter comma-separated names and upload corresponding images to generate a PDF.")
+# Create beautiful UI
+with gr.Blocks(
+    title="📄 PDF Generator Pro",
+    theme=gr.themes.Soft(),
+    css="""
+    .gradio-container {max-width: 800px; margin: auto;}
+    .status-message {font-size: 16px; padding: 10px; border-radius: 5px; margin: 10px 0;}
+    .success {background-color: #d4edda; color: #155724; border: 1px solid #c3e6cb;}
+    .error {background-color: #f8d7da; color: #721c24; border: 1px solid #f5c6cb;}
+    """
+) as demo:
+    
+    gr.Markdown("""
+    # 📄 PDF Generator Pro
+    ### Create professional PDFs with names and images
+    **Instructions:**
+    1. Enter names separated by commas (e.g., "John Doe, Jane Smith, Bob Wilson")
+    2. Upload the same number of images as names
+    3. Click Generate PDF
+    4. Download your professional PDF!
+    """)
+    
+    with gr.Row():
+        with gr.Column(scale=1):
+            names_input = gr.Textbox(
+                label="👥 Names (comma-separated)", 
+                placeholder="John Doe, Jane Smith, Bob Wilson",
+                lines=3,
+                elem_id="names-input"
+            )
+            
+            with gr.Row():
+                generate_btn = gr.Button("🚀 Generate PDF", variant="primary", size="lg")
+                clear_btn = gr.Button("🗑️ Clear All", variant="secondary")
+        
+        with gr.Column(scale=1):
+            images_input = gr.File(
+                label="🖼️ Upload Images", 
+                file_count="multiple",
+                file_types=["image"],
+                elem_id="images-input"
+            )
+    
+    status_output = gr.Markdown("", elem_classes="status-message")
+    pdf_output = gr.File(label="📥 Download Your PDF", elem_id="pdf-output")
+    
+    # Event handlers
+    def clear_all():
+        return "", None, gr.update(value=[]), "Ready to create new PDF!"
+    
+    generate_btn.click(
+        fn=generate_pdf,
+        inputs=[names_input, images_input],
+        outputs=[pdf_output, status_output]
+    )
     
-    names_input = gr.Textbox(label="Names (comma-separated)", placeholder="Name1, Name2, Name3")
-    images_input = gr.File(label="Upload Images", file_count="multiple", file_types=[".jpg", ".png", ".jpeg"])
-    generate_btn = gr.Button("Generate PDF")
-    output_file = gr.File(label="Download PDF")
+    clear_btn.click(
+        fn=clear_all,
+        outputs=[names_input, pdf_output, images_input, status_output]
+    )
     
-    generate_btn.click(fn=generate_pdf, inputs=[names_input, images_input], outputs=output_file)
+    # Auto-validation example
+    names_input.change(
+        fn=lambda names: (None, f"📝 Found {len([n.strip() for n in names.split(',') if n.strip()])} names") if names else (None, ""),
+        inputs=[names_input],
+        outputs=[pdf_output, status_output]
+    )
 
-demo.launch()
+if __name__ == "__main__":
+    demo.launch()