Update data/calculation.py

data/calculation.py

@@ -308,7 +308,11 @@ class TFMCalculations:
         References:
             ASHRAE Handbook—Fundamentals, Chapters 15 and 18.
         """
+        component_id = getattr(component, 'id', 'unknown_component')
+        logger.info(f"Processing solar load for component {component_id}, type: {component.component_type}, mode: {mode}, return_details: {return_details}")
+        
         if mode != "cooling" or component.component_type not in [ComponentType.WINDOW, ComponentType.SKYLIGHT]:
+            logger.debug(f"Skipping solar load for {component_id}: mode={mode}, type={component.component_type}")
             return 0, None
 
         details = {} if return_details else None
@@ -346,10 +350,8 @@ class TFMCalculations:
                              "diffuse_horizontal_radiation", "dry_bulb"]
             if not all(field in hourly_data for field in required_fields):
                 logger.warning(f"Missing required fields in hourly_data for hour {hour}: {hourly_data}")
-                return 0, details
-
-            if hourly_data["global_horizontal_radiation"] <= 0:
-                logger.info(f"No solar load for hour {hour} due to GHI={hourly_data['global_horizontal_radiation']}")
+                if return_details:
+                    details["error"] = f"Missing required climate data fields: {required_fields}"
                 return 0, details
 
             month = hourly_data["month"]
@@ -360,10 +362,6 @@ class TFMCalculations:
             dhi = hourly_data.get("diffuse_horizontal_radiation", ghi * 0.3)
             outdoor_temp = hourly_data["dry_bulb"]
 
-            if ghi < 0 or dni < 0 or dhi < 0:
-                logger.error(f"Negative radiation values for {month}/{day}/{hour}")
-                raise ValueError(f"Negative radiation values for {month}/{day}/{hour}")
-
             if return_details:
                 details["component"] = {
                     "name": getattr(component, 'name', 'unknown'),
@@ -388,6 +386,16 @@ class TFMCalculations:
                     "ground_reflectivity": ground_reflectivity
                 }
 
+            if ghi < 0 or dni < 0 or dhi < 0:
+                logger.error(f"Negative radiation values for {month}/{day}/{hour}")
+                if return_details:
+                    details["error"] = "Negative radiation values"
+                return 0, details
+
+            if ghi <= 0:
+                logger.info(f"No solar load for {component_id} at hour {hour} due to GHI={ghi}")
+                return 0, details  # Return details even if GHI is zero for first hour
+
             logger.info(f"Processing solar for {month}/{day}/{hour} with GHI={ghi}, DNI={dni}, DHI={dhi}, "
                        f"dry_bulb={outdoor_temp}")
 
@@ -447,9 +455,9 @@ class TFMCalculations:
                         shgc = glazing_material_obj.shgc
                         h_o = glazing_material_obj.h_o
                     else:
-                        logger.warning(f"Glazing material '{glazing_material.name}' not found for {component.id}. Using default SHGC=0.7.")
+                        logger.warning(f"Glazing material '{glazing_material.name}' not found for {component_id}. Using default SHGC=0.7.")
                 else:
-                    logger.warning(f"No glazing material defined for {component.id}. Using default SHGC=0.7.")
+                    logger.warning(f"No glazing material defined for {component_id}. Using default SHGC=0.7.")
 
             cos_theta = (math.sin(math.radians(alpha)) * math.cos(math.radians(surface_tilt)) +
                          math.cos(math.radians(alpha)) * math.sin(math.radians(surface_tilt)) *
@@ -463,7 +471,7 @@ class TFMCalculations:
                     "cos_incidence_angle": cos_theta
                 }
 
-            logger.info(f"  Component {getattr(component, 'id', 'unknown_component')} at {month}/{day}/{hour}: "
+            logger.info(f"  Component {component_id} at {month}/{day}/{hour}: "
                         f"surface_tilt={surface_tilt:.2f}, surface_azimuth={surface_azimuth:.2f}, "
                         f"cos_theta={cos_theta:.2f}")
 
@@ -489,15 +497,16 @@ class TFMCalculations:
                     "solar_heat_gain_kw": solar_heat_gain
                 }
 
-            logger.info(f"Solar heat gain for {getattr(component, 'id', 'unknown_component')} at {month}/{day}/{hour}: "
+            logger.info(f"Solar heat gain for {component_id} at {month}/{day}/{hour}: "
                         f"{solar_heat_gain:.2f} kW (area={component.area}, shgc_dynamic={shgc_dynamic:.2f}, "
                         f"I_t={I_t:.2f}, iac={iac})")
             
             return solar_heat_gain, details
 
         except Exception as e:
-            component_id = getattr(component, 'id', 'unknown_component')
             logger.error(f"Error calculating solar load for component {component_id} at hour {hour}: {str(e)}")
+            if return_details:
+                details["error"] = str(e)
             return 0, details
 
     @staticmethod
@@ -666,10 +675,21 @@ class TFMCalculations:
         operating_periods = hvac_settings.get("operating_hours", [{"start": 8, "end": 18}])
         area = building_info.get("floor_area", 100.0)
         
+        # Log available windows and skylights
+        windows = components.get("windows", [])
+        skylights = components.get("skylights", [])
+        logger.info(f"Windows defined: {len(windows)}, Skylights defined: {len(skylights)}")
+        for comp in windows + skylights:
+            logger.debug(f"Component: {comp.name}, Type: {comp.component_type}, Area: {comp.area}, SHGC: {comp.shgc}")
+
         for comp_list in components.values():
             for comp in comp_list:
                 comp.ctf = CTFCalculator.calculate_ctf_coefficients(comp)
 
+        if not filtered_data:
+            logger.warning("No filtered hourly data available for simulation")
+            return {"loads": [], "solar_details_first_hour": []}
+
         for idx, hour_data in enumerate(filtered_data):
             hour = hour_data["hour"]
             outdoor_temp = hour_data["dry_bulb"]
@@ -684,6 +704,10 @@ class TFMCalculations:
                     is_operating = True
                     break
             mode = "none" if abs(outdoor_temp - 18) < 0.01 else "cooling" if outdoor_temp > 18 else "heating"
+            if idx == 0:
+                logger.info(f"First hour: {hour_data['month']}/{hour_data['day']}/{hour}, Outdoor Temp: {outdoor_temp}°C, Mode: {mode}, Operating: {is_operating}")
+                logger.debug(f"Climate data for first hour: {hour_data}")
+            
             if is_operating and mode == "cooling":
                 for comp_list in components.values():
                     for comp in comp_list:
@@ -695,6 +719,7 @@ class TFMCalculations:
                         solar += solar_load
                         if idx == 0 and details:
                             solar_details_first_hour.append(details)
+                            logger.debug(f"Solar details for {comp.name}: {details}")
                 internal = TFMCalculations.calculate_internal_load(internal_loads, hour, max([p["end"] - p["start"] for p in operating_periods]), area)
                 ventilation_cooling, _ = TFMCalculations.calculate_ventilation_load(internal_loads, outdoor_temp, indoor_temp, area, building_info, mode="cooling")
                 infiltration_cooling, _ = TFMCalculations.calculate_infiltration_load(internal_loads, outdoor_temp, indoor_temp, area, building_info, mode="cooling")
@@ -746,6 +771,7 @@ class TFMCalculations:
                     load["total_cooling"] = 0
                     load["total_heating"] = 0
                 final_loads.append(load)
+        logger.info(f"Solar details collected for first hour: {len(solar_details_first_hour)} entries")
         return {
             "loads": final_loads,
             "solar_details_first_hour": solar_details_first_hour