mock executor logic fix

app.py

@@ -3,7 +3,6 @@ import json
 import uuid
 import httpx
 import asyncio
-import requests
 from datetime import datetime, timezone
 from flask import Flask, request, jsonify
 from flask_jwt_extended import (
@@ -349,13 +348,15 @@ def execute_action(action_id):
         f"Running runbook for {action['type']}",
     )
 
-    # ---> Call the Mock HTTP Executor
-    mock_executor_url = request.host_url.rstrip("/") + "/api/mock_executor"
-    resp = requests.post(
-        mock_executor_url, json={"action": action["action"], "type": action["type"]}
+    # perform the mock execution directly rather than via HTTP
+    result, status_code = mock_executor_logic(
+        {
+            "action": action["action"],
+            "type": action["type"],
+        }
     )
 
-    if resp.status_code == 200:
+    if status_code == 200 and result.get("status") == "OK":
         action["status"] = "SUCCESS"
         add_audit_log(
             action["case_id"],
@@ -373,19 +374,30 @@ def execute_action(action_id):
 
 
 # ---------------------------------------------------------
-# 5. Mock HTTP Executor
+# helper for mock execution logic (used by both the API handler and direct calls)
 # ---------------------------------------------------------
-@app.route("/api/mock_executor", methods=["POST"])
-@jwt_required()
-def mock_executor():
-    data = request.json
+def mock_executor_logic(data: dict):
+    """Simulate performing an action. Returns tuple (response_dict, status_code)."""
     import time
 
     time.sleep(2)
     print(
         f"[MOCK EXECUTOR] Successfully applied {data.get('type')}: {data.get('action')}"
     )
-    return jsonify({"status": "OK", "run_id": f"RUN-{uuid.uuid4().hex[:6]}"}), 200
+    return {"status": "OK", "run_id": f"RUN-{uuid.uuid4().hex[:6]}"}, 200
+
+
+# ---------------------------------------------------------
+# 5. Mock HTTP Executor
+# ---------------------------------------------------------
+@app.route("/api/mock_executor", methods=["POST"])
+@jwt_required()
+def mock_executor():
+    # this route is retained for compatibility but now simply invokes the
+    # shared logic rather than duplicating it or being called by other
+    # endpoints.
+    result, status_code = mock_executor_logic(request.json or {})
+    return jsonify(result), status_code
 
 
 # ---------------------------------------------------------