tests: fix import-time KeyError by ensuring OPENAI_ in conftest and lazy-import router in test_ambiguity

app/routers/nl2sql.py

@@ -25,18 +25,21 @@ if os.getenv("DB_MODE", "sqlite") == "postgres":
 else:
     _db = SQLiteAdapter("data/chinook.db")
 
-# --- Composition Root ---
-_llm = OpenAIProvider()
+
+def get_llm():
+    return OpenAIProvider()
+
+
 # _db = SQLiteAdapter("data/chinook.db")
 _executor = Executor(_db)
 _verifier = Verifier()
-_repair = Repair(_llm)
+_repair = Repair(get_llm())
 
 
 _pipeline = Pipeline(
     detector=AmbiguityDetector(),
-    planner=Planner(_llm),
-    generator=Generator(_llm),
+    planner=Planner(get_llm()),
+    generator=Generator(get_llm()),
     safety=Safety(),
     executor=_executor,
     verifier=_verifier,

tests/conftest.py

@@ -3,5 +3,16 @@ from dotenv import load_dotenv
 
 ROOT_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
 ENV_PATH = os.path.join(ROOT_DIR, ".env")
-
 load_dotenv(dotenv_path=ENV_PATH)
+
+
+# --- add: make tests independent of real OPENAI_* in CI ---
+def _ensure_openai_env_for_tests():
+    # map PROXY_* -> OPENAI_* or set a harmless dummy
+    if not os.getenv("OPENAI_API_KEY"):
+        os.environ["OPENAI_API_KEY"] = os.getenv("PROXY_API_KEY", "DUMMY_TEST_KEY")
+    if not os.getenv("OPENAI_BASE_URL") and os.getenv("PROXY_BASE_URL"):
+        os.environ["OPENAI_BASE_URL"] = os.environ["PROXY_BASE_URL"]
+
+
+_ensure_openai_env_for_tests()

tests/test_ambiguity.py

@@ -1,6 +1,5 @@
 from nl2sql.ambiguity_detector import AmbiguityDetector
 from nl2sql.types import StageResult
-from app.routers import nl2sql
 
 
 def test_detects_ambiguous_terms():
@@ -17,6 +16,8 @@ def test_not_false_positive():
 
 
 def test_ambiguity_response():
+    from app.routers import nl2sql
+
     fake_result = StageResult(
         ok=True, data={"ambiguous": True, "questions": ["Clarify column?"]}
     )