Update app/app.py

app/app.py

@@ -9,6 +9,7 @@ import asyncio
 import os
 import json
 import time
+from contextlib import asynccontextmanager
 from datetime import datetime, timezone
 
 import httpx
@@ -16,20 +17,16 @@ import socketio
 from fastapi import FastAPI
 from fastapi.staticfiles import StaticFiles
 
+# Relative imports for our package structure
 from .price_fetcher import PriceFetcher
 from .arbitrage_analyzer import ArbitrageAnalyzer
 
 OPPORTUNITY_THRESHOLD = 0.0015
 
 # --- Socket.IO Server Setup ---
-# We create the server instance that will manage all real-time communication.
+# This creates the server instance that will handle all real-time communication.
 sio = socketio.AsyncServer(async_mode='asgi', cors_allowed_origins='*')
 
-# --- FastAPI App Setup ---
-# The FastAPI app is now simpler. It only serves the static files.
-app = FastAPI()
-app.mount("/", StaticFiles(directory="static", html=True), name="static")
-
 # --- Background Engine ---
 async def run_arbitrage_detector(price_fetcher, analyzer):
     """The core engine loop. Detects opportunities and emits them via Socket.IO."""
@@ -59,6 +56,7 @@ async def run_arbitrage_detector(price_fetcher, analyzer):
                             briefing = await analyzer.get_alpha_briefing(asset, opportunity)
                             if briefing:
                                 signal = {**opportunity, **briefing, "timestamp": datetime.now(timezone.utc).isoformat()}
+                                # Directly emit to all connected clients
                                 await sio.emit('new_signal', signal)
                                 print(f"✅ Signal Emitted for {asset}: {signal['strategy']}")
         except Exception as e:
@@ -67,12 +65,13 @@ async def run_arbitrage_detector(price_fetcher, analyzer):
         await asyncio.sleep(15)
 
 # --- Socket.IO Lifespan Events ---
-# This is the CORRECT way to manage background tasks with python-socketio.
+# This is the correct way to manage background tasks with python-socketio.
 @sio.on('connect')
 async def connect(sid, environ):
+    """Handles new client connections."""
     print(f"✅ Client connected: {sid}")
     # Start the engine only when the first user connects.
-    if sio.background_task is None:
+    if not hasattr(sio, 'background_task') or sio.background_task.done():
         print("🚀 First client connected. Starting Sentinel Engine...")
         price_fetcher = PriceFetcher(httpx.AsyncClient())
         arbitrage_analyzer = ArbitrageAnalyzer(httpx.AsyncClient())
@@ -82,9 +81,15 @@ async def connect(sid, environ):
 
 @sio.on('disconnect')
 def disconnect(sid):
+    """Handles client disconnections."""
     print(f"🔥 Client disconnected: {sid}")
 
-# --- Final ASGI App ---
-# We wrap the FastAPI app (for static files) and the Socket.IO app together.
-# The Socket.IO server is the primary application.
-combined_app = socketio.ASGIApp(sio, other_asgi_app=app)
+
+# --- FastAPI App & Final ASGI App ---
+# Create a minimal FastAPI app just to serve the static files.
+fastapi_app = FastAPI()
+fastapi_app.mount("/", StaticFiles(directory="static", html=True), name="static")
+
+# Wrap the FastAPI app (for static files) with the Socket.IO app.
+# The Socket.IO server is the primary application that handles requests.
+combined_app = socketio.ASGIApp(sio, other_asgi_app=fastapi_app)