Update app.py

app.py

@@ -424,9 +424,16 @@ def download_questions_file(questions_list, topic, grade_level, subject=None):
     if not questions_list:
         return None
     
+    def sanitize_filename(name: str) -> str:
+        # Replace unsafe characters with underscore
+        return re.sub(r"[^A-Za-z0-9_.()-]", "_", str(name))
+
     timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
-    subject_tag = f"_{subject}" if subject else ""
-    filename = f"questions_{grade_level}{subject_tag}_{topic}_{timestamp}.txt"
+    safe_grade = sanitize_filename(grade_level)
+    safe_topic = sanitize_filename(topic)
+    safe_subject = sanitize_filename(subject) if subject else ""
+    subject_tag = f"_{safe_subject}" if safe_subject else ""
+    filename = f"questions_{safe_grade}{subject_tag}_{safe_topic}_{timestamp}.txt"
     
     content = f"""UNEB EXAM PRACTICE QUESTIONS
 {'='*50}
@@ -453,7 +460,7 @@ INSTRUCTIONS:
 Good luck! 
 """
     
-    filepath = f"downloads/{filename}"
+    filepath = os.path.join("downloads", filename)
     os.makedirs("downloads", exist_ok=True)
     with open(filepath, "w", encoding="utf-8") as f:
         f.write(content)
@@ -471,10 +478,16 @@ def download_questions_pdf(questions_list, topic, grade_level, subject=None):
     except Exception:
         return None
 
+    def sanitize_filename(name: str) -> str:
+        return re.sub(r"[^A-Za-z0-9_.()-]", "_", str(name))
+
     timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
-    subject_tag = f"_{subject}" if subject else ""
-    filename = f"questions_{grade_level}{subject_tag}_{topic}_{timestamp}.pdf"
-    filepath = f"downloads/{filename}"
+    safe_grade = sanitize_filename(grade_level)
+    safe_topic = sanitize_filename(topic)
+    safe_subject = sanitize_filename(subject) if subject else ""
+    subject_tag = f"_{safe_subject}" if safe_subject else ""
+    filename = f"questions_{safe_grade}{subject_tag}_{safe_topic}_{timestamp}.pdf"
+    filepath = os.path.join("downloads", filename)
     os.makedirs("downloads", exist_ok=True)
 
     doc = SimpleDocTemplate(filepath, pagesize=A4, rightMargin=20*mm, leftMargin=20*mm, topMargin=20*mm, bottomMargin=20*mm)
@@ -506,9 +519,15 @@ def download_feedback_file(feedback_text, topic, grade_level, subject=None):
     if not feedback_text:
         return None
     
+    def sanitize_filename(name: str) -> str:
+        return re.sub(r"[^A-Za-z0-9_.()-]", "_", str(name))
+
     timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
-    subject_tag = f"_{subject}" if subject else ""
-    filename = f"feedback_{grade_level}{subject_tag}_{topic}_{timestamp}.txt"
+    safe_grade = sanitize_filename(grade_level)
+    safe_topic = sanitize_filename(topic)
+    safe_subject = sanitize_filename(subject) if subject else ""
+    subject_tag = f"_{safe_subject}" if safe_subject else ""
+    filename = f"feedback_{safe_grade}{subject_tag}_{safe_topic}_{timestamp}.txt"
     
     content = f"""AI CORRECTION & FEEDBACK
 {'='*50}
@@ -526,7 +545,7 @@ Review this feedback carefully to understand where you went wrong.
 Practice similar questions to strengthen this topic.
 """
     
-    filepath = f"downloads/{filename}"
+    filepath = os.path.join("downloads", filename)
     os.makedirs("downloads", exist_ok=True)
     with open(filepath, "w", encoding="utf-8") as f:
         f.write(content)
@@ -642,7 +661,7 @@ with gr.Blocks(title="UNEB Exam Prep - Primary 6 & 7", theme=gr.themes.Soft(), c
                 num_questions_input = gr.Slider(minimum=1, maximum=100, step=1, value=20, label="Number of Questions")
                 generate_btn = gr.Button(" Generate Questions", variant="primary", size="lg")
             
-            questions_output = gr.Markdown(
+            questions_output = gr.HTML(
                 value="",
                 elem_classes="question-display"
             )
@@ -660,24 +679,25 @@ with gr.Blocks(title="UNEB Exam Prep - Primary 6 & 7", theme=gr.themes.Soft(), c
             # Generate questions handler
             def generate_and_display(grade, subject, topic, num_questions):
                 questions_list, formatted_text = generate_practice_questions(grade, subject, topic, num_questions=num_questions)
-                
+
                 if questions_list is None:
-                    return "", formatted_text, questions_state.value, " Generation failed"
-                
+                    return "", questions_state.value, " Generation failed"
+
                 session.current_questions = questions_list
                 session.current_grade = grade
                 session.current_topic = topic
                 # Also store subject
                 session.current_subject = subject
-                
-                # For Markdown display, keep spacing and simple formatting
-                md_text = "\n\n".join([f"**{i+1}.** {q.split('.',1)[1].strip() if '.' in q else q}" for i, q in enumerate(questions_list)])
-                return md_text, md_text, questions_list, f" Generated {len(questions_list)} {subject} questions on {topic}"
+
+                # Build accessible HTML list for better rendering on iPad/Safari
+                items_html = "".join([f"<li>{q.split('.',1)[1].strip() if '.' in q else q}</li>" for q in questions_list])
+                html = f"<div><ol style='margin:0 0 0 1.2rem;padding:0'>{items_html}</ol></div>"
+                return html, questions_list, f" Generated {len(questions_list)} {subject} questions on {topic}"
             
             generate_btn.click(
                 fn=generate_and_display,
                 inputs=[grade_input, subject_input, topic_input, num_questions_input],
-                outputs=[questions_output, questions_output, questions_state, status_output]
+                outputs=[questions_output, questions_state, status_output]
             )            
             # Download handler - returns file path for gr.DownloadButton
             def download_qns():