Update app.py

app.py

@@ -12,6 +12,7 @@ from io import BytesIO
 from PIL import Image
 import csv
 from pathlib import Path
+import re
 
 # ---------- 1. Configure AI Systems ----------
 # Primary: Gemini (with vision support)
@@ -156,27 +157,32 @@ Each question should be:
 Start immediately with Q1. Do not include any introduction or explanation."""
     
     response, source = ask_ai(prompt, temperature=0.6)
-    
-    # Parse questions using text splitting
+
+    # Parse questions robustly using regex to support multi-digit numbers (Q1..Q10..)
     questions = []
-    lines = response.split('\n')
-    
     current_question = None
-    for line in lines:
-        line = line.strip()
+    q_re = re.compile(r'^Q(\d+)\.?\s*(.*)', re.IGNORECASE)
+
+    for raw_line in response.splitlines():
+        line = raw_line.strip()
         if not line:
             continue
-        
-        # Check if line starts with Q1., Q2., etc.
-        if line[0] == 'Q' and len(line) > 2 and line[1].isdigit() and line[2] == '.':
+
+        m = q_re.match(line)
+        if m:
+            # Start of a new question
             if current_question:
-                questions.append(current_question)
-            current_question = line
-        elif current_question and line:
-            current_question += " " + line
-    
+                questions.append(current_question.strip())
+            # Include the rest of the line after the Qn. prefix
+            rest = m.group(2) or ''
+            current_question = f"Q{m.group(1)}. {rest.strip()}"
+        else:
+            # Continuation of previous question (append with space)
+            if current_question:
+                current_question += ' ' + line
+
     if current_question:
-        questions.append(current_question)
+        questions.append(current_question.strip())
     
     # Ensure we got questions
     if not questions:
@@ -284,6 +290,46 @@ Good luck! 🍀
     
     return filepath
 
+
+def download_questions_pdf(questions_list, topic, grade_level):
+    """Generate a simple PDF with the questions, return filepath."""
+    try:
+        from reportlab.lib.pagesizes import A4
+        from reportlab.lib.styles import getSampleStyleSheet, ParagraphStyle
+        from reportlab.platypus import SimpleDocTemplate, Paragraph, Spacer
+        from reportlab.lib.units import mm
+    except Exception:
+        return None
+
+    timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
+    filename = f"questions_{grade_level}_{topic}_{timestamp}.pdf"
+    filepath = f"downloads/{filename}"
+    os.makedirs("downloads", exist_ok=True)
+
+    doc = SimpleDocTemplate(filepath, pagesize=A4, rightMargin=20*mm, leftMargin=20*mm, topMargin=20*mm, bottomMargin=20*mm)
+    styles = getSampleStyleSheet()
+    normal = styles['Normal']
+    heading = ParagraphStyle('Heading', parent=styles['Heading1'], alignment=0)
+    elems = []
+
+    elems.append(Paragraph("UNEB EXAM PRACTICE QUESTIONS", styles['Title']))
+    elems.append(Spacer(1, 4*mm))
+    meta = f"Grade Level: {grade_level}     Topic: {topic}     Generated: {datetime.now().strftime('%Y-%m-%d %H:%M:%S')}"
+    elems.append(Paragraph(meta, normal))
+    elems.append(Spacer(1, 6*mm))
+
+    for i, q in enumerate(questions_list):
+        # Remove any leading Qn. if present
+        q_text = re.sub(r'^Q\d+\.?\s*', '', q)
+        elems.append(Paragraph(f"<b>Q{i+1}.</b> {q_text}", normal))
+        elems.append(Spacer(1, 3*mm))
+
+    try:
+        doc.build(elems)
+        return filepath
+    except Exception:
+        return None
+
 def download_feedback_file(feedback_text, topic, grade_level):
     """Download AI feedback/corrections"""
     if not feedback_text:
@@ -445,9 +491,13 @@ with gr.Blocks(title="UNEB Exam Prep - Primary 6 & 7", theme=gr.themes.Soft(), c
                 if not session.current_questions:
                     return None, "⚠️ Generate questions first!"
                 try:
+                    # Prefer PDF export; fall back to plain text if PDF library missing
+                    pdf_path = download_questions_pdf(session.current_questions, session.current_topic, session.current_grade)
+                    if pdf_path:
+                        return pdf_path, f"✅ Downloaded PDF: {os.path.abspath(pdf_path)}"
+                    # Fallback to text
                     filepath = download_questions_file(session.current_questions, session.current_topic, session.current_grade)
-                    # Return the file path for gr.File and a friendly status
-                    return filepath, f"✅ Downloaded! File: {os.path.abspath(filepath)}"
+                    return filepath, f"✅ Downloaded TXT: {os.path.abspath(filepath)}"
                 except Exception as e:
                     return None, f"❌ Error: {str(e)}"