Update app.py

app.py

@@ -350,34 +350,108 @@ Include all questions, preserve exact numbering, identify topics clearly."""
 # ============================================================================
 
 def generate_lesson_notes(subject, topic, detail_level="comprehensive"):
-    """Generate comprehensive teaching notes"""
+    """Generate comprehensive teaching notes - content focused"""
     
-    prompt = f"""Generate {detail_level} teaching notes for IGCSE {subject} - Topic: {topic}
+    prompt = f"""Generate {detail_level} IGCSE {subject} teaching notes for: {topic}
 
-Structure:
-1. LEARNING OBJECTIVES (3-5 clear objectives)
-2. KEY CONCEPTS (with explanations)
-3. DETAILED CONTENT
-   - Introduction
-   - Main points with explanations
-   - Examples
-   - Common misconceptions
-4. TEACHING TIPS
-5. STUDENT ACTIVITIES (3-5 activities)
-6. ASSESSMENT IDEAS
-7. HOMEWORK SUGGESTIONS
-8. RESOURCES NEEDED
-9. DIFFERENTIATION STRATEGIES
+Provide complete, ready-to-teach content:
 
-Make it practical, clear, and ready to use in class."""
+1. KEY CONCEPTS & DEFINITIONS
+   - All essential terms with clear explanations
+   - Core principles and laws
 
-    response, source = ask_ai(prompt, temperature=0.6)
+2. DETAILED CONTENT
+   - Comprehensive explanation of all subtopics
+   - Step-by-step breakdowns where applicable
+   - Important formulas, equations, or processes
+   - Worked examples with solutions
+
+3. IMPORTANT POINTS TO EMPHASIZE
+   - Critical information students must know
+   - Common misconceptions to address
+   - Exam-relevant points
+
+4. PRACTICE PROBLEMS/QUESTIONS
+   - 5-8 questions with full solutions
+   - Range of difficulty levels
+
+5. QUICK REFERENCE SUMMARY
+   - Bullet points of key takeaways
+   - Memory aids or mnemonics
+
+Focus on CONTENT and KNOWLEDGE - provide the actual information to teach, not meta-instructions about teaching."""
+
+    response, source = ask_ai(prompt, temperature=0.5)
     
     if source != "gemini":
         response = f"[Generated using {source.title()}]\n\n{response}"
     
     return response
 
+def generate_notes_pdf(notes_content, subject, topic):
+    """Generate PDF from lesson notes"""
+    buffer = BytesIO()
+    doc = SimpleDocTemplate(buffer, pagesize=A4, topMargin=72, bottomMargin=72)
+    story = []
+    styles = getSampleStyleSheet()
+    
+    # Custom styles
+    title_style = ParagraphStyle(
+        'CustomTitle',
+        parent=styles['Heading1'],
+        fontSize=18,
+        textColor=colors.HexColor('#1a237e'),
+        spaceAfter=20,
+        alignment=TA_CENTER,
+        fontName='Helvetica-Bold'
+    )
+    
+    heading_style = ParagraphStyle(
+        'CustomHeading',
+        parent=styles['Heading2'],
+        fontSize=14,
+        textColor=colors.HexColor('#283593'),
+        spaceAfter=12,
+        spaceBefore=12,
+        fontName='Helvetica-Bold'
+    )
+    
+    # Title
+    story.append(Paragraph(f"IGCSE {subject}", title_style))
+    story.append(Paragraph(f"Topic: {topic}", styles['Heading2']))
+    story.append(Spacer(1, 20))
+    
+    # Content - parse markdown-style formatting
+    lines = notes_content.split('\n')
+    for line in lines:
+        line = line.strip()
+        if not line:
+            story.append(Spacer(1, 6))
+            continue
+        
+        # Handle headings
+        if line.startswith('###'):
+            story.append(Paragraph(line.replace('###', '').strip(), heading_style))
+        elif line.startswith('##'):
+            story.append(Paragraph(line.replace('##', '').strip(), title_style))
+        elif line.startswith('#'):
+            story.append(Paragraph(line.replace('#', '').strip(), title_style))
+        # Handle bold
+        elif line.startswith('**') or '**' in line:
+            line = line.replace('**', '<b>').replace('**', '</b>')
+            story.append(Paragraph(line, styles['Normal']))
+        # Handle lists
+        elif line.startswith('-') or line.startswith('•'):
+            line = line.lstrip('-•').strip()
+            story.append(Paragraph(f"  • {line}", styles['Normal']))
+        # Regular text
+        else:
+            story.append(Paragraph(line, styles['Normal']))
+    
+    doc.build(story)
+    buffer.seek(0)
+    return buffer
+
 # ============================================================================
 # ASSESSMENT GENERATOR
 # ============================================================================
@@ -419,11 +493,11 @@ Mix question types (knowledge, application, analysis). Include mark schemes."""
         return []
 
 # ============================================================================
-# EXAM PAPER GENERATOR
+# EXAM PAPER GENERATOR - SEPARATE QUESTION AND MARK SCHEME PDFs
 # ============================================================================
 
-def generate_exam_paper(selected_questions, exam_title, include_answers=True):
-    """Generate professional exam paper PDF"""
+def generate_question_paper_pdf(selected_questions, exam_title):
+    """Generate question paper PDF (no answers)"""
     
     buffer = BytesIO()
     doc = SimpleDocTemplate(buffer, pagesize=A4, topMargin=72, bottomMargin=36)
@@ -451,13 +525,15 @@ def generate_exam_paper(selected_questions, exam_title, include_answers=True):
     
     # Title
     story.append(Paragraph(exam_title, title_style))
+    story.append(Paragraph("QUESTION PAPER", styles['Heading2']))
     story.append(Spacer(1, 12))
     
     # Instructions
     instructions = Paragraph(
-        "<b>Instructions:</b><br/>"
+        "<b>Instructions to Candidates:</b><br/>"
         "• Answer all questions<br/>"
-        "• Show all working<br/>"
+        "• Show all working clearly<br/>"
+        "• Write your answers in the spaces provided<br/>"
         f"• Total marks: {sum(q.get('marks', 0) for q in selected_questions)}<br/>"
         f"• Time allowed: {len(selected_questions) * 2} minutes",
         styles['Normal']
@@ -469,18 +545,54 @@ def generate_exam_paper(selected_questions, exam_title, include_answers=True):
     for i, q in enumerate(selected_questions, 1):
         q_text = f"<b>{i}. {q.get('question_text', '')}</b> [{q.get('marks', 0)} marks]"
         story.append(Paragraph(q_text, question_style))
-        story.append(Spacer(1, 36))  # Space for answer
+        story.append(Spacer(1, 48))  # Space for answer
+    
+    doc.build(story)
+    buffer.seek(0)
+    return buffer
+
+def generate_marking_scheme_pdf(selected_questions, exam_title):
+    """Generate marking scheme PDF (separate)"""
+    
+    buffer = BytesIO()
+    doc = SimpleDocTemplate(buffer, pagesize=A4, topMargin=72, bottomMargin=36)
+    story = []
+    styles = getSampleStyleSheet()
     
-    # Answer section if requested
-    if include_answers:
-        story.append(PageBreak())
-        story.append(Paragraph("MARK SCHEME", title_style))
-        story.append(Spacer(1, 24))
+    # Custom styles
+    title_style = ParagraphStyle(
+        'CustomTitle',
+        parent=styles['Heading1'],
+        fontSize=16,
+        textColor=colors.HexColor('#1a237e'),
+        spaceAfter=30,
+        alignment=TA_CENTER,
+        fontName='Helvetica-Bold'
+    )
+    
+    # Title
+    story.append(Paragraph(exam_title, title_style))
+    story.append(Paragraph("MARKING SCHEME", styles['Heading2']))
+    story.append(Spacer(1, 24))
+    
+    # Mark scheme
+    for i, q in enumerate(selected_questions, 1):
+        # Question number and marks
+        q_header = f"<b>Question {i}</b> [{q.get('marks', 0)} marks]"
+        story.append(Paragraph(q_header, styles['Heading3']))
+        story.append(Spacer(1, 6))
         
-        for i, q in enumerate(selected_questions, 1):
-            answer_text = f"<b>{i}. </b>{q.get('model_answer', q.get('mark_scheme', 'Answer not available'))}"
-            story.append(Paragraph(answer_text, styles['Normal']))
-            story.append(Spacer(1, 12))
+        # Mark scheme
+        mark_scheme = q.get('mark_scheme', 'Mark scheme not available')
+        story.append(Paragraph(f"<b>Mark Scheme:</b>", styles['Normal']))
+        story.append(Paragraph(mark_scheme, styles['Normal']))
+        story.append(Spacer(1, 8))
+        
+        # Model answer
+        model_answer = q.get('model_answer', 'Model answer not available')
+        story.append(Paragraph(f"<b>Model Answer:</b>", styles['Normal']))
+        story.append(Paragraph(model_answer, styles['Normal']))
+        story.append(Spacer(1, 20))
     
     doc.build(story)
     buffer.seek(0)
@@ -682,38 +794,117 @@ with gr.Blocks(
         # ============================================================
         with gr.Tab("Lesson Notes"):
             gr.Markdown("### Generate Comprehensive Teaching Notes")
+            gr.Markdown("*AI provides complete content and knowledge - ready to teach*")
             
             with gr.Row():
-                notes_subject = gr.Dropdown(
-                    choices=list(IGCSE_SUBJECTS.keys()),
-                    label="Subject",
-                    value="Mathematics (0580)"
-                )
-                notes_topic = gr.Dropdown(
-                    choices=IGCSE_SUBJECTS["Mathematics (0580)"]["topics"],
-                    label="Topic"
-                )
-            
-            def update_topics(subject):
-                topics = IGCSE_SUBJECTS[subject]["topics"]
-                return gr.Dropdown(choices=topics, value=topics[0] if topics else None)
+                with gr.Column(scale=2):
+                    with gr.Row():
+                        notes_subject = gr.Dropdown(
+                            choices=list(IGCSE_SUBJECTS.keys()),
+                            label="Subject",
+                            value="Mathematics (0580)"
+                        )
+                        notes_topic = gr.Dropdown(
+                            choices=IGCSE_SUBJECTS["Mathematics (0580)"]["topics"],
+                            label="Topic"
+                        )
+                    
+                    def update_topics(subject):
+                        topics = IGCSE_SUBJECTS[subject]["topics"]
+                        return gr.Dropdown(choices=topics, value=topics[0] if topics else None)
+                    
+                    notes_subject.change(update_topics, notes_subject, notes_topic)
+                    
+                    notes_detail = gr.Radio(
+                        choices=["concise", "comprehensive", "detailed"],
+                        label="Detail Level",
+                        value="comprehensive"
+                    )
+                    
+                    with gr.Row():
+                        generate_notes_btn = gr.Button("Generate Lesson Notes", variant="primary")
+                        download_notes_btn = gr.Button("Download as PDF", variant="secondary")
+                    
+                    notes_pdf_output = gr.File(label="Download Notes PDF")
+                
+                with gr.Column(scale=3):
+                    notes_output = gr.Markdown(value="Select topic and click generate")
             
-            notes_subject.change(update_topics, notes_subject, notes_topic)
+            # Store generated notes
+            generated_notes = gr.State("")
             
-            notes_detail = gr.Radio(
-                choices=["concise", "comprehensive", "detailed"],
-                label="Detail Level",
-                value="comprehensive"
-            )
+            def generate_and_store(subject, topic, detail):
+                notes = generate_lesson_notes(subject, topic, detail)
+                return notes, notes
             
-            generate_notes_btn = gr.Button("Generate Lesson Notes", variant="primary")
-            notes_output = gr.Markdown(value="Select topic and click generate")
+            def create_notes_pdf(notes, subject, topic):
+                if not notes:
+                    return None
+                pdf_buffer = generate_notes_pdf(notes, subject, topic)
+                
+                # Save to temporary file
+                import tempfile
+                temp_file = tempfile.NamedTemporaryFile(delete=False, suffix='.pdf')
+                temp_file.write(pdf_buffer.read())
+                temp_file.close()
+                return temp_file.name
             
             generate_notes_btn.click(
-                generate_lesson_notes,
+                generate_and_store,
                 [notes_subject, notes_topic, notes_detail],
-                notes_output
+                [notes_output, generated_notes]
+            )
+            
+            download_notes_btn.click(
+                create_notes_pdf,
+                [generated_notes, notes_subject, notes_topic],
+                notes_pdf_output
+            )
+            
+            gr.Markdown("---")
+            gr.Markdown("### Ask for Clarification")
+            gr.Markdown("*Have questions about the content? Ask the AI for clarification*")
+            
+            clarification_chat = gr.Chatbot(height=300, label="Clarification Chat")
+            clarification_input = gr.Textbox(
+                placeholder="Ask for clarification on any part of the notes...",
+                label="Your Question"
+            )
+            
+            with gr.Row():
+                clarify_btn = gr.Button("Ask", variant="primary")
+                clear_chat_btn = gr.Button("Clear Chat")
+            
+            def handle_clarification(question, history, subject, topic, notes):
+                if not question.strip():
+                    return history
+                
+                context = f"""You are helping a teacher understand IGCSE {subject} content on {topic}.
+
+Current notes context:
+{notes[:1000]}...
+
+Teacher's question: {question}
+
+Provide a clear, direct answer focused on the content and concepts. Be specific and helpful."""
+                
+                response, _ = ask_ai(context, temperature=0.6)
+                history.append((question, response))
+                return history
+            
+            clarify_btn.click(
+                handle_clarification,
+                [clarification_input, clarification_chat, notes_subject, notes_topic, generated_notes],
+                clarification_chat
             )
+            
+            clarification_input.submit(
+                handle_clarification,
+                [clarification_input, clarification_chat, notes_subject, notes_topic, generated_notes],
+                clarification_chat
+            )
+            
+            clear_chat_btn.click(lambda: [], outputs=clarification_chat)
         
         # ============================================================
         # TAB 4: ASSESSMENT GENERATOR