chore: fix lint and introduce pre-commit hooks

Makefile

@@ -9,6 +9,7 @@ LOGS_DIR := logs
 SRC_DIR := src.v2
 TIMESTAMP := $(shell date +%Y%m%d_%H%M%S)
 PORT := 5000
+HOOKS_DIR := scripts/git-hooks
 
 # Default target
 .PHONY: help
@@ -17,6 +18,7 @@ help:
 	@echo "  help        - Show this help message"
 	@echo "  env         - Set up and activate a virtual environment"
 	@echo "  install     - Install dependencies and set script permissions"
+	@echo "  hooks       - Install git hooks for pre-commit checks"
 	@echo "  train       - Train the model (use --sample for training with sample data)"
 	@echo "  predict     - Run predictions using console app (usage: make predict [NVDA])"
 	@echo "  mlflow      - Start the MLflow UI to view training results (optional: make mlflow PORT=5001)"
@@ -71,6 +73,14 @@ install:
 	chmod +x $(SCRIPTS_DIR)/*.py && \
 	echo "Installation complete at: $$(date)") | tee $(LOGS_DIR)/install_$(TIMESTAMP).log
 	@echo "Installation log saved to: $(LOGS_DIR)/install_$(TIMESTAMP).log"
+	@echo "To install git hooks, run 'make hooks'"
+
+# Install git hooks
+.PHONY: hooks
+hooks:
+	@echo "Installing git hooks..."
+	@chmod +x $(SCRIPTS_DIR)/install-git-hooks.sh
+	@$(SCRIPTS_DIR)/install-git-hooks.sh
 
 # Train the model
 .PHONY: train

docs/ai-rules.md

@@ -7,6 +7,7 @@ alwaysApply: true
 - Prior to generating any code, carefully read the project conventions
   - Read [project-design.md](docs/project-design.md) to understand the codebase
   - Read [project-conventions.md](docs/project-conventions.md) to understand _how_ to write code for the codebase
+- Run `make lint` and `make test` after every change. `lint` in particular can be run very frequently.
 
 ## Prohibited actions
 

scripts/git-hooks/pre-commit

@@ -0,0 +1,28 @@
+#!/bin/bash
+
+# Pre-commit hook to run linting and tests before allowing a commit
+
+echo "Running pre-commit checks..."
+
+# Run linting
+echo "Running linter..."
+make lint
+LINT_RESULT=$?
+
+if [ $LINT_RESULT -ne 0 ]; then
+    echo "Linting failed. Please fix the issues before committing."
+    exit 1
+fi
+
+# Run tests
+echo "Running tests..."
+make test
+TEST_RESULT=$?
+
+if [ $TEST_RESULT -ne 0 ]; then
+    echo "Tests failed. Please fix the issues before committing."
+    exit 1
+fi
+
+echo "All pre-commit checks passed!"
+exit 0

scripts/install-git-hooks.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+
+# Script to install git hooks
+
+HOOK_DIR=$(git rev-parse --git-dir)/hooks
+PROJECT_HOOK_DIR=scripts/git-hooks
+
+echo "Installing git hooks..."
+
+# Make sure the hooks directory exists
+mkdir -p $HOOK_DIR
+
+# Copy each hook from the project hooks directory to the git hooks directory
+for hook in $PROJECT_HOOK_DIR/*; do
+    if [ -f "$hook" ]; then
+        hook_name=$(basename $hook)
+        echo "Installing $hook_name hook..."
+        cp "$hook" "$HOOK_DIR/$hook_name"
+        chmod +x "$HOOK_DIR/$hook_name"
+    fi
+done
+
+echo "Git hooks installed successfully!"

src/stockdata.py

@@ -136,7 +136,7 @@ class DataFetcherSingleton:
 
 
 # Convenience function to maintain backward compatibility
-def get_data_fetcher(cache_dir=None, **kwargs):
+def get_data_fetcher(cache_dir=None):
     """
     Get the singleton instance of the data fetcher.
 
@@ -145,7 +145,6 @@ def get_data_fetcher(cache_dir=None, **kwargs):
 
     Args:
         cache_dir (str, optional): Cache directory. If None, uses default.
-        **kwargs: Additional arguments that are ignored (for backward compatibility)
 
     Returns:
         DataFetcherInterface: The singleton data fetcher instance.