Shared conversation redirect (#1968)

* redirect to the convo

* backend redirect to the convo

* fix: fetch url logs

* server side redirect

* require a query only for the get

* fix error type

* fix: fetch url logs

---------

Co-authored-by: rtrm <remy.trompier@gmail.com>

src/lib/components/BackgroundGenerationPoller.svelte

@@ -64,7 +64,7 @@
 			log("poll", id);
 
 			try {
-				const response = await client.conversations({ id }).get();
+				const response = await client.conversations({ id }).get({ query: {} });
 				const conversation = handleResponse(response);
 				const messages = conversation?.messages ?? [];
 				const lastAssistant = [...messages]

src/lib/server/api/routes/groups/conversations.ts

@@ -72,18 +72,17 @@ export const conversationGroup = new Elysia().use(authPlugin).group("/conversati
 				},
 				(app) => {
 					return app
-						.derive(async ({ locals, params }) => {
+						.derive(async ({ locals, params, query }) => {
 							let conversation;
 							let shared = false;
 
-							// if the conver
+							// if the conversation is shared
 							if (params.id.length === 7) {
 								// shared link of length 7
 								conversation = await collections.sharedConversations.findOne({
 									_id: params.id,
 								});
 								shared = true;
-
 								if (!conversation) {
 									throw new Error("Conversation not found");
 								}
@@ -113,6 +112,9 @@ export const conversationGroup = new Elysia().use(authPlugin).group("/conversati
 
 									throw new Error("Conversation not found.");
 								}
+								if (query.fromShare && conversation.meta?.fromShareId === query.fromShare) {
+									shared = true;
+								}
 							}
 
 							const convertedConv = {
@@ -123,19 +125,29 @@ export const conversationGroup = new Elysia().use(authPlugin).group("/conversati
 
 							return { conversation: convertedConv };
 						})
-						.get("", async ({ conversation }) => {
-							return {
-								messages: conversation.messages,
-								title: conversation.title,
-								model: conversation.model,
-								preprompt: conversation.preprompt,
-								rootMessageId: conversation.rootMessageId,
-								id: conversation._id.toString(),
-								updatedAt: conversation.updatedAt,
-								modelId: conversation.model,
-								shared: conversation.shared,
-							};
-						})
+						.get(
+							"",
+							async ({ conversation }) => {
+								return {
+									messages: conversation.messages,
+									title: conversation.title,
+									model: conversation.model,
+									preprompt: conversation.preprompt,
+									rootMessageId: conversation.rootMessageId,
+									id: conversation._id.toString(),
+									updatedAt: conversation.updatedAt,
+									modelId: conversation.model,
+									shared: conversation.shared,
+								};
+							},
+							{
+								query: t.Optional(
+									t.Object({
+										fromShare: t.Optional(t.String()),
+									})
+								),
+							}
+						)
 						.post("", () => {
 							// todo: post new message
 							throw new Error("Not implemented");

src/lib/server/conversation.ts

@@ -0,0 +1,54 @@
+import { collections } from "$lib/server/database";
+import { MetricsServer } from "$lib/server/metrics";
+import { error } from "@sveltejs/kit";
+import { ObjectId } from "mongodb";
+import { authCondition } from "$lib/server/auth";
+
+/**
+ * Create a new conversation from a shared conversation ID.
+ * If the conversation already exists for the user/session, return the existing conversation ID.
+ * returns the conversation ID.
+ */
+export async function createConversationFromShare(
+	fromShareId: string,
+	locals: App.Locals,
+	userAgent?: string
+): Promise<string> {
+	const conversation = await collections.sharedConversations.findOne({
+		_id: fromShareId,
+	});
+
+	if (!conversation) {
+		error(404, "Conversation not found");
+	}
+
+	// Check if shared conversation exists already for this user/session
+	const existingConversation = await collections.conversations.findOne({
+		"meta.fromShareId": fromShareId,
+		...authCondition(locals),
+	});
+
+	if (existingConversation) {
+		return existingConversation._id.toString();
+	}
+
+	// Create new conversation from shared conversation
+	const res = await collections.conversations.insertOne({
+		_id: new ObjectId(),
+		title: conversation.title.replace(/<\/?think>/gi, "").trim(),
+		rootMessageId: conversation.rootMessageId,
+		messages: conversation.messages,
+		model: conversation.model,
+		preprompt: conversation.preprompt,
+		createdAt: new Date(),
+		updatedAt: new Date(),
+		userAgent,
+		...(locals.user ? { userId: locals.user._id } : { sessionId: locals.sessionId }),
+		meta: { fromShareId },
+	});
+
+	if (MetricsServer.isEnabled()) {
+		MetricsServer.getMetrics().model.conversationsTotal.inc({ model: conversation.model });
+	}
+	return res.insertedId.toString();
+}

src/routes/conversation/[id]/+page.server.ts

@@ -0,0 +1,21 @@
+import { redirect } from "@sveltejs/kit";
+import type { PageServerLoad } from "./$types";
+import { loginEnabled } from "$lib/server/auth";
+import { createConversationFromShare } from "$lib/server/conversation";
+
+export const load: PageServerLoad = async ({ url, params, locals, request }) => {
+	/// if logged in and valid share ID, create conversation from share, usually occurs after login
+	if (loginEnabled && locals.user && params.id.length === 7) {
+		const leafId = url.searchParams.get("leafId");
+		const conversationId = await createConversationFromShare(
+			params.id,
+			locals,
+			request.headers.get("User-Agent") ?? undefined
+		);
+
+		return redirect(
+			302,
+			`../conversation/${conversationId}?leafId=${leafId}&fromShare=${params.id}`
+		);
+	}
+};

src/routes/conversation/[id]/+page.svelte

@@ -4,7 +4,7 @@
 	import { isAborted } from "$lib/stores/isAborted";
 	import { onMount } from "svelte";
 	import { page } from "$app/state";
-	import { beforeNavigate, goto, invalidateAll } from "$app/navigation";
+	import { beforeNavigate, invalidateAll } from "$app/navigation";
 	import { base } from "$app/paths";
 	import { ERROR_MESSAGES, error } from "$lib/stores/errors";
 	import { findCurrentModel } from "$lib/utils/models";
@@ -95,35 +95,6 @@
 		return alternatives;
 	}
 
-	async function convFromShared() {
-		try {
-			$loading = true;
-			const res = await fetch(`${base}/conversation`, {
-				method: "POST",
-				headers: {
-					"Content-Type": "application/json",
-				},
-				body: JSON.stringify({
-					fromShare: page.params.id,
-					model: data.model,
-				}),
-			});
-
-			if (!res.ok) {
-				error.set(await res.text());
-				console.error("Error while creating conversation: " + (await res.text()));
-				return;
-			}
-
-			const { conversationId } = await res.json();
-
-			return conversationId;
-		} catch (err) {
-			error.set(ERROR_MESSAGES.default);
-			console.error(String(err));
-			throw err;
-		}
-	}
 	// this function is used to send new message to the backends
 	async function writeMessage({
 		prompt,
@@ -381,16 +352,7 @@
 	});
 
 	async function onMessage(content: string) {
-		if (!data.shared) {
-			await writeMessage({ prompt: content });
-		} else {
-			await convFromShared()
-				.then(async (convId) => {
-					await goto(`${base}/conversation/${convId}`, { invalidateAll: true });
-				})
-				.then(async () => await writeMessage({ prompt: content }))
-				.finally(() => ($loading = false));
-		}
+		await writeMessage({ prompt: content });
 	}
 
 	async function onRetry(payload: { id: Message["id"]; content?: string }) {
@@ -399,27 +361,11 @@
 		const lastMsgId = payload.id;
 		messagesPath = createMessagesPath(messages, lastMsgId);
 
-		if (!data.shared) {
-			await writeMessage({
-				prompt: payload.content,
-				messageId: payload.id,
-				isRetry: true,
-			});
-		} else {
-			await convFromShared()
-				.then(async (convId) => {
-					await goto(`${base}/conversation/${convId}`, { invalidateAll: true });
-				})
-				.then(
-					async () =>
-						await writeMessage({
-							prompt: payload.content,
-							messageId: payload.id,
-							isRetry: true,
-						})
-				)
-				.finally(() => ($loading = false));
-		}
+		await writeMessage({
+			prompt: payload.content,
+			messageId: payload.id,
+			isRetry: true,
+		});
 	}
 
 	async function onShowAlternateMsg(payload: { id: Message["id"] }) {

src/routes/conversation/[id]/+page.ts

@@ -8,7 +8,10 @@ export const load = async ({ params, depends, fetch, url }) => {
 	const client = useAPIClient({ fetch, origin: url.origin });
 
 	try {
-		return await client.conversations({ id: params.id }).get().then(handleResponse);
+		return await client
+			.conversations({ id: params.id })
+			.get({ query: { fromShare: url.searchParams.get("fromShare") ?? undefined } })
+			.then(handleResponse);
 	} catch {
 		redirect(302, "/");
 	}

src/routes/r/[id]/+page.server.ts

@@ -0,0 +1,23 @@
+import { redirect } from "@sveltejs/kit";
+import type { PageServerLoad } from "./$types";
+import { loginEnabled } from "$lib/server/auth";
+import { createConversationFromShare } from "$lib/server/conversation";
+
+export const load: PageServerLoad = async ({ url, params, locals, request }) => {
+	const leafId = url.searchParams.get("leafId");
+
+	/// if logged in and valid share ID, create conversation from share
+	if (loginEnabled && locals.user && params.id) {
+		const conversationId = await createConversationFromShare(
+			params.id,
+			locals,
+			request.headers.get("User-Agent") ?? undefined
+		);
+
+		return redirect(
+			302,
+			`../conversation/${conversationId}?leafId=${leafId}&fromShare=${params.id}`
+		);
+	}
+	return redirect(302, `../conversation/${params.id}?leafId=${leafId}`);
+};

src/routes/r/[id]/+page.ts

@@ -1,7 +0,0 @@
-import { redirect, type LoadEvent } from "@sveltejs/kit";
-
-export const load = async ({ params, url }: LoadEvent) => {
-	const leafId = url.searchParams.get("leafId");
-
-	redirect(302, "../conversation/" + params.id + `?leafId=${leafId}`);
-};