fix: improve logs (#2018)

src/lib/jobs/refresh-conversation-stats.ts

@@ -19,12 +19,14 @@ async function shouldComputeStats(): Promise<boolean> {
 export async function computeAllStats() {
 	for (const span of ["day", "week", "month"] as const) {
 		computeStats({ dateField: "updatedAt", type: "conversation", span }).catch((e) =>
-			logger.error(e)
+			logger.error(e, "Error computing conversation stats for updatedAt")
 		);
 		computeStats({ dateField: "createdAt", type: "conversation", span }).catch((e) =>
-			logger.error(e)
+			logger.error(e, "Error computing conversation stats for createdAt")
+		);
+		computeStats({ dateField: "createdAt", type: "message", span }).catch((e) =>
+			logger.error(e, "Error computing message stats for createdAt")
 		);
-		computeStats({ dateField: "createdAt", type: "message", span }).catch((e) => logger.error(e));
 	}
 }
 

src/lib/migrations/migrations.ts

@@ -92,8 +92,7 @@ export async function checkAndRunMigrations() {
 					result = await migration.up(await Database.getInstance());
 				});
 			} catch (e) {
-				logger.debug(`[MIGRATIONS]  "${migration.name}" failed!`);
-				logger.error(e);
+				logger.error(e, `[MIGRATIONS]  "${migration.name}" failed!`);
 			} finally {
 				await session.endSession();
 			}

src/lib/server/abortedGenerations.ts

@@ -36,7 +36,7 @@ export class AbortedGenerations {
 				aborts.map((abort) => [abort.conversationId.toString(), abort.createdAt])
 			);
 		} catch (err) {
-			logger.error(err);
+			logger.error(err, "Error updating aborted generations list");
 		}
 	}
 }

src/lib/server/api/routes/groups/user.ts

@@ -197,7 +197,7 @@ export const userGroup = new Elysia()
 						currentBillingOrg: isCurrentOrgValid ? currentBillingOrg : undefined,
 					};
 				} catch (err) {
-					logger.error("Error fetching billing orgs:", err);
+					logger.error(err, "Error fetching billing orgs:");
 					set.status = 500;
 					return { error: "Internal server error" };
 				}

src/lib/server/auth.ts

@@ -153,7 +153,7 @@ export async function findUser(
 
 					session.oauth = updatedOAuth;
 				} catch (err) {
-					logger.error("Error during token refresh:", err);
+					logger.error(err, "Error during token refresh:");
 					return { user: null, invalidateSession: true };
 				} finally {
 					await releaseLock(lockKey, lockId);
@@ -374,7 +374,7 @@ export async function validateAndParseCsrfToken(
 			return { redirectUrl: data.redirectUrl, next: sanitizeReturnPath(data.next) };
 		}
 	} catch (e) {
-		logger.error(e);
+		logger.error(e, "Error validating and parsing CSRF token");
 	}
 	return null;
 }

src/lib/server/database.ts

@@ -72,7 +72,7 @@ export class Database {
 			this.client.db(config.MONGODB_DB_NAME + (import.meta.env.MODE === "test" ? "-test" : ""));
 			await this.initDatabase();
 		} catch (err) {
-			logger.error(err, "Connection error");
+			logger.error(err, "Error connecting to database");
 			process.exit(1);
 		}
 
@@ -182,24 +182,32 @@ export class Database {
 				{ sessionId: 1, updatedAt: -1 },
 				{ partialFilterExpression: { sessionId: { $exists: true } } }
 			)
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(e, "Error creating index for conversations by sessionId and updatedAt")
+			);
 		conversations
 			.createIndex(
 				{ userId: 1, updatedAt: -1 },
 				{ partialFilterExpression: { userId: { $exists: true } } }
 			)
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(e, "Error creating index for conversations by userId and updatedAt")
+			);
 		conversations
 			.createIndex(
 				{ "message.id": 1, "message.ancestors": 1 },
 				{ partialFilterExpression: { userId: { $exists: true } } }
 			)
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(e, "Error creating index for conversations by messageId and ancestors")
+			);
 		// Not strictly necessary, could use _id, but more convenient. Also for stats
 		// To do stats on conversation messages
 		conversations
 			.createIndex({ "messages.createdAt": 1 }, { sparse: true })
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(e, "Error creating index for conversations by messages createdAt")
+			);
 		// Unique index for stats
 		conversationStats
 			.createIndex(
@@ -212,7 +220,12 @@ export class Database {
 				},
 				{ unique: true }
 			)
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(
+					e,
+					"Error creating index for conversationStats by type, date.field and date.span"
+				)
+			);
 		// Allow easy check of last computed stat for given type/dateField
 		conversationStats
 			.createIndex({
@@ -220,57 +233,103 @@ export class Database {
 				"date.field": 1,
 				"date.at": 1,
 			})
-			.catch((e) => logger.error(e));
+			.catch((e) => logger.error(e, "Error creating index for abortedGenerations by updatedAt"));
 		abortedGenerations
 			.createIndex({ updatedAt: 1 }, { expireAfterSeconds: 30 })
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(
+					e,
+					"Error creating index for abortedGenerations by updatedAt and expireAfterSeconds"
+				)
+			);
 		abortedGenerations
 			.createIndex({ conversationId: 1 }, { unique: true })
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(e, "Error creating index for abortedGenerations by conversationId")
+			);
 		sharedConversations.createIndex({ hash: 1 }, { unique: true }).catch((e) => logger.error(e));
 		settings
 			.createIndex({ sessionId: 1 }, { unique: true, sparse: true })
-			.catch((e) => logger.error(e));
+			.catch((e) => logger.error(e, "Error creating index for settings by sessionId"));
 		settings
 			.createIndex({ userId: 1 }, { unique: true, sparse: true })
-			.catch((e) => logger.error(e));
-		settings.createIndex({ assistants: 1 }).catch((e) => logger.error(e));
-		users.createIndex({ hfUserId: 1 }, { unique: true }).catch((e) => logger.error(e));
+			.catch((e) => logger.error(e, "Error creating index for settings by userId"));
+		settings
+			.createIndex({ assistants: 1 })
+			.catch((e) => logger.error(e, "Error creating index for settings by assistants"));
+		users
+			.createIndex({ hfUserId: 1 }, { unique: true })
+			.catch((e) => logger.error(e, "Error creating index for users by hfUserId"));
 		users
 			.createIndex({ sessionId: 1 }, { unique: true, sparse: true })
-			.catch((e) => logger.error(e));
+			.catch((e) => logger.error(e, "Error creating index for users by sessionId"));
 		// No unicity because due to renames & outdated info from oauth provider, there may be the same username on different users
-		users.createIndex({ username: 1 }).catch((e) => logger.error(e));
+		users
+			.createIndex({ username: 1 })
+			.catch((e) => logger.error(e, "Error creating index for users by username"));
 		messageEvents
 			.createIndex({ expiresAt: 1 }, { expireAfterSeconds: 1 })
-			.catch((e) => logger.error(e));
+			.catch((e) => logger.error(e, "Error creating index for messageEvents by expiresAt"));
 		sessions.createIndex({ expiresAt: 1 }, { expireAfterSeconds: 0 }).catch((e) => logger.error(e));
-		sessions.createIndex({ sessionId: 1 }, { unique: true }).catch((e) => logger.error(e));
-		assistants.createIndex({ createdById: 1, userCount: -1 }).catch((e) => logger.error(e));
-		assistants.createIndex({ userCount: 1 }).catch((e) => logger.error(e));
-		assistants.createIndex({ review: 1, userCount: -1 }).catch((e) => logger.error(e));
-		assistants.createIndex({ modelId: 1, userCount: -1 }).catch((e) => logger.error(e));
-		assistants.createIndex({ searchTokens: 1 }).catch((e) => logger.error(e));
-		assistants.createIndex({ last24HoursCount: 1 }).catch((e) => logger.error(e));
+		sessions
+			.createIndex({ sessionId: 1 }, { unique: true })
+			.catch((e) => logger.error(e, "Error creating index for sessions by sessionId"));
+		assistants
+			.createIndex({ createdById: 1, userCount: -1 })
+			.catch((e) =>
+				logger.error(e, "Error creating index for assistants by createdById and userCount")
+			);
+		assistants
+			.createIndex({ userCount: 1 })
+			.catch((e) => logger.error(e, "Error creating index for assistants by userCount"));
+		assistants
+			.createIndex({ review: 1, userCount: -1 })
+			.catch((e) => logger.error(e, "Error creating index for assistants by review and userCount"));
+		assistants
+			.createIndex({ modelId: 1, userCount: -1 })
+			.catch((e) =>
+				logger.error(e, "Error creating index for assistants by modelId and userCount")
+			);
+		assistants
+			.createIndex({ searchTokens: 1 })
+			.catch((e) => logger.error(e, "Error creating index for assistants by searchTokens"));
+		assistants
+			.createIndex({ last24HoursCount: 1 })
+			.catch((e) => logger.error(e, "Error creating index for assistants by last24HoursCount"));
 		assistants
 			.createIndex({ last24HoursUseCount: -1, useCount: -1, _id: 1 })
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(e, "Error creating index for assistants by last24HoursUseCount and useCount")
+			);
 		assistantStats
 			// Order of keys is important for the queries
 			.createIndex({ "date.span": 1, "date.at": 1, assistantId: 1 }, { unique: true })
-			.catch((e) => logger.error(e));
-		reports.createIndex({ assistantId: 1 }).catch((e) => logger.error(e));
-		reports.createIndex({ createdBy: 1, assistantId: 1 }).catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(
+					e,
+					"Error creating index for assistantStats by date.span and date.at and assistantId"
+				)
+			);
+		reports
+			.createIndex({ assistantId: 1 })
+			.catch((e) => logger.error(e, "Error creating index for reports by assistantId"));
+		reports
+			.createIndex({ createdBy: 1, assistantId: 1 })
+			.catch((e) =>
+				logger.error(e, "Error creating index for reports by createdBy and assistantId")
+			);
 
 		// Unique index for semaphore and migration results
 		semaphores.createIndex({ key: 1 }, { unique: true }).catch((e) => logger.error(e));
 		semaphores
 			.createIndex({ deleteAt: 1 }, { expireAfterSeconds: 1 })
-			.catch((e) => logger.error(e));
+			.catch((e) => logger.error(e, "Error creating index for semaphores by deleteAt"));
 		tokenCaches
 			.createIndex({ createdAt: 1 }, { expireAfterSeconds: 5 * 60 })
-			.catch((e) => logger.error(e));
-		tokenCaches.createIndex({ tokenHash: 1 }).catch((e) => logger.error(e));
+			.catch((e) => logger.error(e, "Error creating index for tokenCaches by createdAt"));
+		tokenCaches
+			.createIndex({ tokenHash: 1 })
+			.catch((e) => logger.error(e, "Error creating index for tokenCaches by tokenHash"));
 		// Tools removed: skipping tools indexes
 
 		conversations
@@ -278,16 +337,22 @@ export class Database {
 				"messages.from": 1,
 				createdAt: 1,
 			})
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(e, "Error creating index for conversations by messages from and createdAt")
+			);
 
 		conversations
 			.createIndex({
 				userId: 1,
 				sessionId: 1,
 			})
-			.catch((e) => logger.error(e));
+			.catch((e) =>
+				logger.error(e, "Error creating index for conversations by userId and sessionId")
+			);
 
-		config.createIndex({ key: 1 }, { unique: true }).catch((e) => logger.error(e));
+		config
+			.createIndex({ key: 1 }, { unique: true })
+			.catch((e) => logger.error(e, "Error creating index for config by key"));
 	}
 }
 

src/lib/server/exitHandler.ts

@@ -38,7 +38,7 @@ export function initExitHandler() {
 			process.kill(process.pid, "SIGKILL");
 		} else {
 			exitHandler().catch((err) => {
-				logger.error("Exit handler error:", err);
+				logger.error(err, "Error in exit handler on SIGINT:");
 				process.kill(process.pid, "SIGKILL");
 			});
 		}
@@ -51,7 +51,7 @@ export function initExitHandler() {
 			process.kill(process.pid, "SIGKILL");
 		} else {
 			exitHandler().catch((err) => {
-				logger.error("Exit handler error:", err);
+				logger.error(err, "Error in exit handler on SIGTERM:");
 				process.kill(process.pid, "SIGKILL");
 			});
 		}

src/lib/server/textGeneration/generate.ts

@@ -125,7 +125,7 @@ export async function* generate(
 					};
 				} catch (e) {
 					finalAnswer = text;
-					logger.error(e);
+					logger.error(e, "Error generating summary of reasoning");
 				}
 			} else if (modelReasoning && modelReasoning.type === "tokens") {
 				// Remove the reasoning segment from final answer to avoid duplication
@@ -216,7 +216,7 @@ export async function* generate(
 						status = summary;
 					});
 				} catch (e) {
-					logger.error(e);
+					logger.error(e, "Error generating summary of reasoning");
 				}
 			}
 

src/lib/server/textGeneration/title.ts

@@ -23,7 +23,7 @@ export async function* generateTitleForConversation(
 			title,
 		};
 	} catch (cause) {
-		logger.error(Error("Failed whilte generating title for conversation", { cause }));
+		logger.error(cause, "Failed while generating title for conversation");
 	}
 }
 
@@ -74,7 +74,7 @@ Return only the title text.`,
 			return trimmed || firstFive;
 		})
 		.catch((e) => {
-			logger.error(e);
+			logger.error(e, "Error generating title");
 			const firstFive = prompt.split(/\s+/g).slice(0, 5).join(" ");
 			return firstFive;
 		});

src/routes/admin/stats/compute/+server.ts

@@ -6,7 +6,7 @@ import { computeAllStats } from "$lib/jobs/refresh-conversation-stats";
 // curl -X POST "http://localhost:5173/chat/admin/stats/compute" -H "Authorization: Bearer <ADMIN_API_SECRET>"
 
 export async function POST() {
-	computeAllStats().catch((e) => logger.error(e));
+	computeAllStats().catch((e) => logger.error(e, "Error computing all stats"));
 	return json(
 		{
 			message: "Stats job started",

src/routes/api/fetch-url/+server.ts

@@ -40,7 +40,7 @@ export async function GET({ url }) {
 		}).finally(() => clearTimeout(timeoutId));
 
 		if (!response.ok) {
-			logger.error({ targetUrl, response }, `Error fetching URL. Response not ok.`);
+			logger.error({ targetUrl, response }, "Error fetching URL. Response not ok.");
 			throw error(response.status, `Failed to fetch: ${response.statusText}`);
 		}
 
@@ -75,14 +75,14 @@ export async function GET({ url }) {
 	} catch (err) {
 		if (err instanceof Error) {
 			if (err.name === "AbortError") {
-				logger.error(err, `Request timeout`);
+				logger.error(err, "Request timeout");
 				throw error(504, "Request timeout");
 			}
 
-			logger.error(err, `Error fetching URL`);
+			logger.error(err, "Error fetching URL");
 			throw error(500, `Failed to fetch URL: ${err.message}`);
 		}
-		logger.error(err, `Error fetching URL`);
+		logger.error(err, "Error fetching URL");
 		throw error(500, "Failed to fetch URL.");
 	}
 }

src/routes/conversation/[id]/+server.ts

@@ -602,7 +602,7 @@ export async function POST({ request, locals, params, getClientAddress }) {
 						message: err.message,
 						...(statusCode && { statusCode }),
 					});
-					logger.error(err);
+					logger.error(err, "Error in conversation stream");
 				}
 			} finally {
 				// check if no output was generated