Update app.py

app.py

@@ -4,10 +4,14 @@ from langchain.chains import ConversationChain
 from langchain.memory import ConversationBufferMemory
 import os
 from datetime import datetime, timedelta
+from dotenv import load_dotenv
+
+# Load environment variables - MUST be at the top
+load_dotenv('.env')  # Explicitly load from .env file
 
 # Configure page
 st.set_page_config(
-    page_title="Tourism Chatbot", 
+    page_title="Tourism Chatbot",
     page_icon="🌍",
     layout="wide"
 )
@@ -32,139 +36,162 @@ if "messages" not in st.session_state:
 if "last_request" not in st.session_state:
     st.session_state.last_request = datetime.now() - timedelta(seconds=10)
 
-# Language selector with better styling
+# Language selector
 language = st.selectbox(
-    "Choose Language / اختر اللغة", 
+    "Choose Language / اختر اللغة",
     ["English", "العربية"],
     key="lang_select"
 )
 
-# Hugging Face API token with better error handling
-try:
-    hf_api_token = os.environ["HF_API_TOKEN"]
-except KeyError:
+# Hugging Face API token configuration - PRODUCTION READY
+HF_TOKEN = os.environ.get("HUGGINGFACEHUB_API_TOKEN")
+if not HF_TOKEN:
     st.error("""
-        Hugging Face API token not found. 
-        Please set it in the Space secrets as HF_API_TOKEN.
+        API token not configured properly. Please:
+        1. Create a .env file with HUGGINGFACEHUB_API_TOKEN=your_token_here
+        2. On Hugging Face Spaces, add it as a secret named HUGGINGFACEHUB_API_TOKEN
     """)
     st.stop()
 
-# Improved model selection with better Arabic support
+# Enhanced model configuration
 model_config = {
     "English": {
-        "repo_id": "google/flan-t5-large",
-        "params": {"temperature": 0.7, "max_length": 512}
+        "repo_id": "google/flan-t5-xxl",
+        "params": {
+            "temperature": 0.7,
+            "max_length": 512,
+            "max_new_tokens": 300,
+            "repetition_penalty": 1.2
+        }
     },
     "العربية": {
-        "repo_id": "aubmindlab/aragpt2-base",
-        "params": {"temperature": 0.5, "max_length": 1024}
+        "repo_id": "aubmindlab/aragpt2-mega",
+        "params": {
+            "temperature": 0.6,
+            "max_length": 1024,
+            "max_new_tokens": 400,
+            "repetition_penalty": 1.3
+        }
     }
 }
 
-# Initialize the language model with error handling
+# Initialize the language model with enhanced error handling
 try:
     llm = HuggingFaceHub(
         repo_id=model_config[language]["repo_id"],
-        huggingfacehub_api_token=hf_api_token,
+        huggingfacehub_api_token=HF_TOKEN,  # Correct parameter name
         model_kwargs=model_config[language]["params"]
     )
-    
+
     conversation = ConversationChain(
         llm=llm,
         memory=st.session_state.memory,
         verbose=False
     )
 except Exception as e:
-    st.error(f"Failed to initialize model: {str(e)}")
+    error_msg = str(e)
+    if "API token" in error_msg:
+        st.error("Invalid API token. Please check your Hugging Face token.")
+    elif "repo_id" in error_msg:
+        st.error("Model loading failed. The specified model may not be available.")
+    else:
+        st.error(f"Initialization error: {error_msg}")
     st.stop()
 
-# Display chat history with avatars
+# Display chat history with improved formatting
 for message in st.session_state.messages:
-    avatar = "🧑" if message["role"] == "user" else "🤖"
+    avatar = "🧑" if message["role"] == "user" else "🌍"
     with st.chat_message(message["role"], avatar=avatar):
-        st.markdown(message["content"])
+        if language == "العربية":
+            st.markdown(f"<div style='text-align: right;'>{message['content']}</div>", unsafe_allow_html=True)
+        else:
+            st.markdown(message["content"])
 
-# Rate limiting check
-if (datetime.now() - st.session_state.last_request).seconds < 2:
-    st.warning("Please wait a moment before sending another message.")
+# Enhanced rate limiting
+if (datetime.now() - st.session_state.last_request).seconds < 3:
+    st.warning("Please wait a moment before sending another message." if language == "English"
+               else "الرجاء الانتظار قليلاً قبل إرسال رسالة أخرى")
     st.stop()
 
-# User input with language-specific placeholders
-prompt = st.chat_input(
-    "Ask about tourist destinations..." if language == "English" 
-    else "اسأل عن الوجهات السياحية..."
-)
+# User input with better placeholder handling
+prompt_placeholder = {
+    "English": "Ask about destinations, culture, or safety tips...",
+    "العربية": "اسأل عن الوجهات، الثقافة، أو نصائح السلامة..."
+}
+prompt = st.chat_input(prompt_placeholder[language])
 
 if prompt:
-    # Update last request time
     st.session_state.last_request = datetime.now()
-    
-    # Add user message to chat history
     st.session_state.messages.append({"role": "user", "content": prompt})
-    
-    # Display user message
+
     with st.chat_message("user", avatar="🧑"):
         st.markdown(prompt)
-    
-    # Display assistant response
-    with st.chat_message("assistant", avatar="🤖"):
+
+    with st.chat_message("assistant", avatar="🌍"):
         with st.spinner("Generating response..." if language == "English" else "جارٍ تحضير الرد..."):
             try:
                 # Enhanced prompt engineering
                 if language == "English":
-                    full_prompt = f"""You are an expert tourism assistant. Provide detailed, helpful information about:
-                    - Travel destinations
-                    - Cultural experiences
-                    - Local customs
-                    - Safety advice
-                    
+                    full_prompt = """You are an expert tourism assistant specializing in:
+                    - Detailed travel destination information
+                    - Cultural norms and etiquette
+                    - Safety recommendations
+                    - Local transportation options
+                    - Authentic dining experiences
+
                     Question: {prompt}
-                    Answer:"""
+                    Answer in clear, detailed points:""".format(prompt=prompt)
                 else:
-                    full_prompt = f"""أنت مساعد سياحي خبير. قدم معلومات مفيدة ومفصلة حول:
-                    - الوجهات السياحية
-                    - التجارب الثقافية
-                    - العادات المحلية
-                    - نصائح السلامة
-                    
+                    full_prompt = """أنت مساعد سياحي خبير متخصص في:
+                    - معلومات مفصلة عن الوجهات السياحية
+                    - الأعراف الثقافية وآداب السلوك
+                    - توصيات السلامة
+                    - خيارات النقل المحلي
+                    - تجارب تناول الطعام الأصيلة
+
                     السؤال: {prompt}
-                    الجواب:"""
-                
+                    الجواب بنقاط واضحة ومفصلة:""".format(prompt=prompt)
+
                 response = conversation.predict(input=full_prompt)
-                st.markdown(response)
-                
-                # Add to chat history
-                st.session_state.messages.append({"role": "assistant", "content": response})
-                
+
+                # Post-process response
+                cleaned_response = response.strip()
+                if language == "العربية":
+                    cleaned_response = f"<div style='text-align: right;'>{cleaned_response}</div>"
+
+                st.markdown(cleaned_response, unsafe_allow_html=True)
+                st.session_state.messages.append({"role": "assistant", "content": cleaned_response})
+
             except Exception as e:
-                st.error(f"Error generating response: {str(e)}")
+                error_response = {
+                    "English": "Sorry, I encountered an error. Please try again later.",
+                    "العربية": "عذرًا، حدث خطأ. يرجى المحاولة مرة أخرى لاحقًا."
+                }
+                st.error(error_response[language])
                 st.session_state.messages.append({
-                    "role": "assistant", 
-                    "content": "Sorry, I encountered an error. Please try again."
+                    "role": "assistant",
+                    "content": error_response[language]
                 })
 
-# Enhanced sidebar with clear sections
+# Sidebar with deployment-ready information
 with st.sidebar:
-    st.header("ℹ️ About this Chatbot")
-    
-    if language == "English":
-        st.markdown("""
-            ### Features:
-            - Bilingual English/Arabic support
-            - Tourism expert knowledge
-            - Conversation memory
-            
-            **Note:** Responses may take 10-20 seconds to generate.
-        """)
-    else:
-        st.markdown("""
-            ### الميزات:
-            - دعم ثنائي اللغة الإنجليزية/العربية
-            - معرفة خبيرة بالسياحة
-            - ذاكرة المحادثة
-            
-            **ملاحظة:** قد يستغرق الرد 10-20 ثانية.
-        """)
-    
-    st.markdown("---")
-    st.markdown("Made with ❤️ using [Streamlit](https://streamlit.io/) and [LangChain](https://langchain.com/)")
+    st.header("ℹ️ " + ("About" if language == "English" else "حول"))
+
+    about_text = {
+        "English": """
+        **Tourism Expert Chatbot**  
+        • Provides detailed travel information  
+        • Offers cultural insights  
+        • Available in English/Arabic  
+        • Remembers conversation history  
+        """,
+        "العربية": """
+        **مساعد سياحي خبير**  
+        • يقدم معلوم��ت سفر مفصلة  
+        • يوفر رؤى ثقافية  
+        • متاح باللغتين الإنجليزية والعربية  
+        • يحفظ تاريخ المحادثة  
+        """
+    }
+
+    st.markdown(about_text[language])