fix: correct initial call to update_declining_increment to match new input signature

dashboard/app.py

@@ -19,6 +19,7 @@ from dashboard.plots import check_complex, create_growth_increment_plots, create
 from dashboard.tables import create_survival_table, create_biomass_table, create_project_results_table
 import yaml
 import tempfile
+from dashboard.inputs import get_model_inputs
 
 MODEL_CONFIGS = {
     "Declining Increment": "configs/declining_increment.yaml"
@@ -252,34 +253,10 @@ This version is smoother and may yield slightly different results than the discr
                     biomass_debug_table = gr.Dataframe(label="Biomass Table (inputs & outputs per year)")
             # --- End tabbed tables ---
             # --- Adjustable Model Inputs ---
-            config = yaml.safe_load(open(MODEL_CONFIGS["Declining Increment"]))
-            spA = config["species"][0]
-            spB = config["species"][1]
+            model_inputs, model_defaults = get_model_inputs(config)
             with gr.Accordion("Adjust Model Inputs", open=True):
-                with gr.Row():
-                    planting_density_A = gr.Number(value=spA['planting_density'], label=f"{spA['name']} Planting Density (trees/ha)")
-                    r0_dbh_A = gr.Number(value=spA['declining_increment']['dbh']['r0'], label=f"{spA['name']} r0 (DBH, cm/yr)")
-                    tm_dbh_A = gr.Number(value=spA['declining_increment']['dbh']['T_m'], label=f"{spA['name']} Tm (DBH, yrs)")
-                    r0_height_A = gr.Number(value=spA['declining_increment']['height']['r0'], label=f"{spA['name']} r0 (Height, m/yr)")
-                    tm_height_A = gr.Number(value=spA['declining_increment']['height']['T_m'], label=f"{spA['name']} Tm (Height, yrs)")
-                with gr.Row():
-                    planting_density_B = gr.Number(value=spB['planting_density'], label=f"{spB['name']} Planting Density (trees/ha)")
-                    r0_dbh_B = gr.Number(value=spB['declining_increment']['dbh']['r0'], label=f"{spB['name']} r0 (DBH, cm/yr)")
-                    tm_dbh_B = gr.Number(value=spB['declining_increment']['dbh']['T_m'], label=f"{spB['name']} Tm (DBH, yrs)")
-                    r0_height_B = gr.Number(value=spB['declining_increment']['height']['r0'], label=f"{spB['name']} r0 (Height, m/yr)")
-                    tm_height_B = gr.Number(value=spB['declining_increment']['height']['T_m'], label=f"{spB['name']} Tm (Height, yrs)")
-                with gr.Row():
-                    mort_1 = gr.Number(value=spA['mortality_rates']['year_1'], label="Year 1 Mortality (%)")
-                    mort_2 = gr.Number(value=spA['mortality_rates']['year_2'], label="Year 2 Mortality (%)")
-                    mort_3 = gr.Number(value=spA['mortality_rates']['year_3'], label="Year 3 Mortality (%)")
-                    mort_4 = gr.Number(value=spA['mortality_rates']['year_4'], label="Year 4 Mortality (%)")
-                    mort_5 = gr.Number(value=spA['mortality_rates']['year_5'], label="Year 5 Mortality (%)")
-                    mort_sub = gr.Number(value=spA['mortality_rates']['subsequent'], label="Subsequent Years Mortality (%)")
-                with gr.Row():
-                    project_duration = gr.Number(value=config['project']['duration_years'], label="Project Duration (years)")
-                    buffer_pct = gr.Number(value=config['carbon']['buffer_percentage'], label="Buffer %")
-                    soil_carbon = gr.Number(value=config['carbon']['soil_carbon_per_ha_per_year'], label="Soil Carbon per ha per year (tCO2)")
-            # Remove hardcoded key model inputs from Markdown section
+                for k, comp in model_inputs.items():
+                    comp.render()
             # Update the update_declining_increment callback to use these new inputs
             def update_declining_increment(y1, y2, y3, y4, y5,
                                            planting_density_A, r0_dbh_A, tm_dbh_A, r0_height_A, tm_height_A,
@@ -345,15 +322,11 @@ This version is smoother and may yield slightly different results than the discr
                 return (plots[0], plots[1], plots[2], growth_fig, summary, results_fmt, species_results_fmt, survival_table, biomass_debug_df, key_metrics_md)
             update_btn.click(
                 update_declining_increment,
-                inputs=[year_1, year_2, year_3, year_4, year_5,
-                        planting_density_A, r0_dbh_A, tm_dbh_A, r0_height_A, tm_height_A,
-                        planting_density_B, r0_dbh_B, tm_dbh_B, r0_height_B, tm_height_B,
-                        mort_1, mort_2, mort_3, mort_4, mort_5, mort_sub,
-                        project_duration, buffer_pct, soil_carbon],
+                inputs=[year_1, year_2, year_3, year_4, year_5] + list(model_inputs.values()),
                 outputs=[carbon_plot, biomass_plot, annual_plot, growth_plot, summary_box, results_box, species_box, survival_box, biomass_debug_table, key_metrics]
             )
             # Show initial results
-            c, b, a, g, summary, r, s, surv, biomass_debug_df, key_metrics_md = update_declining_increment(2500, 2500, 0, 0, 0, 2500, 2500, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)
+            c, b, a, g, summary, r, s, surv, biomass_debug_df, key_metrics_md = update_declining_increment(2500, 2500, 0, 0, 0, *model_defaults)
             carbon_plot.value = c
             biomass_plot.value = b
             annual_plot.value = a