fixed file download

agentcourse_unit4/api/agent_eval_api.py

@@ -1,3 +1,4 @@
+import urllib.request
 from typing import List
 
 import requests
@@ -20,18 +21,24 @@ class AgentEvalApi:
         response.raise_for_status()
         return response.json(object_hook=to_question_response)
 
-    def download_file(self, task_id: str) -> bytes:
-        """Download the file associated with the given task_id"""
-        response = requests.get(f"{self.files_url}/{task_id}", timeout=30)
-        response.raise_for_status()
-        return response.content
+    def download_file(self, task_id: str) -> str:
+        """Download the file associated with the given task_id to temp dir and return path to file"""
+        file_path = None
+
+        try:
+            result = urllib.request.urlretrieve(f"{self.files_url}/{task_id}")
+            file_path = result[0]
+        except Exception as e:
+            print(f"Error downloading file: {str(e)}")
+
+        return file_path
 
     def submit_answers(self, username: str, agent_code: str, answers: List[AnswerData]) -> SubmitAnswersResponse:
         """Submit answers from an agent, calculate score, and update leaderboard on HF"""
         request_body = {
             "username": username.strip(),
-            "agent_code": agent_code.strip(),
-            "answers": [{"task_id": a.task_id.strip(), "submitted_answer": a.answer.strip()} for a in answers]
+            "agent_code": agent_code,
+            "answers": [{"task_id": a.task_id, "submitted_answer": a.answer} for a in answers]
         }
         response = requests.post(self.submit_url, json=request_body, timeout=60)
         response.raise_for_status()

app.py

@@ -1,5 +1,4 @@
 import os
-import tempfile
 import time
 
 import gradio as gr
@@ -11,24 +10,6 @@ from agentcourse_unit4.api.answer_data import AnswerData
 from agentcourse_unit4.basic_agent import BasicAgent
 
 
-def save_to_file(content: str) -> str:
-    """
-    Create temporary file, save content to it and return absolute file path.
-
-    Args:
-        content: file content to save
-    Returns:
-        Path to  file
-    """
-    temp_file = tempfile.NamedTemporaryFile(delete=False)
-    filepath = temp_file.name
-
-    with open(filepath, 'w') as f:
-        f.write(content)
-
-    return filepath
-
-
 def run_and_submit_all(profile: gr.OAuthProfile | None):
     """
     Fetches all questions, runs the BasicAgent on them, submits all answers,
@@ -83,14 +64,13 @@ def run_and_submit_all(profile: gr.OAuthProfile | None):
         task_id = item.task_id
         question_text = item.question
         file_name = item.file_name
+
         if not task_id or question_text is None:
             print(f"Skipping item with missing task_id or question: {item}")
             continue
+
         try:
-            file_path = None
-            if len(file_name) > 0:
-                file_content = api_client.download_file(task_id)
-                file_path = save_to_file(str(file_content))
+            file_path = api_client.download_file(task_id) if len(file_name) > 0 else None
             submitted_answer = agent.run(question_text, file_path)
             answers_payload.append(AnswerData(task_id=task_id, answer=submitted_answer))
             results_log.append({"Task ID": task_id, "Question": question_text, "Submitted Answer": submitted_answer})