Query length warning

app.py

@@ -626,7 +626,7 @@ with gr.Blocks(title="Audit Q&A", css= "style.css", theme=theme,elem_id = "main-
     pending_query = gr.State(None)
 
     # Warning UI is implemented as a hidden row (to keep it simple)
-    with gr.Row(visible=False, elem_id="warning-row") as warning_row:
+    with gr.Row(visible=False, elem_id="warning-row", elem_classes="warning-message") as warning_row:
         with gr.Column():
             gr.Markdown("<span class='warning-icon'>⚠️</span> **No report filter selected. Are you sure you want to proceed?**")
             with gr.Row(elem_classes="warning-buttons"):
@@ -642,29 +642,41 @@ with gr.Blocks(title="Audit Q&A", css= "style.css", theme=theme,elem_id = "main-
         return gr.update(visible=False)
 
     # Logic needs to be changed to accomodate default filter values (currently I have them all set to None)
-    def check_filters(textbox_value, sources, reports, subtype, year):
+    def check_filters(check_status, textbox_value, sources, reports, subtype, year):
         """Check if any filters are selected"""
+        # If a previous check failed, don't continue with this check
+        if check_status is not None:
+            return (
+                check_status,  # keep current check status
+                False,  # keep warning state unchanged
+                gr.update(visible=False),  # keep warning row visibility unchanged
+                textbox_value,  # keep the textbox value
+                None  # no need to store query
+            )
+        
         no_filters = (not reports) and (not sources) and (not subtype) and (not year)
         if no_filters:
-            # If no filters, show warning and stop chain
+            # If no filters, show warning and set status
             return (
+                "filter",  # check status - no filters selected
                 True,  # warning state
                 gr.update(visible=True),  # warning row visibility
-                None,  # textbox value (None stops the chain)
+                gr.update(value=""),  # clear textbox
                 textbox_value  # store the query
             )
         # If filters exist, proceed normally
         return (
-            False,
-            gr.update(visible=False),
+            None,  # no check failed
+            False,  # normal state
+            gr.update(visible=False),  # hide warning
             textbox_value,  # keep the original value
             None  # no need to store query
         )
     
-    async def handle_chat_flow(warning_active, query, chatbot, sources, reports, subtype, year, client_ip, session_id):
-        """Handle chat flow with warning check and chat processing"""
-        if warning_active or query is None:  
-            # Either warning is active or query was stopped by filter check
+    async def handle_chat_flow(check_status, warning_active, short_query_warning_active, query, chatbot, sources, reports, subtype, year, client_ip, session_id):
+        """Handle chat flow with explicit check for status"""
+        # Don't proceed if any check failed or query is None
+        if check_status is not None or warning_active or short_query_warning_active or query is None or query == "":
             yield (
                 chatbot,  # unchanged chatbot
                 "",  # empty sources
@@ -680,16 +692,56 @@ with gr.Blocks(title="Audit Q&A", css= "style.css", theme=theme,elem_id = "main-
         # Proceed with chat and yield each update
         async for update in chat(query, history, sources, reports, subtype, year, client_ip, session_id):
             yield update
+
+    #-------------------- Short Query Warning -------------------------
+    # Warn users when query is too short (less than 4 words)
+    short_query_warning_state = gr.State(False)
+    check_status = gr.State(None)
+    
+    # Short query warning UI - using exact same structure as filters warning
+    with gr.Row(visible=False, elem_id="warning-row", elem_classes="warning-message") as short_query_warning_row:
+        with gr.Column():
+            gr.Markdown("<span class='warning-icon'>⚠️</span> **Your query is too short. Please lengthen your query to ensure the app has adequate context.**")
+            with gr.Row(elem_classes="warning-buttons"):
+                short_query_proceed_btn = gr.Button("OK", elem_classes="proceed")
+
+    def check_query_length(textbox_value):
+        """Check if query has at least 4 words"""
+        if textbox_value and len(textbox_value.split()) < 4:
+            # If query is too short, show warning and set status
+            return (
+                "short",  # check status - this query is too short
+                True,  # short query warning state
+                gr.update(visible=True),  # short query warning row visibility
+                gr.update(value=""),  # clear textbox 
+                textbox_value  # store the query
+            )
+        # If query is long enough, proceed normally
+        return (
+            None,  # no check failed
+            False,  # normal state
+            gr.update(visible=False),  # hide warning
+            gr.update(value=textbox_value),  # keep the textbox value
+            None  # no need to store query
+        )
+
     
     #-------------------- Gradio Handlers -------------------------
     
     # Hanlders: Text input from Textbox
     (textbox
         .submit(
+            check_query_length,
+            [textbox],
+            [check_status, short_query_warning_state, short_query_warning_row, textbox, pending_query],
+            api_name="check_query_length_textbox"
+        )
+        .then(
             check_filters,
-            [textbox, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year],
-            [warning_state, warning_row, textbox, pending_query],
-            api_name="submit_textbox"
+            [check_status, textbox, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year],
+            [check_status, warning_state, warning_row, textbox, pending_query],
+            api_name="submit_textbox",
+            show_progress=False
         )
         .then(
             get_client_ip_handler,
@@ -700,7 +752,7 @@ with gr.Blocks(title="Audit Q&A", css= "style.css", theme=theme,elem_id = "main-
         )
         .then(
             handle_chat_flow,
-            [warning_state, textbox, chatbot, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year, client_ip, session_id],
+            [check_status, warning_state, short_query_warning_state, textbox, chatbot, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year, client_ip, session_id],
             [chatbot, sources_textbox, feedback_state, session_id],
             queue=True,
             api_name="handle_chat_flow_textbox"
@@ -720,15 +772,21 @@ with gr.Blocks(title="Audit Q&A", css= "style.css", theme=theme,elem_id = "main-
     
     # Hanlders: Text input from Examples (same chain as textbox)
     examples_hidden.change(
-        lambda x: x,  # just get the example string and send it through the chain
+        lambda x: x,
         inputs=examples_hidden,
         outputs=textbox,
         api_name="submit_examples"
+        ).then(
+            check_query_length,
+            [textbox],
+            [check_status, short_query_warning_state, short_query_warning_row, textbox, pending_query],
+            api_name="check_query_length_examples"
         ).then(
             check_filters,
-            [textbox, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year],
-            [warning_state, warning_row, textbox, pending_query],
-            api_name="check_filters_examples"
+            [check_status, textbox, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year],
+            [check_status, warning_state, warning_row, textbox, pending_query],
+            api_name="check_filters_examples",
+            show_progress=False
         ).then(
             get_client_ip_handler,
             [textbox],
@@ -737,7 +795,7 @@ with gr.Blocks(title="Audit Q&A", css= "style.css", theme=theme,elem_id = "main-
             api_name="get_client_ip_examples"
         ).then( 
             handle_chat_flow,
-            [warning_state, textbox, chatbot, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year, client_ip, session_id],
+            [check_status, warning_state, short_query_warning_state, textbox, chatbot, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year, client_ip, session_id],
             [chatbot, sources_textbox, feedback_state, session_id],
             queue=True,
             api_name="handle_chat_flow_examples"
@@ -757,24 +815,21 @@ with gr.Blocks(title="Audit Q&A", css= "style.css", theme=theme,elem_id = "main-
     # Handlers for the warning buttons
     proceed_btn.click(
         lambda query: (
+            None,  # reset check status
             False,  # warning state
             gr.update(visible=False),  # warning row
             gr.update(value=query if query else "", interactive=True),  # restore query
             None  # clear pending query
         ),
         pending_query,
-        [warning_state, warning_row, textbox, pending_query]
-    ).then(
-        lambda: False,  
-        None,
-        warning_state
+        [check_status, warning_state, warning_row, textbox, pending_query]
     ).then(
         get_client_ip_handler,
         [textbox],
         [client_ip]
     ).then(
         handle_chat_flow,
-        [warning_state, textbox, chatbot, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year, client_ip, session_id],
+        [check_status, warning_state, short_query_warning_state, textbox, chatbot, dropdown_sources, dropdown_reports, dropdown_category, dropdown_year, client_ip, session_id],
         [chatbot, sources_textbox, feedback_state, session_id],
         queue=True  
     ).then(
@@ -789,15 +844,28 @@ with gr.Blocks(title="Audit Q&A", css= "style.css", theme=theme,elem_id = "main-
 
     cancel_btn.click(
         lambda: (
-            False,
-            gr.update(visible=False),
-            gr.update(value="", interactive=True),
-            None
+            None,  # reset check status
+            False,  # warning state
+            gr.update(visible=False),  # warning row
+            gr.update(value="", interactive=True),  # clear textbox
+            None  # clear pending query
         ),
         None,
-        [warning_state, warning_row, textbox, pending_query]
+        [check_status, warning_state, warning_row, textbox, pending_query]
     )
 
+    # short query warning OK button
+    short_query_proceed_btn.click(
+        lambda query: (
+            None,  # reset check status
+            False,  # short query warning state
+            gr.update(visible=False),  # short query warning row
+            gr.update(value=query if query else "", interactive=True),  # restore query
+            None  # clear pending query
+        ),
+        pending_query,
+        [check_status, short_query_warning_state, short_query_warning_row, textbox, pending_query]
+    )
 
     demo.queue()
 

model_params.cfg

@@ -11,6 +11,6 @@ DEDICATED_MODEL = meta-llama/Llama-3.1-8B-Instruct
 DEDICATED_ENDPOINT = https://qu2d8m6dmsollhly.us-east-1.aws.endpoints.huggingface.cloud
 NVIDIA_MODEL = meta-llama/Llama-3.1-8B-Instruct
 NVIDIA_ENDPOINT = https://huggingface.co/api/integrations/dgx/v1
-MAX_TOKENS = 512
+MAX_TOKENS = 64
 [app]
 repo_id = mtyrrell/spaces_log

style.css

@@ -443,22 +443,22 @@ span.chatbot > p > img{
     margin: 0 5px;
 }
 
-/* Warning popup styling */
+/* #_______ Warning "popup" styling _______ */
 #warning-row {
     background-color: #fff3cd;
     border: 1px solid #ffeeba;
     border-radius: 4px;
     padding: 15px 20px;
-    margin: 10px 0;
+    margin: 10px 0; /* Reset margin */
     box-shadow: 0 4px 8px rgba(0, 0, 0, 0.1);
-    position: relative;
+    position: left; /* Reset to normal positioning */
     z-index: 1000;
     font-size: 14px;
     color: #856404;
-    width: 100%;
+    width: 65%; /* Approximatation of chatbox width */
+    box-sizing: border-box; 
 }
 
-/* Only apply the animation when the element is visible */
 #warning-row.visible {
     animation: fadeIn 0.3s ease-in-out;
 }
@@ -470,10 +470,24 @@ span.chatbot > p > img{
     text-align: center;
 }
 
-#warning-row .warning-icon {
-    color: #856404;
-    margin-right: 8px;
-    font-size: 1.2em;
+#warning-row.warning-message span.warning-icon,
+#warning-row.warning-message .prose span.warning-icon {
+    font-size: 1.7em !important;
+    color: #856404 !important;
+    margin-right: 10px !important;
+    display: inline-block !important;
+    vertical-align: middle !important;
+}
+
+#warning-row.warning-message .prose p,
+#warning-row.warning-message .prose strong {
+    font-size: 14px !important;
+    line-height: 1.5 !important;
+    font-weight: bold;
+}
+
+#warning-row.warning-message {
+    padding: 20px 25px !important;
 }
 
 #warning-row .warning-buttons {
@@ -481,11 +495,12 @@ span.chatbot > p > img{
     justify-content: center;
     gap: 15px;
     margin-top: 10px;
-    width: 100%;
 }
 
 #warning-row button {
     min-width: 100px;
+    max-width: 150px;
+    width: auto;
     border-radius: 4px;
     transition: background-color 0.3s;
 }
@@ -532,3 +547,7 @@ body.dark #warning-row button.cancel {
     from { opacity: 0; transform: translateY(-10px); }
     to { opacity: 1; transform: translateY(0); }
 }
+
+
+
+