Update common/ResponseValidation.py

common/ResponseValidation.py

@@ -15,40 +15,59 @@ def matches_user_speaking_style(answer, processor_llm, user_profile, agent_quest
     logging.info("[Style Match Check] Entry")
 
     try:
-        # --- Step 1: First-person check ---
+        # --- Step 1: Skip style check for factual questions ---
+        factual_keywords = [
+            "name", "age", "where are you from", "where do you live", "occupation",
+            "birthplace", "what do you do", "how old", "which city", "which country"
+        ]
+        lower_q = agent_question.strip().lower()
+        is_factual = any(kw in lower_q for kw in factual_keywords)
+        if is_factual:
+            logging.info("[Style Match Check] Question is factual — skipping strict first-person enforcement")
+            if return_explanation:
+                return True, None
+            return True
+
+        # --- Step 2: Context-sensitive first-person check ---
         fp_prompt = f"""
 You are an expert in analysing writing style and narrative perspective.
-Determine whether the following response is written from a first-person point of view.
-A first-person response includes pronouns like "I", "me", "my", "mine", "we", "our", or "us".
-Say "First Person: Yes" only if clearly first-person, else say "First Person: No".
-Response:
+
+Determine whether the following response is *stylistically appropriate* and matches a first-person perspective *when contextually expected*.
+
+- A first-person response typically includes pronouns like "I", "me", "my", "mine", "we", "our", or "us".
+- However, for **short factual responses** (e.g. "What's your name?" → "Alex") or answers that clearly imply personal ownership or involvement (e.g. "Our team led the project"), the absence of explicit first-person pronouns can still be acceptable.
+- The key question is: **Given the question and expected tone, is the response appropriately personal and aligned with a first-person speaking style?**
+
+Evaluate the response below.
+
+### Question:
+{agent_question}
+
+### Response:
 {answer}
+
+Return:
+First Person: Yes
+or
+First Person: No
+and briefly explain if "No".
+
 Output format:
 First Person: Yes
 or
 First Person: No
+Reason: <short explanation>
 """
         fp_response = processor_llm.invoke(fp_prompt)
         fp_result = fp_response.content.strip().lower()
+
         if "first person: no" in fp_result:
-            logging.warning("[Style Match Check] Failed first-person test")
+            explanation = fp_result.split("reason:", 1)[-1].strip().capitalize() if "reason:" in fp_result else "The answer is not in first person."
+            logging.warning(f"[Style Match Check] Failed first-person test: {explanation}")
             if return_explanation:
-                return False, "The answer is not in first person."
+                return False, explanation
             return False
 
-        # --- Step 2: Skip style check for factual questions ---
-        factual_keywords = [
-            "name", "age", "where are you from", "where do you live", "occupation",
-            "birthplace", "what do you do", "how old", "which city", "which country"
-        ]
-        lower_q = agent_question.strip().lower()
-        is_factual = any(kw in lower_q for kw in factual_keywords)
-        if is_factual:
-            logging.info("[Style Match Check] Question is factual — skipping style evaluation")
-            if return_explanation:
-                return True, None
-            return True
-
         # --- Step 3: Extract user communication profile ---
         style = user_profile.get_field("Communication", "Style")
         tone = user_profile.get_field("Communication", "Tone")
@@ -86,7 +105,7 @@ Style Match: No
                 return True, None
             return True
         elif "style match: no" in style_result:
-            # --- New: Ask LLM for explanation on mismatch ---
+            # --- Ask LLM for explanation on mismatch ---
             explanation_prompt = f"""
 You are a communication coach and writing style analyst.
 The following response was evaluated as NOT matching the given communication profile.
@@ -123,6 +142,7 @@ Please provide a concise reason why the style does not match.
 
 
 
+
 def validate_response(question, answer, user_profile_str, fast_facts_str, interview_transcript_text, respondent_type, ai_evaluator_agent, processor_llm):
     llm_mode_prompt = f"""
 You are an expert in market research interview analysis. Given the following question, determine if it is: