Update src/api/admin.py

src/api/admin.py

@@ -1,50 +1,121 @@
-from fastapi import APIRouter, HTTPException, Request, Response
-from pydantic import BaseModel
+import logging
 import secrets
 import time
+from typing import Annotated
+
+from fastapi import APIRouter, Cookie, Depends, HTTPException, Request, Response
+from pydantic import BaseModel
+
+from src.config import get_settings
 
+logger = logging.getLogger(__name__)
 router = APIRouter()
 
+# In-memory session store — single instance on HF Spaces free tier
+# Resets on every container restart (expected behaviour)
+_admin_sessions: dict[str, float] = {}  # token → expiry timestamp
+
+
+# ── Auth Dependency ────────────────────────────────────────────────────────────
+
+def _cleanup_sessions():
+    """Evict expired tokens to prevent unbounded growth."""
+    now = time.time()
+    expired = [t for t, exp in _admin_sessions.items() if exp < now]
+    for t in expired:
+        del _admin_sessions[t]
+
+
+def require_admin(admin_session: Annotated[str | None, Cookie()] = None):
+    """FastAPI dependency — raises 401 if session is missing or expired."""
+    _cleanup_sessions()
+    if not admin_session or admin_session not in _admin_sessions:
+        raise HTTPException(status_code=401, detail="Not authenticated")
+    if _admin_sessions[admin_session] < time.time():
+        del _admin_sessions[admin_session]
+        raise HTTPException(status_code=401, detail="Session expired")
+
+
+# ── Request Models ─────────────────────────────────────────────────────────────
+
 class LoginRequest(BaseModel):
     password: str
 
+
 class ConfigUpdate(BaseModel):
     key: str
     value: str
 
-# Simple session storage (in-memory for HF single instance)
-admin_sessions = {}
+
+# ── Endpoints ──────────────────────────────────────────────────────────────────
 
 @router.post("/auth")
 async def admin_auth(req: LoginRequest):
-    from src.config import get_settings
     settings = get_settings()
-    
+
+    if not settings.admin_password:
+        raise HTTPException(status_code=503, detail="Admin password not configured")
+
     if req.password != settings.admin_password:
         raise HTTPException(status_code=401, detail="Invalid password")
-    
+
     token = secrets.token_hex(32)
-    admin_sessions[token] = time.time() + 86400  # 24 hours
-    
-    resp = Response(content='{"status": "ok"}')
-    resp.set_cookie(key="admin_session", value=token, httponly=True, max_age=86400)
+    _admin_sessions[token] = time.time() + 86400  # 24 hours
+
+    resp = Response(content='{"status": "ok"}', media_type="application/json")
+    resp.set_cookie(
+        key="admin_session",
+        value=token,
+        httponly=True,
+        secure=True,        # HTTPS only — HF Spaces always serves HTTPS
+        samesite="strict",
+        max_age=86400,
+    )
+    return resp
+
+
+@router.post("/logout")
+async def admin_logout(admin_session: Annotated[str | None, Cookie()] = None):
+    if admin_session and admin_session in _admin_sessions:
+        del _admin_sessions[admin_session]
+    resp = Response(content='{"status": "ok"}', media_type="application/json")
+    resp.delete_cookie("admin_session")
     return resp
 
-@router.get("/config")
+
+@router.get("/config", dependencies=[Depends(require_admin)])
 async def get_config():
-    from src.config import get_settings
     settings = get_settings()
     return {
         "max_results": settings.max_results,
-        "maintenance_mode": settings.maintenance_mode
+        "maintenance_mode": settings.maintenance_mode,
+        "environment": settings.environment,
     }
 
-@router.post("/config")
-async def update_config(req: ConfigUpdate, request: Request):
-    # Verify session
-    token = request.cookies.get("admin_session")
-    if not token or token not in admin_sessions:
-        raise HTTPException(status_code=401, detail="Not authenticated")
-    
-    # In real implementation, update DB or env
-    return {"status": "ok", "updated": req.key}
+
+@router.post("/config", dependencies=[Depends(require_admin)])
+async def update_config(req: ConfigUpdate):
+    # Runtime-only config update — does not persist across restarts.
+    # To persist, write to a file under /data (paid HF tier) or use an external store.
+    allowed_keys = {"maintenance_mode", "max_results"}
+    if req.key not in allowed_keys:
+        raise HTTPException(status_code=400, detail=f"Key '{req.key}' is not configurable at runtime")
+    # TODO: update a shared runtime config object here
+    logger.info(f"Admin config update: {req.key} = {req.value}")
+    return {"status": "ok", "updated": req.key, "note": "runtime only — resets on restart"}
+
+
+@router.get("/rag-status", dependencies=[Depends(require_admin)])
+async def rag_status():
+    """Admin view of RAG initialization state."""
+    try:
+        from app import rag_service
+        return rag_service.get_stats()
+    except Exception as e:
+        return {"error": str(e), "ready": False}
+
+
+@router.get("/sessions", dependencies=[Depends(require_admin)])
+async def session_info():
+    _cleanup_sessions()
+    return {"active_sessions": len(_admin_sessions)}