Update app.py

app.py

@@ -118,12 +118,13 @@ def set_config(key, value):
     conn.commit()
     conn.close()
 
+
 def get_behavior_instructions():
     base = get_config("bot_personality", "").strip()
     extra = get_config("custom_instructions", "").strip()
     if base and extra:
-        return f"{base}\n\nAdditional instructions:\n{extra}"
-    return base or extra or ""
+        return base + "\n\nAdditional instructions:\n" + extra
+    return base or extra or "You are a helpful, friendly, and knowledgeable library assistant at Khalifa University, Abu Dhabi, UAE. KU = Khalifa University, NOT Kuwait University. Be concise and include relevant URLs when useful."
 
 
 
@@ -419,32 +420,107 @@ async def tool_library_info(question, history=None, model="gpt"):
     # Common synonym mappings for library staff/service terms
     # This improves FAISS retrieval when users use informal terms
     SYNONYMS = {
-        "research librarian": "Research and Access Services Librarian Nikesh Narayanan",
+        "research librarian": "Research and Access Services Librarian Nikesh Narayanan research support",
         "who is the librarian": "library staff contacts librarian",
-        "subject librarian": "Research and Access Services Librarian",
-        "medical librarian": "Jason Fetty Medical Librarian",
-        "systems librarian": "Walter Hall Digital Technology Services Librarian",
-        "acquisitions librarian": "Alia Al-Harrasi collection development",
-        "public services": "Muna Alblooshi Manager Public Services",
-        "e-resources librarian": "Rani Anand e-resources databases",
-        "library director": "Dr Abdulla Al Hefeiti Assistant Provost",
-        "ebook": "ebook central proquest download",
-        "how to borrow": "borrowing loan period renew",
-        "access from home": "remote access off campus proxy",
-        "cite": "RefWorks citation reference management",
+        "subject librarian": "Research and Access Services Librarian Nikesh Narayanan",
+        "medical librarian": "Jason Fetty Medical Librarian PubMed Embase CINAHL UpToDate",
+        "systems librarian": "Walter Brian Hall Digital Technology Services Librarian website systems technology",
+        "website issue": "Walter Brian Hall website systems technology",
+        "technology issue": "Walter Brian Hall website systems technology",
+        "acquisitions librarian": "Alia Al-Harrasi acquisitions collection development request title",
+        "public services": "Muna Ahmad Al Blooshi public services circulation general library services",
+        "e-resources librarian": "Rani Anand e-resources databases access problems vendor issues",
+        "database access": "Rani Anand e-resources databases access problems",
+        "open access": "Nikesh Narayanan open access APC scholarly communication",
+        "orcid": "Nikesh Narayanan ORCID researcher identifier profile",
+        "research impact": "Nikesh Narayanan research impact SciVal Scopus bibliometrics",
+        "library director": "Dr Abdulla Al Hefeiti Assistant Provost Libraries",
+        "ebook": "ebook central proquest download ebooks",
+        "ebooks": "ebook central proquest download ebooks",
+        "how to borrow": "borrowing loan period renew circulation",
+        "borrow books": "borrowing loan period renew circulation",
+        "renew book": "renew borrowing circulation My Library Account",
+        "renew loan": "renew borrowing circulation My Library Account",
+        "hold item": "request hold checked out item My Library Account",
+        "reserve item": "request hold checked out item My Library Account",
+        "access from home": "remote access off campus proxy no VPN",
+        "off campus": "remote access off campus proxy no VPN",
+        "remote access": "remote access off campus proxy no VPN",
+        "cite": "RefWorks citation reference management bibliography",
+        "citation": "RefWorks citation reference management bibliography",
         "reference manager": "RefWorks citation bibliography",
         "researcher id": "ORCID researcher identifier profile",
-        "impact factor": "journal citation reports SciVal",
-        "systematic review": "Cochrane Embase CINAHL PICO",
-        "ai tools": "LeapSpace Scopus AI ScienceDirect AI EBSCO Research AI",
+        "impact factor": "journal citation reports JCR Scopus CiteScore SciVal",
+        "systematic review": "Cochrane Embase CINAHL PICO PubMed evidence based medicine",
+        "evidence based medicine": "Cochrane PubMed Embase CINAHL UpToDate",
+        "ai tools": "LeapSpace Scopus AI ScienceDirect AI EBSCO Research AI PRIMO AI",
+        "inter library loan": "interlibrary loan ILL document delivery article request",
+        "interlibrary loan": "interlibrary loan ILL document delivery article request",
+        "ill": "interlibrary loan ILL document delivery article request",
+        "document delivery": "interlibrary loan ILL document delivery article request",
+        "borrow from another library": "interlibrary loan ILL document delivery",
+        "request from another library": "interlibrary loan ILL document delivery",
+        "article not available": "full text article not available interlibrary loan LibKey Nomad",
+        "can't get article": "full text article not available interlibrary loan LibKey Nomad",
+        "cannot get article": "full text article not available interlibrary loan LibKey Nomad",
+        "don't get article": "full text article not available interlibrary loan LibKey Nomad",
+        "full text unavailable": "full text not available interlibrary loan LibKey Nomad",
+        "no full text": "full text not available interlibrary loan LibKey Nomad",
+        "full text": "full text LibKey Nomad article access PDF download",
+        "pdf": "full text LibKey Nomad article access PDF download",
+        "get article": "full text article access LibKey Nomad interlibrary loan",
+        "catalog": "PRIMO library catalog discovery holdings publication finder",
+        "library catalog": "PRIMO library catalog discovery holdings publication finder",
+        "discovery": "PRIMO library catalog discovery holdings publication finder",
+        "holdings": "PRIMO library catalog discovery holdings publication finder",
+        "does the library have": "PRIMO library catalog holdings publication finder",
+        "find journal": "PRIMO publication finder journal access holdings",
+        "publication finder": "PRIMO publication finder journal access holdings",
+        "circulation": "borrowing renew return hold loan period My Library Account",
+        "due date": "borrowing renew due date My Library Account",
+        "reserve room": "study room reserve rooms booking",
+        "book room": "study room reserve rooms booking",
+        "study room": "study room reserve rooms booking",
+        "ask librarian": "Ask a Librarian research help reference consultation",
+        "research help": "Ask a Librarian research consultation reference help",
+        "consultation": "Ask a Librarian research consultation reference help",
+        "peer reviewed": "peer reviewed scholarly journal article database filters",
+        "scholarly article": "peer reviewed scholarly journal article database filters",
+        "abstract": "article abstract citation database search results",
+        "doi": "DOI article identifier full text citation",
+        "call number": "PRIMO call number browse book location",
+        "course reserve": "reserve course materials reserve collection",
+        "visitor": "visitors external visitors access library",
+        "alumni": "alumni services library access alumni",
+        "civil engineering": "ASCE Library Knovel ScienceDirect Scopus ASTM Compass",
+        "mechanical engineering": "ASME Digital Library Knovel ScienceDirect ASTM Compass",
+        "electrical engineering": "IEEE Xplore INSPEC ScienceDirect",
+        "computer science": "ACM Digital Library IEEE Xplore arXiv ScienceDirect",
+        "artificial intelligence": "ACM Digital Library IEEE Xplore arXiv ScienceDirect Scopus",
+        "medicine": "PubMed Embase Cochrane UpToDate CINAHL",
+        "nursing": "CINAHL PubMed nursing allied health",
+        "chemistry": "ACS SciFindern RSC Journals Reaxys",
+        "physics": "APS Journals AIP IOPScience",
+        "business": "Business Source Complete Emerald ProQuest",
+        "dissertations": "ProQuest Dissertations Khazna theses",
+        "theses": "ProQuest Dissertations Khazna theses",
+        "standards": "ASTM Compass IEEE standards ASME ASCE",
     }
     question_lower = question.lower()
     expanded_query = base_query
+    matched_expansions = []
     for term, expansion in SYNONYMS.items():
         if term in question_lower:
-            expanded_query = f"{base_query} {expansion}"
-            print(f"Query expanded with: {expansion[:50]}")
-            break
+            matched_expansions.append(expansion)
+    if matched_expansions:
+        unique_expansions = []
+        seen_exp = set()
+        for exp in matched_expansions:
+            if exp not in seen_exp:
+                seen_exp.add(exp)
+                unique_expansions.append(exp)
+        expanded_query = f"{base_query} {' '.join(unique_expansions[:4])}"
+        print(f"Query expanded with {len(unique_expansions[:4])} glossary hints")
 
     # ── FAISS scored search ──
     docs_with_scores = vectorstore.similarity_search_with_score(expanded_query, k=TOP_K)
@@ -473,7 +549,10 @@ async def tool_library_info(question, history=None, model="gpt"):
   then give the answer.""" if moderate_match else ""
 
     behavior = get_behavior_instructions()
-    prompt = f"""{behavior if behavior else 'You are the Khalifa University Library AI Assistant in Abu Dhabi, UAE. KU means Khalifa University, NOT Kuwait University.'}
+    prompt = f"""{behavior}
+
+You are the Khalifa University Library AI Assistant in Abu Dhabi, UAE.
+KU means Khalifa University, NOT Kuwait University.
 
 RULES — follow exactly:
 1. Answer ONLY using the context provided below.
@@ -778,7 +857,8 @@ async def _answer_general(question: str, history=None) -> dict:
         import openai
         client = openai.OpenAI(api_key=os.environ.get("OPENAI_API_KEY"))
 
-        messages = []
+        behavior = get_behavior_instructions()
+        messages = [{"role": "system", "content": behavior}]
         if history:
             for m in history[-5:]:
                 role = m.get("role", "user")
@@ -787,15 +867,11 @@ async def _answer_general(question: str, history=None) -> dict:
                     messages.append({"role": role, "content": msg_content})
 
         messages.append({"role": "user", "content": question})
-        behavior = get_behavior_instructions()
-        kwargs = {
-            "model": "gpt-4o-mini",
-            "tools": [{"type": "web_search_preview"}],
-            "input": messages,
-        }
-        if behavior:
-            kwargs["instructions"] = behavior
-        response = client.responses.create(**kwargs)
+        response = client.responses.create(
+            model="gpt-4o-mini",
+            tools=[{"type": "web_search_preview"}],
+            input=messages,
+        )
 
         answer = ""
         sources = []
@@ -817,10 +893,7 @@ async def _answer_general(question: str, history=None) -> dict:
         print(f"Web search failed, falling back to plain GPT: {e}")
         try:
             llm = ChatOpenAI(model="gpt-4o-mini", temperature=0.3, max_tokens=500)
-            msgs = []
-            behavior = get_behavior_instructions()
-            if behavior:
-                msgs.append({"role": "system", "content": behavior})
+            msgs = [{"role": "system", "content": get_behavior_instructions()}]
             for m in (history or [])[-5:]:
                 if m.get("role") in ("user", "assistant"):
                     msgs.append({"role": m["role"], "content": m.get("content", "")})
@@ -1041,8 +1114,7 @@ Return JSON like: {{"intent":"general_recent"}}"""
         context_parts.append(f"Natural query for AI tools: {natural_query}")
         context_parts.append(f"Database query for PRIMO/PubMed: {database_query}")
 
-    behavior = get_behavior_instructions()
-    synthesis_prompt = f"""{behavior if behavior else 'You are the Khalifa University Library AI Assistant (Abu Dhabi, UAE). KU = Khalifa University.'}
+    synthesis_prompt = f"""You are the Khalifa University Library AI Assistant (Abu Dhabi, UAE). KU = Khalifa University.
 Be concise (3-5 sentences).
 - For library_info, answer from the library context and include URLs when useful.
 - For search intents, briefly summarise the search direction and mention the top 2-3 relevant results if present.
@@ -1543,4 +1615,4 @@ async def clear_logs():
     conn.execute("DELETE FROM queries")
     conn.commit()
     conn.close()
-    return {"status": "ok", "message": "All logs cleared"}
+    return {"status": "ok", "message": "All logs cleared"}