Update app.py

app.py

@@ -502,45 +502,69 @@ def build_verify_links(name: str, issn: Optional[str], sourceid: str = "") -> di
     }
 
 
-def enrich_ranking(journal: dict, scimago: Optional[dict], oa_pct: Optional[dict]) -> dict:
-    if scimago:
-        q = scimago.get("quartile", "")
-        by_field = scimago.get("quartiles_by_field") or []
-
-        # A journal's "best quartile" is its rank in whichever of its subject
-        # areas flatters it most. 46% of ranked journals rank differently
-        # across their own fields — the Journal of the Medical Library
-        # Association is Q1 in Library and Information Sciences and Q2 in
-        # Health Informatics. Reporting the full list lets the interface show
-        # the quartile that applies to the researcher's actual field.
+def _index_extras(scimago: Optional[dict]) -> dict:
+    """
+    journals.db-only fields, guarded.
+
+    Additive metadata must never be able to fail a request. If anything in
+    here raises, the caller still gets a complete ranking block from the
+    fields that predate the journals.db work. The warning names the journal so
+    a recurring failure is traceable rather than silent.
+    """
+    if not scimago:
+        return {}
+    try:
+        return {
+            "quartiles_by_field": scimago.get("quartiles_by_field") or [],
+            "sjr":                scimago.get("sjr"),
+            "indexation_state":   scimago.get("state"),
+            "indexation_message": scimago.get("state_message"),
+            "warn":               bool(scimago.get("warn")),
+            "currently_indexed":  scimago.get("currently_indexed", True),
+            "successor_title":    scimago.get("successor_title"),
+            "oa_diamond":         bool(scimago.get("oa_diamond")),
+            "from_scopus":        bool(scimago.get("from_scopus")),
+            "from_scimago":       bool(scimago.get("from_scimago", True)),
+        }
+    except Exception as e:                                    # noqa: BLE001
+        logger.warning("[JournalIndex] extras failed for %r: %s: %s",
+                       (scimago or {}).get("title", "?"), type(e).__name__, e)
+        return {}
+
+
+def _quartile_interpretation(scimago: Optional[dict]) -> str:
+    """
+    Per-field quartile sentence, guarded, with the original wording as the
+    fallback. 46% of ranked journals rank differently across their own subject
+    areas, so the spread is worth showing — but never at the cost of the call.
+    """
+    try:
+        by_field = (scimago or {}).get("quartiles_by_field") or []
         if len(by_field) > 1:
             spread = ", ".join(f"{f['quartile']} in {f['field']}" for f in by_field)
-            interp = f"Quartile varies by subject area: {spread}."
-        else:
-            interp = (f"Quartile verified from journal metadata "
-                      f"(2025 dataset, matched by ISSN {scimago.get('matched_issn', '')}).")
+            return f"Quartile varies by subject area: {spread}."
+    except Exception as e:                                    # noqa: BLE001
+        logger.warning("[JournalIndex] quartile spread failed: %s", e)
+    return (f"Quartile verified from journal metadata "
+            f"(2025 dataset, matched by ISSN {(scimago or {}).get('matched_issn', '')}).")
 
-        return {
+
+def enrich_ranking(journal: dict, scimago: Optional[dict], oa_pct: Optional[dict]) -> dict:
+    if scimago:
+        q = scimago.get("quartile", "")
+        out = {
             "requested": True, "source": "Verified from journal data", "year": "2025",
             "category": scimago.get("categories", ""), "metric_value": None,
             "percentile": f"Rank #{scimago.get('rank', '—')} globally" if scimago.get("rank") else None,
             "quartile": q if q and q != "-" else None,
-            "interpretation": interp,
+            "interpretation": _quartile_interpretation(scimago),
             "verification_status": "Confirmed", "h_index": scimago.get("h_index"),
-
-            # From journals.db. Absent when the CSV fallback served this
-            # lookup, so every reader must tolerate None/False.
-            "quartiles_by_field":  by_field,
-            "sjr":                 scimago.get("sjr"),
-            "indexation_state":    scimago.get("state"),
-            "indexation_message":  scimago.get("state_message"),
-            "warn":                bool(scimago.get("warn")),
-            "currently_indexed":   scimago.get("currently_indexed", True),
-            "successor_title":     scimago.get("successor_title"),
-            "oa_diamond":          bool(scimago.get("oa_diamond")),
-            "from_scopus":         bool(scimago.get("from_scopus")),
-            "from_scimago":        bool(scimago.get("from_scimago", True)),
         }
+        # journals.db extras are merged in, never inlined. If the index or its
+        # shape misbehaves the response is still complete and correct — the
+        # caller simply does not get the extra keys.
+        out.update(_index_extras(scimago))
+        return out
     elif oa_pct:
         return {
             "requested": True, "source": "OpenAlex-derived percentile", "year": "2025",
@@ -635,12 +659,10 @@ def enrich_extended(extended: list) -> list:
         # It is deliberately False for the 6,855 that were merely renamed:
         # telling a researcher that a journal which changed its name is a
         # quality risk is worse than saying nothing at all.
-        j["warn"]               = bool((scimago or {}).get("warn"))
-        j["indexation_state"]   = (scimago or {}).get("state")
-        j["indexation_message"] = (scimago or {}).get("state_message")
-        j["successor_title"]    = (scimago or {}).get("successor_title")
-        j["oa_diamond"]         = bool((scimago or {}).get("oa_diamond"))
-        j["quartiles_by_field"] = (scimago or {}).get("quartiles_by_field") or []
+        #
+        # Merged through the guarded helper for the same reason as above: a
+        # quick-match row must not be able to fail the whole request.
+        j.update(_index_extras(scimago))
 
         j["verify_links"]  = build_verify_links(j.get("name", ""), issn, sourceid)
         j["ku_apc_covered"] = is_ku_apc_covered(publisher, q)