fix the issues in the deleting kb

backend/api/mcp_clients/rag_client.py

@@ -177,16 +177,29 @@ class RAGClient:
             print("RAG List Error:", e)
             return {"documents": [], "total": 0, "limit": limit, "offset": offset}
 
-    async def delete_document(self, tenant_id: str, document_id: int):
+    async def delete_document(self, tenant_id: str, document_id: int, user_role: Optional[str] = None):
         """
         Delete a specific document by ID for a tenant.
         Returns the unwrapped data from the MCP server response.
+        
+        Args:
+            tenant_id: Tenant identifier
+            document_id: Document ID to delete
+            user_role: User role (viewer, editor, admin, owner) - required for permission checks
         """
         try:
             async with httpx.AsyncClient(timeout=30.0) as client:
-                response = await client.delete(
-                    f"{self.base_url}/delete/{document_id}",
-                    params={"tenant_id": tenant_id}
+                # Use POST with JSON payload to include role for MCP protocol
+                payload = {
+                    "tenant_id": tenant_id,
+                    "document_id": document_id
+                }
+                if user_role:
+                    payload["user_role"] = user_role
+                
+                response = await client.post(
+                    f"{self.base_url}/delete",
+                    json=payload
                 )
 
             if response.status_code == 404:
@@ -205,6 +218,13 @@ class RAGClient:
             # Check if MCP server returned an error response
             if isinstance(data, dict) and data.get("status") == "error":
                 error_msg = data.get("message", "Unknown error")
+                error_type = data.get("error_type", "unknown_error")
+                # For validation errors (like "not found"), return clear error message
+                if error_type == "validation_error":
+                    if "not found" in error_msg.lower():
+                        return {"error": f"Document {document_id} not found for tenant '{tenant_id}'"}
+                    elif "access denied" in error_msg.lower() or "permission" in error_msg.lower():
+                        return {"error": f"Access denied: {error_msg}"}
                 return {"error": error_msg}
             
             # MCP server wraps response in a 'data' field
@@ -222,16 +242,28 @@ class RAGClient:
             print(f"RAG Delete Error: {e}")
             return {"error": str(e)}
 
-    async def delete_all_documents(self, tenant_id: str):
+    async def delete_all_documents(self, tenant_id: str, user_role: Optional[str] = None):
         """
         Delete all documents for a tenant.
         Returns the unwrapped data from the MCP server response.
+        
+        Args:
+            tenant_id: Tenant identifier
+            user_role: User role (viewer, editor, admin, owner) - required for permission checks
         """
         try:
             async with httpx.AsyncClient(timeout=30.0) as client:
-                response = await client.delete(
+                # Use POST with JSON payload to include role for MCP protocol
+                payload = {
+                    "tenant_id": tenant_id,
+                    "delete_all": True
+                }
+                if user_role:
+                    payload["user_role"] = user_role
+                
+                response = await client.post(
                     f"{self.base_url}/delete-all",
-                    params={"tenant_id": tenant_id}
+                    json=payload
                 )
 
             if response.status_code != 200:

backend/api/routes/rag.py

@@ -389,7 +389,7 @@ async def rag_delete(
     require_api_permission(x_user_role, "delete_documents")
 
     try:
-        result = await rag_client.delete_document(x_tenant_id, document_id)
+        result = await rag_client.delete_document(x_tenant_id, document_id, user_role=x_user_role)
         if "error" in result:
             # Check if it's a connection error (500) or not found (404)
             error_msg = result["error"]
@@ -419,7 +419,7 @@ async def rag_delete_all(
     require_api_permission(x_user_role, "delete_documents")
 
     try:
-        result = await rag_client.delete_all_documents(x_tenant_id)
+        result = await rag_client.delete_all_documents(x_tenant_id, user_role=x_user_role)
         if "error" in result:
             error_msg = result["error"]
             # Check if it's a connection error (503) or other error