Spaces:
Running
Running
File size: 10,020 Bytes
715e36f | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 | from __future__ import annotations
import sys
import json
import importlib
from types import ModuleType
from pathlib import Path
from unittest.mock import AsyncMock
import pytest
import reachy_cook.config as config_mod
import reachy_cook.tool_spaces as tool_spaces_mod
from reachy_cook.mcp_client import McpToolTimeoutError, McpToolInvocationError
from reachy_cook.tool_spaces import (
InstalledToolSpace,
InstalledToolSpaceTool,
InstalledToolSpacesManifest,
write_installed_tool_spaces,
)
SEARCH_SPACE_SLUG = "example/search-tool"
SEARCH_ALIAS = "example_search_tool"
SEARCH_TOOL_ID = f"{SEARCH_ALIAS}__search_web"
SEARCH_CLIENT_TOOL_ID = f"{SEARCH_ALIAS}__search_tool_search_web"
SEARCH_MCP_URL = "https://example-search-tool.hf.space/gradio_api/mcp/"
def _reload_core_tools() -> ModuleType:
for module_name in list(sys.modules):
if module_name.startswith("reachy_cook.tools."):
sys.modules.pop(module_name, None)
sys.modules.pop("reachy_cook.tools.core_tools", None)
return importlib.import_module("reachy_cook.tools.core_tools")
def _installed_search_space() -> InstalledToolSpace:
return InstalledToolSpace(
slug=SEARCH_SPACE_SLUG,
alias=SEARCH_ALIAS,
mcp_url=SEARCH_MCP_URL,
private=False,
tools=[
InstalledToolSpaceTool(
local_name=SEARCH_TOOL_ID,
client_tool_name=SEARCH_CLIENT_TOOL_ID,
remote_name="search_tool_search_web",
description="Search the web",
parameters_schema={
"type": "object",
"properties": {"query": {"type": "string"}},
"required": ["query"],
},
)
],
)
@pytest.mark.asyncio
async def test_initialize_tools_loads_enabled_installed_remote_tools_and_dispatches(
tmp_path: Path,
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Enabled public Space tools should join the registry and dispatch through the normal path."""
monkeypatch.chdir(tmp_path)
external_profiles_root = tmp_path / "external_profiles"
profile_dir = external_profiles_root / "mcp_profile"
profile_dir.mkdir(parents=True)
(profile_dir / "instructions.txt").write_text("hello\n", encoding="utf-8")
(profile_dir / "tools.txt").write_text(f"{SEARCH_TOOL_ID}\n", encoding="utf-8")
monkeypatch.setattr(config_mod.config, "REACHY_MINI_CUSTOM_PROFILE", "mcp_profile")
monkeypatch.setattr(config_mod.config, "PROFILES_DIRECTORY", external_profiles_root)
monkeypatch.setattr(config_mod.config, "TOOLS_DIRECTORY", None)
monkeypatch.setattr(config_mod.config, "AUTOLOAD_EXTERNAL_TOOLS", False)
client = AsyncMock()
client.call_tool.return_value = {
"status": "ok",
"server_alias": SEARCH_ALIAS,
"remote_tool_name": "reachy_mini_search_tool_search_web",
"namespaced_tool_name": SEARCH_CLIENT_TOOL_ID,
"content_blocks": [],
"text": "hello",
}
captured_cached_tools: list[InstalledToolSpaceTool] | None = None
def _build_remote_client(
alias: str,
mcp_url: str,
*,
private: bool,
cached_tools: list[InstalledToolSpaceTool],
) -> AsyncMock:
nonlocal captured_cached_tools
assert alias == SEARCH_ALIAS
assert mcp_url == SEARCH_MCP_URL
assert private is False
captured_cached_tools = cached_tools
return client
monkeypatch.setattr(tool_spaces_mod, "build_remote_client", _build_remote_client)
write_installed_tool_spaces(
None,
InstalledToolSpacesManifest(spaces=[_installed_search_space()]),
)
core_tools_mod = _reload_core_tools()
core_tools_mod.initialize_tools()
assert SEARCH_TOOL_ID in core_tools_mod.ALL_TOOLS
assert captured_cached_tools == _installed_search_space().tools
tool_specs = core_tools_mod.get_tool_specs()
assert any(spec["name"] == SEARCH_TOOL_ID for spec in tool_specs)
result = await core_tools_mod.dispatch_tool_call(
SEARCH_TOOL_ID,
json.dumps({"query": "hello"}),
core_tools_mod.ToolDependencies(
reachy_mini=object(),
movement_manager=object(),
),
)
assert result["namespaced_tool_name"] == SEARCH_TOOL_ID
assert result["tool_space_slug"] == SEARCH_SPACE_SLUG
client.call_tool.assert_awaited_once_with(SEARCH_CLIENT_TOOL_ID, {"query": "hello"})
def test_initialize_tools_warns_when_enabled_tool_missing_from_manifest(
tmp_path: Path,
monkeypatch: pytest.MonkeyPatch,
caplog: pytest.LogCaptureFixture,
) -> None:
"""A tool enabled in the profile but absent from the cached manifest is skipped with a warning."""
monkeypatch.chdir(tmp_path)
external_profiles_root = tmp_path / "external_profiles"
profile_dir = external_profiles_root / "remote_profile"
profile_dir.mkdir(parents=True)
(profile_dir / "instructions.txt").write_text("hello\n", encoding="utf-8")
(profile_dir / "tools.txt").write_text(f"{SEARCH_TOOL_ID}\n", encoding="utf-8")
monkeypatch.setattr(config_mod.config, "REACHY_MINI_CUSTOM_PROFILE", "remote_profile")
monkeypatch.setattr(config_mod.config, "PROFILES_DIRECTORY", external_profiles_root)
monkeypatch.setattr(config_mod.config, "TOOLS_DIRECTORY", None)
monkeypatch.setattr(config_mod.config, "AUTOLOAD_EXTERNAL_TOOLS", False)
write_installed_tool_spaces(
None,
InstalledToolSpacesManifest(
spaces=[
InstalledToolSpace(
slug=SEARCH_SPACE_SLUG,
alias=SEARCH_ALIAS,
mcp_url=SEARCH_MCP_URL,
private=False,
),
]
),
)
core_tools_mod = _reload_core_tools()
with caplog.at_level("WARNING"):
core_tools_mod.initialize_tools()
assert any(SEARCH_SPACE_SLUG in record.message for record in caplog.records)
assert SEARCH_TOOL_ID not in core_tools_mod.ALL_TOOLS
def test_initialize_tools_inherits_default_tools_txt_for_profile_without_local_tool_list(
tmp_path: Path,
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Profiles without a local tools.txt should inherit the built-in default tool set."""
external_profiles_root = tmp_path / "external_profiles"
profile_dir = external_profiles_root / "inherit_default"
profile_dir.mkdir(parents=True)
(profile_dir / "instructions.txt").write_text("hello\n", encoding="utf-8")
monkeypatch.setattr(config_mod.config, "REACHY_MINI_CUSTOM_PROFILE", "inherit_default")
monkeypatch.setattr(config_mod.config, "PROFILES_DIRECTORY", external_profiles_root)
monkeypatch.setattr(config_mod.config, "TOOLS_DIRECTORY", None)
monkeypatch.setattr(config_mod.config, "AUTOLOAD_EXTERNAL_TOOLS", False)
core_tools_mod = _reload_core_tools()
core_tools_mod.initialize_tools()
assert "dance" in core_tools_mod.ALL_TOOLS
def _mcp_profile(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
external_profiles_root = tmp_path / "external_profiles"
profile_dir = external_profiles_root / "mcp_profile"
profile_dir.mkdir(parents=True)
(profile_dir / "instructions.txt").write_text("hello\n", encoding="utf-8")
(profile_dir / "tools.txt").write_text(f"{SEARCH_TOOL_ID}\n", encoding="utf-8")
monkeypatch.setattr(config_mod.config, "REACHY_MINI_CUSTOM_PROFILE", "mcp_profile")
monkeypatch.setattr(config_mod.config, "PROFILES_DIRECTORY", external_profiles_root)
monkeypatch.setattr(config_mod.config, "TOOLS_DIRECTORY", None)
monkeypatch.setattr(config_mod.config, "AUTOLOAD_EXTERNAL_TOOLS", False)
@pytest.mark.asyncio
async def test_remote_tool_retries_once_after_transport_failure(
tmp_path: Path,
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Transient remote transport failures should get one fast retry."""
monkeypatch.chdir(tmp_path)
_mcp_profile(tmp_path, monkeypatch)
client = AsyncMock()
client.call_tool.side_effect = [
McpToolInvocationError("connection reset"),
{
"status": "ok",
"server_alias": SEARCH_ALIAS,
"remote_tool_name": "reachy_mini_search_tool_search_web",
"namespaced_tool_name": SEARCH_CLIENT_TOOL_ID,
"content_blocks": [],
"text": "hello",
},
]
monkeypatch.setattr(tool_spaces_mod, "build_remote_client", lambda *a, **k: client)
write_installed_tool_spaces(None, InstalledToolSpacesManifest(spaces=[_installed_search_space()]))
core_tools_mod = _reload_core_tools()
monkeypatch.setattr(core_tools_mod, "_REMOTE_TOOL_RETRY_DELAY_S", 0.0)
core_tools_mod.initialize_tools()
result = await core_tools_mod.dispatch_tool_call(
SEARCH_TOOL_ID,
json.dumps({"query": "hello"}),
core_tools_mod.ToolDependencies(reachy_mini=object(), movement_manager=object()),
)
assert result["status"] == "ok"
assert client.call_tool.await_count == 2
@pytest.mark.asyncio
async def test_remote_tool_does_not_retry_timeout(
tmp_path: Path,
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Remote timeouts should fail once instead of doubling the user wait."""
monkeypatch.chdir(tmp_path)
_mcp_profile(tmp_path, monkeypatch)
client = AsyncMock()
client.call_tool.side_effect = McpToolTimeoutError("slow tool")
monkeypatch.setattr(tool_spaces_mod, "build_remote_client", lambda *a, **k: client)
write_installed_tool_spaces(None, InstalledToolSpacesManifest(spaces=[_installed_search_space()]))
core_tools_mod = _reload_core_tools()
core_tools_mod.initialize_tools()
result = await core_tools_mod.dispatch_tool_call(
SEARCH_TOOL_ID,
json.dumps({"query": "hello"}),
core_tools_mod.ToolDependencies(reachy_mini=object(), movement_manager=object()),
)
assert "error" in result
assert client.call_tool.await_count == 1
|