Fix video_service.py

app/services/video_service.py

@@ -1,34 +1,14 @@
-# app/services/video_service.py
-
-import os
-import uuid
-import requests
+import os, uuid, requests
 from gtts import gTTS
 from mutagen.mp3 import MP3
 from moviepy.editor import ImageClip, concatenate_videoclips, AudioFileClip
-from dotenv import load_dotenv
-
-load_dotenv()
-
-UNSPLASH_KEY = os.getenv("UNSPLASH_ACCESS_KEY")
-UNSPLASH_API = "https://api.unsplash.com/photos/random"
+from moviepy.config import change_settings
 
-def fetch_unsplash_images(query, count=3):
-    headers = {"Accept-Version": "v1", "Authorization": f"Client-ID {UNSPLASH_KEY}"}
-    urls = []
-
-    for _ in range(count):
-        r = requests.get(UNSPLASH_API, params={"query": query}, headers=headers)
-        if r.status_code == 200:
-            data = r.json()
-            if isinstance(data, dict):
-                urls.append(data["urls"]["regular"])
-            elif isinstance(data, list) and len(data) > 0:
-                urls.append(data[0]["urls"]["regular"])
-    return urls
+# ✅ Force MoviePy temp directory to /tmp
+change_settings({"FFMPEG_BINARY": "ffmpeg"})
+os.environ["TMPDIR"] = "/tmp"
 
 def generate_video_file(script: str, duration: int = None) -> str:
-    # ✅ Use /tmp for Hugging Face Spaces
     base_tmp = "/tmp/video"
     audio_tmp = "/tmp/audio"
     tmp_images = "/tmp/video_tmp"
@@ -41,7 +21,7 @@ def generate_video_file(script: str, duration: int = None) -> str:
     video_path = os.path.join(base_tmp, video_filename)
     audio_path = os.path.join(audio_tmp, f"audio_{uuid.uuid4().hex}.mp3")
 
-    # Step 1: Generate audio
+    # Step 1: Generate TTS audio
     tts = gTTS(text=script, lang='en')
     tts.save(audio_path)
 
@@ -54,25 +34,24 @@ def generate_video_file(script: str, duration: int = None) -> str:
     if not images:
         raise Exception("No images found from Unsplash for the prompt")
 
-    clips = []
+    clips, tmp_files = [], []
     per_image_duration = audio_duration / len(images)
-    tmp_files = []
 
     for url in images:
         img_data = requests.get(url).content
         tmp_file = os.path.join(tmp_images, f"tmp_{uuid.uuid4().hex}.jpg")
         tmp_files.append(tmp_file)
-
         with open(tmp_file, "wb") as f:
             f.write(img_data)
 
         clip = ImageClip(tmp_file).resize(height=720).set_duration(per_image_duration)
         clips.append(clip)
 
+    # Step 4: Build final video
     final_clip = concatenate_videoclips(clips, method="compose").set_duration(audio_duration)
     final_clip = final_clip.set_audio(AudioFileClip(audio_path))
 
-    # ✅ Use /tmp temp audio to avoid "generated" folder
+    # ✅ Step 5: Export video with all temp files in /tmp
     final_clip.write_videofile(
         video_path,
         fps=24,
@@ -81,10 +60,11 @@ def generate_video_file(script: str, duration: int = None) -> str:
         threads=4,
         preset="ultrafast",
         temp_audiofile="/tmp/temp-audio.m4a",
-        remove_temp=True
+        remove_temp=True,
+        ffmpeg_params=["-avoid_negative_ts", "make_zero"]
     )
 
-    # Cleanup
+    # Cleanup images
     for file in tmp_files:
         try:
             os.remove(file)