not counting bozos

app.py

@@ -95,34 +95,35 @@ async def analyze_selected_achievements(request_data: AnalyzeAchievementsRequest
     print(f"Fetching achievement status for {len(selected_characters)} selected characters...")
     for char_name in selected_characters:
         print(f"  Fetching data for: {char_name}...")
-        # Util.api.get_char_achievements returns a list on success, or a dict with 'error':True on failure.
-        # If it fails, it should still contain an 'achievements_list' key with the default (all incomplete) data.
         ach_status_result = blizzard_api.get_char_achievements(ACCESS_TOKEN, realm_slug, char_name)
         
         if isinstance(ach_status_result, dict) and ach_status_result.get('error'):
             print(f"    Warning/Error for {char_name}: {ach_status_result.get('message', 'Unknown error')}")
             errored_character_names.append(char_name)
-            # Ensure we still get the list of achievements (marked as incomplete)
-            if 'achievements_list' in ach_status_result and isinstance(ach_status_result['achievements_list'], list):
-                ach_data_by_character[char_name] = ach_status_result['achievements_list']
-            else:
-                # This case should ideally not happen if get_char_achievements is consistent
-                # but as a fallback, create an empty list for this char to avoid breaking later logic,
-                # though they won't contribute to completion stats correctly.
-                print(f"    Critical: No 'achievements_list' in error response for {char_name}. They will have no data.")
-                ach_data_by_character[char_name] = [] 
+            # DO NOT add this character's data to ach_data_by_character
+            # as per new requirement to exclude them from calculations.
         elif isinstance(ach_status_result, list): # Successful fetch
             ach_data_by_character[char_name] = ach_status_result
         else:
             # Unexpected format from get_char_achievements
             print(f"    Error: Unexpected data format received for {char_name}. Skipping.")
             errored_character_names.append(char_name) # Also count as errored
-            ach_data_by_character[char_name] = [] # Provide empty list
-
-    if not ach_data_by_character: # If, after all attempts, no character data was collected
-        return {"error": "No valid achievement data could be collected for any of the selected characters.", "summary": None, "errored_characters": errored_character_names}
-
-    print(f"\nCalculating achievement completion percentages for {len(ach_data_by_character)} character(s) processed...")
+            # DO NOT add to ach_data_by_character here either
+
+    # If all selected characters resulted in an error, ach_data_by_character might be empty.
+    # The frontend will show the errored_character_names. 
+    # If ach_data_by_character is empty, calculate_achievement_completion_percentages will likely return empty or handle it.
+
+    if not ach_data_by_character and errored_character_names:
+        # This means all selected characters had errors, but we have the list of who errored.
+        # Return the list of errored characters, but summary will be empty/None.
+        print("All selected characters resulted in API errors. No data to summarize.")
+        return {"error": "Could not retrieve achievement data for any selected character.", "summary": [], "errored_characters": errored_character_names}
+    elif not ach_data_by_character:
+        # This case means no characters were selected initially or some other edge case where both are empty.
+        return {"error": "No valid achievement data could be collected (no characters processed or all failed without specific error tracking).", "summary": None, "errored_characters": errored_character_names}
+
+    print(f"\nCalculating achievement completion percentages for {len(ach_data_by_character)} successfully processed character(s)...")
     completion_summary = blizzard_api.calculate_achievement_completion_percentages(ach_data_by_character)
 
     if not completion_summary and not errored_character_names: # If summary is empty AND no specific char errors were reported

requirements.txt

@@ -4,3 +4,4 @@ requests
 python-dotenv
 jinja2
 pandas
+pydantic

templates/index.html

@@ -219,7 +219,7 @@
 </head>
 <body>
     <div class="container">
-        <h1 class="shit">faygan's shitty achievo tracker</h1>
+        <h1 class="shit">faygan's shitty group achievo tracker</h1>
 
         <div class="form-row">
             <div class="form-group col-md-6">
@@ -501,7 +501,7 @@
                 // Display character-specific API errors if any
                 if (data.errored_characters && Array.isArray(data.errored_characters) && data.errored_characters.length > 0) {
                     const erroredNames = data.errored_characters.map(name => escapeHtml(name)).join(', ');
-                    charApiErrorsDiv.innerHTML = `<p><strong>hey:</strong> Ci coudn't find data for: ${erroredNames}. They're being excluded from the selection because it's easier .¯\_(ツ)_/¯</p>`;
+                    charApiErrorsDiv.innerHTML = `<p><strong>Oops:</strong> I coudn't find data for: ${erroredNames}. They're being excluded from the selection because it's easier .¯\_(ツ)_/¯</p>`;
                     charApiErrorsDiv.style.display = 'block';
                 } else {
                     charApiErrorsDiv.style.display = 'none';