File size: 7,781 Bytes
c6d0b05
a64c042
b8f6023
c6d0b05
 
a64c042
c6d0b05
 
 
a64c042
 
b8f6023
a64c042
 
 
5d06dbc
c6d0b05
 
 
5d06dbc
c6d0b05
 
 
 
 
 
5d06dbc
c6d0b05
 
 
5d06dbc
c6d0b05
 
 
 
 
 
 
 
 
5d06dbc
c6d0b05
 
 
 
 
 
 
 
5d06dbc
c6d0b05
 
5d06dbc
 
c6d0b05
 
 
5d06dbc
c6d0b05
 
 
 
 
 
 
 
 
 
 
5d06dbc
c6d0b05
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
5d06dbc
c6d0b05
 
5d06dbc
 
c6d0b05
5d06dbc
c6d0b05
 
 
 
 
 
 
 
 
b8f6023
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
c6d0b05
5d06dbc
c6d0b05
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
5d06dbc
c6d0b05
 
5d06dbc
c6d0b05
5d06dbc
c6d0b05
 
 
 
 
 
5d06dbc
c6d0b05
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
5d06dbc
c6d0b05
 
 
5d06dbc
c6d0b05
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
from unittest.mock import MagicMock

from langchain_core.messages import AIMessage, HumanMessage, ToolMessage

from multi_agent_sdlc.agents.coder import node as coder_module
from multi_agent_sdlc.agents.coder.models import CoderSummary
from multi_agent_sdlc.agents.coder.node import (
    MAX_CONSECUTIVE_CODER_INVALID_RESPONSES,
)
from multi_agent_sdlc.agents.coder.prompt import (
    CODER_INVALID_RESPONSE_FEEDBACK,
    CODER_INVALID_SUMMARY_FEEDBACK,
    CODER_SUBMIT_SUMMARY_WITH_OTHER_TOOLS_FEEDBACK,
)
from multi_agent_sdlc.workflow.models import DevelopmentStatus
from multi_agent_sdlc.workflow.state import DevState


def test_coder_node_increments_invalid_response_count(
    dev_state: DevState,
) -> None:
    response = AIMessage(content="I have completed the implementation.")

    mock_llm = MagicMock()
    mock_llm.invoke.return_value = response

    dev_state["coder_messages"] = [
        HumanMessage(content="Implement the application.")
    ]

    result = coder_module.coder_node(dev_state, mock_llm)

    assert result["coder_invalid_response_count"] == 1
    messages = result["coder_messages"]
    assert isinstance(messages, list)
    assert messages[1].content == CODER_INVALID_RESPONSE_FEEDBACK
    mock_llm.invoke.assert_called_once()


def test_coder_node_fails_after_max_invalid_responses(
    dev_state: DevState,
) -> None:
    response = AIMessage(
        content="The implementation is complete.",
    )

    mock_llm = MagicMock()
    mock_llm.invoke.return_value = response

    dev_state["coder_messages"] = [
        HumanMessage(content="Implement the application."),
    ]
    dev_state["development_status"] = DevelopmentStatus.IMPLEMENTING
    dev_state["coder_invalid_response_count"] = (
        MAX_CONSECUTIVE_CODER_INVALID_RESPONSES - 1
    )

    result = coder_module.coder_node(dev_state, mock_llm)

    assert (
        result["coder_invalid_response_count"]
        == MAX_CONSECUTIVE_CODER_INVALID_RESPONSES
    )
    assert result["development_status"] == DevelopmentStatus.FAILED

    mock_llm.invoke.assert_called_once()


def test_coder_node_accepts_summary_called_alone(
    dev_state: DevState,
    coder_summary: CoderSummary,
) -> None:
    response = AIMessage(
        content="",
        tool_calls=[
            {
                "name": "submit_coder_summary",
                "args": {
                    "summary": coder_summary.model_dump(),
                },
                "id": "call-1",
                "type": "tool_call",
            }
        ],
    )

    mock_llm = MagicMock()
    mock_llm.invoke.return_value = response

    dev_state["coder_messages"] = [
        HumanMessage(content="Implement the application."),
    ]
    dev_state["development_status"] = DevelopmentStatus.IMPLEMENTING
    dev_state["coder_invalid_response_count"] = 1

    result = coder_module.coder_node(dev_state, mock_llm)

    assert result["development_status"] == DevelopmentStatus.COMPLETED
    assert result["current_coder_summary"] == coder_summary
    assert result["coder_invalid_response_count"] == 0
    assert result["coder_messages"] == [response]

    mock_llm.invoke.assert_called_once()


def test_coder_node_returns_validation_feedback_for_invalid_summary(
    dev_state: DevState,
    coder_summary: CoderSummary,
) -> None:
    summary = coder_summary.model_dump()
    summary["unexpected_field"] = "unexpected value"
    response = AIMessage(
        content="",
        tool_calls=[
            {
                "name": "submit_coder_summary",
                "args": {"summary": summary},
                "id": "call-1",
                "type": "tool_call",
            }
        ],
    )
    mock_llm = MagicMock()
    mock_llm.invoke.return_value = response
    dev_state["coder_messages"] = [
        HumanMessage(content="Implement the application."),
    ]

    result = coder_module.coder_node(dev_state, mock_llm)

    assert result["coder_invalid_response_count"] == 1
    messages = result["coder_messages"]
    assert isinstance(messages, list)
    assert messages[0] == response
    assert isinstance(messages[1], ToolMessage)
    assert messages[1].tool_call_id == "call-1"
    assert messages[1].status == "error"
    assert CODER_INVALID_SUMMARY_FEEDBACK in messages[1].content
    assert "unexpected_field" in messages[1].content


def test_coder_node_fails_after_max_invalid_summaries(
    dev_state: DevState,
    coder_summary: CoderSummary,
) -> None:
    summary = coder_summary.model_dump()
    summary["unexpected_field"] = "unexpected value"
    response = AIMessage(
        content="",
        tool_calls=[
            {
                "name": "submit_coder_summary",
                "args": {"summary": summary},
                "id": "call-1",
                "type": "tool_call",
            }
        ],
    )
    mock_llm = MagicMock()
    mock_llm.invoke.return_value = response
    dev_state["coder_messages"] = [
        HumanMessage(content="Implement the application."),
    ]
    dev_state["development_status"] = DevelopmentStatus.IMPLEMENTING
    dev_state["coder_invalid_response_count"] = (
        MAX_CONSECUTIVE_CODER_INVALID_RESPONSES - 1
    )

    result = coder_module.coder_node(dev_state, mock_llm)

    assert (
        result["coder_invalid_response_count"]
        == MAX_CONSECUTIVE_CODER_INVALID_RESPONSES
    )
    assert result["development_status"] == DevelopmentStatus.FAILED


def test_coder_node_accepts_multiple_operational_tool_calls(
    dev_state: DevState,
) -> None:
    response = AIMessage(
        content="",
        tool_calls=[
            {
                "name": "coder_write_file",
                "args": {
                    "path": "src/main.py",
                    "content": "print('hello')",
                },
                "id": "call-1",
                "type": "tool_call",
            },
            {
                "name": "coder_write_file",
                "args": {
                    "path": "src/config.py",
                    "content": "DEBUG = False",
                },
                "id": "call-2",
                "type": "tool_call",
            },
        ],
    )

    mock_llm = MagicMock()
    mock_llm.invoke.return_value = response

    dev_state["coder_messages"] = [
        HumanMessage(content="Implement the application."),
    ]
    dev_state["coder_invalid_response_count"] = 1

    result = coder_module.coder_node(dev_state, mock_llm)

    assert result["coder_messages"] == [response]
    assert result["coder_invalid_response_count"] == 0


def test_coder_node_rejects_summary_with_other_tool_call(
    dev_state: DevState,
    coder_summary: CoderSummary,
) -> None:
    response = AIMessage(
        content="",
        tool_calls=[
            {
                "name": "submit_coder_summary",
                "args": {
                    "summary": coder_summary.model_dump(),
                },
                "id": "call-1",
                "type": "tool_call",
            },
            {
                "name": "coder_write_file",
                "args": {
                    "path": "src/main.py",
                    "content": "print('hello')",
                },
                "id": "call-2",
                "type": "tool_call",
            },
        ],
    )

    mock_llm = MagicMock()
    mock_llm.invoke.return_value = response

    dev_state["coder_messages"] = [
        HumanMessage(content="Implement the application."),
    ]

    result = coder_module.coder_node(dev_state, mock_llm)

    assert result["coder_invalid_response_count"] == 1

    messages = result["coder_messages"]
    assert isinstance(messages, list)
    assert messages[0] == response
    assert messages[1].content == CODER_SUBMIT_SUMMARY_WITH_OTHER_TOOLS_FEEDBACK