Spaces:
Paused
Paused
File size: 11,423 Bytes
a5784e9 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 | from unittest.mock import AsyncMock, MagicMock, patch
import pytest
from api_utils.routers.models import list_models
from config import DEFAULT_FALLBACK_MODEL_ID
@pytest.mark.asyncio
async def test_list_models_success(mock_env):
# Mock dependencies
logger = MagicMock()
model_list_fetch_event = MagicMock()
model_list_fetch_event.is_set.return_value = True
page_instance = AsyncMock()
page_instance.is_closed.return_value = False
parsed_model_list = [
{"id": "gemini-1.5-pro", "object": "model"},
{"id": "gemini-1.5-flash", "object": "model"},
]
excluded_model_ids = {"gemini-1.5-flash"}
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
assert response["object"] == "list"
assert len(response["data"]) == 1
assert response["data"][0]["id"] == "gemini-1.5-pro"
@pytest.mark.asyncio
async def test_list_models_fallback(mock_env):
logger = MagicMock()
model_list_fetch_event = MagicMock()
model_list_fetch_event.is_set.return_value = True
page_instance = AsyncMock()
parsed_model_list = [] # Empty list
excluded_model_ids = set()
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
assert response["object"] == "list"
assert len(response["data"]) == 1
assert response["data"][0]["id"] == DEFAULT_FALLBACK_MODEL_ID
@pytest.mark.asyncio
async def test_list_models_fetch_timeout(mock_env):
logger = MagicMock()
model_list_fetch_event = AsyncMock()
model_list_fetch_event.is_set.return_value = False
# Simulate wait timeout
model_list_fetch_event.wait.side_effect = TimeoutError("Timeout")
page_instance = AsyncMock()
page_instance.is_closed.return_value = False
parsed_model_list = []
excluded_model_ids = set()
# Should handle exception gracefully and return fallback
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
assert response["object"] == "list"
assert len(response["data"]) == 1
assert response["data"][0]["id"] == DEFAULT_FALLBACK_MODEL_ID
"""
Extended tests for api_utils/routers/models.py - Edge case coverage.
Focus: Cover uncovered lines in model refresh logic (35-43).
Strategy: Test page reload scenarios, event waiting, exception handling.
"""
import asyncio
@pytest.mark.asyncio
async def test_list_models_event_not_set_reload_success(mock_env):
"""
Test scenario: Model list event not set, page reload success
Expected: Execute reload and wait_for, cover lines 35-38
"""
logger = MagicMock()
model_list_fetch_event = MagicMock(spec=asyncio.Event)
model_list_fetch_event.is_set.return_value = False
# Use MagicMock for page, only reload is async
page_instance = MagicMock()
page_instance.is_closed.return_value = False
page_instance.reload = AsyncMock()
# Mock wait() finishes successfully inside wait_for
async def mock_wait():
# Simulate successful wait
model_list_fetch_event.is_set.return_value = True
return
model_list_fetch_event.wait = mock_wait
parsed_model_list = [{"id": "gemini-1.5-pro", "object": "model"}]
excluded_model_ids = set()
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
# Verify: Page reloaded
page_instance.reload.assert_called_once()
# Verify: Return model list
assert response["object"] == "list"
assert len(response["data"]) == 1
@pytest.mark.asyncio
async def test_list_models_reload_timeout(mock_env):
"""
Test scenario: wait_for timeout, triggers except and finally
Expected: Catch exception, log error, set event (lines 38-43)
"""
logger = MagicMock()
model_list_fetch_event = MagicMock(spec=asyncio.Event)
model_list_fetch_event.is_set.return_value = False
# Use MagicMock for page, only reload is async
page_instance = MagicMock()
page_instance.is_closed.return_value = False
page_instance.reload = AsyncMock()
# Mock wait() to sleep briefly, but longer than the mocked timeout
async def mock_wait_longer_than_timeout():
await asyncio.sleep(0.2) # Longer than mocked 0.1s timeout
model_list_fetch_event.wait = mock_wait_longer_than_timeout
parsed_model_list = [{"id": "gemini-1.5-pro", "object": "model"}]
excluded_model_ids = set()
# Patch the wait_for timeout to be very short for testing
with patch(
"api_utils.routers.models.asyncio.wait_for", wraps=asyncio.wait_for
) as mock_wait_for:
# Override wait_for to use a short timeout
async def short_timeout_wait_for(coro, timeout):
return await asyncio.wait_for(coro, timeout=0.1)
mock_wait_for.side_effect = short_timeout_wait_for
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
# Verify: Error logged
assert logger.error.called
# Verify: Event set (finally block)
model_list_fetch_event.set.assert_called()
# Verify: Return model list (because parsed_model_list is not empty)
assert response["object"] == "list"
assert len(response["data"]) == 1
@pytest.mark.asyncio
async def test_list_models_reload_exception(mock_env):
"""
Test scenario: page.reload() throws exception
Expected: Catch exception, log error, set event (lines 37-43)
"""
logger = MagicMock()
model_list_fetch_event = MagicMock(spec=asyncio.Event)
model_list_fetch_event.is_set.return_value = False
# Use MagicMock for page, only reload is async
page_instance = MagicMock()
page_instance.is_closed.return_value = False
# Mock reload throws exception
page_instance.reload = AsyncMock(side_effect=Exception("Reload failed"))
parsed_model_list = []
excluded_model_ids = set()
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
# Verify: Error logged
logger.error.assert_called_once()
error_call_args = logger.error.call_args[0][0]
assert "Error" in error_call_args
# Verify: Event set (finally block)
model_list_fetch_event.set.assert_called()
# Verify: Return fallback model (because parsed_model_list is empty)
assert response["object"] == "list"
assert len(response["data"]) == 1
assert response["data"][0]["id"] == DEFAULT_FALLBACK_MODEL_ID
@pytest.mark.asyncio
async def test_list_models_page_closed(mock_env):
"""
Test scenario: Page closed, do not perform reload
Expected: Skip reload logic, return directly
"""
logger = MagicMock()
model_list_fetch_event = MagicMock(spec=asyncio.Event)
model_list_fetch_event.is_set.return_value = False
# Use MagicMock for page, is_closed is synchronous
page_instance = MagicMock()
page_instance.is_closed.return_value = True # Page closed
parsed_model_list = [{"id": "gemini-1.5-pro", "object": "model"}]
excluded_model_ids = set()
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
# Verify: reload not called
page_instance.reload.assert_not_called()
# Verify: Return model list
assert response["object"] == "list"
assert len(response["data"]) == 1
@pytest.mark.asyncio
async def test_list_models_page_none(mock_env):
"""
Test scenario: page_instance is None
Expected: Skip reload logic, return directly
"""
logger = MagicMock()
model_list_fetch_event = MagicMock(spec=asyncio.Event)
model_list_fetch_event.is_set.return_value = False
page_instance = None # No page instance
parsed_model_list = [{"id": "gemini-1.5-pro", "object": "model"}]
excluded_model_ids = set()
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance, # type: ignore[arg-type]
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
# Verify: Return model list (no reload needed)
assert response["object"] == "list"
assert len(response["data"]) == 1
@pytest.mark.asyncio
async def test_list_models_filter_non_dict_entries(mock_env):
"""
Test scenario: parsed_model_list contains non-dict entries
Expected: Filter non-dict entries, return only valid dicts
"""
logger = MagicMock()
model_list_fetch_event = MagicMock(spec=asyncio.Event)
model_list_fetch_event.is_set.return_value = True
# Use MagicMock for page
page_instance = MagicMock()
# Contains non-dict entries
parsed_model_list = [
{"id": "gemini-1.5-pro", "object": "model"},
"invalid_string", # non-dict
None, # non-dict
{"id": "gemini-1.5-flash", "object": "model"},
]
excluded_model_ids = set()
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
# Verify: Return only dict entries
assert response["object"] == "list"
assert len(response["data"]) == 2
assert all(isinstance(m, dict) for m in response["data"])
@pytest.mark.asyncio
async def test_list_models_empty_after_filtering(mock_env):
"""
Test scenario: All models excluded
Expected: Return empty list, not fallback model (because parsed_model_list is not None)
"""
logger = MagicMock()
model_list_fetch_event = MagicMock(spec=asyncio.Event)
model_list_fetch_event.is_set.return_value = True
# Use MagicMock for page
page_instance = MagicMock()
parsed_model_list = [
{"id": "gemini-1.5-pro", "object": "model"},
{"id": "gemini-1.5-flash", "object": "model"},
]
excluded_model_ids = {"gemini-1.5-pro", "gemini-1.5-flash"} # Exclude all
response = await list_models(
logger=logger,
model_list_fetch_event=model_list_fetch_event,
page_instance=page_instance,
parsed_model_list=parsed_model_list,
excluded_model_ids=excluded_model_ids,
)
# Verify: Return empty list (not fallback)
assert response["object"] == "list"
assert len(response["data"]) == 0
|