Spaces:
Paused
Paused
File size: 11,448 Bytes
a5784e9 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 | """
High-quality tests for browser_utils/thinking_normalizer.py (minimal mocking).
Focus: Test real normalization logic with minimal mocks.
Note: Some tests mock DEFAULT_THINKING_BUDGET and ENABLE_THINKING_BUDGET for predictability.
"""
from unittest.mock import patch
def test_normalize_reasoning_effort_none_uses_default():
"""
Test scenario: reasoning_effort is None, use default configuration
Strategy: Mock configuration values, test default behavior
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
with (
patch("browser_utils.thinking_normalizer.ENABLE_THINKING_BUDGET", True),
patch("browser_utils.thinking_normalizer.DEFAULT_THINKING_BUDGET", 10000),
):
result = normalize_reasoning_effort(None)
assert result.thinking_enabled is True
assert result.budget_enabled is True
assert result.budget_value == 10000
assert result.original_value is None
def test_normalize_reasoning_effort_zero_disables():
"""
Test scenario: reasoning_effort = 0 disables thinking mode
Verify: thinking_enabled = False
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort(0)
assert result.thinking_enabled is False
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == 0
def test_normalize_reasoning_effort_string_zero_disables():
"""
Test scenario: reasoning_effort = "0" (string) disables thinking mode
Verify: String "0" is also handled correctly
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort("0")
assert result.thinking_enabled is False
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == "0"
def test_normalize_reasoning_effort_none_string_no_budget():
"""
Test scenario: reasoning_effort = "none" enables thinking, no budget limit
Verify: thinking_enabled = True, budget_enabled = False
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort("none")
assert result.thinking_enabled is True
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == "none"
def test_normalize_reasoning_effort_minus_one_string_no_budget():
"""
Test scenario: reasoning_effort = "-1" (string) enables thinking, no budget limit
Verify: String "-1" is equivalent to "none"
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort("-1")
assert result.thinking_enabled is True
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == "-1"
def test_normalize_reasoning_effort_minus_one_int_no_budget():
"""
Test scenario: reasoning_effort = -1 (integer) enables thinking, no budget limit
Verify: Integer -1 is equivalent to "none"
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort(-1)
assert result.thinking_enabled is True
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == -1
def test_normalize_reasoning_effort_preset_low():
"""
Test scenario: reasoning_effort = "low" (preset value)
Verify: thinking_enabled = True, budget_enabled = False (determined by _should_enable_from_raw)
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort("low")
assert result.thinking_enabled is True
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == "low"
def test_normalize_reasoning_effort_preset_medium():
"""
Test scenario: reasoning_effort = "medium" (preset value)
Verify: thinking_enabled = True, budget_enabled = False (determined by _should_enable_from_raw)
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort("medium")
assert result.thinking_enabled is True
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == "medium"
def test_normalize_reasoning_effort_preset_high():
"""
Test scenario: reasoning_effort = "high" (preset value)
Verify: thinking_enabled = True, budget_enabled = False (determined by _should_enable_from_raw)
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort("high")
assert result.thinking_enabled is True
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == "high"
def test_normalize_reasoning_effort_positive_integer():
"""
Test scenario: reasoning_effort = 5000 (positive integer budget)
Verify: Enable thinking and set specific budget value
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort(5000)
assert result.thinking_enabled is True
assert result.budget_enabled is True
assert result.budget_value == 5000
assert result.original_value == 5000
def test_normalize_reasoning_effort_string_number():
"""
Test scenario: reasoning_effort = "8000" (string number)
Verify: String number correctly parsed
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
result = normalize_reasoning_effort("8000")
assert result.thinking_enabled is True
assert result.budget_enabled is True
assert result.budget_value == 8000
assert result.original_value == "8000"
def test_normalize_reasoning_effort_invalid_string_uses_default():
"""
Test scenario: reasoning_effort = "invalid" (invalid string)
Verify: Use default configuration
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
with patch("browser_utils.thinking_normalizer.ENABLE_THINKING_BUDGET", False):
result = normalize_reasoning_effort("invalid")
assert result.thinking_enabled is False
assert result.budget_enabled is False
assert result.budget_value is None
assert result.original_value == "invalid"
def test_normalize_reasoning_effort_negative_number_uses_default():
"""
Test scenario: reasoning_effort = -5 (negative number, not -1)
Verify: Use default configuration
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
with (
patch("browser_utils.thinking_normalizer.ENABLE_THINKING_BUDGET", True),
patch("browser_utils.thinking_normalizer.DEFAULT_THINKING_BUDGET", 10000),
):
result = normalize_reasoning_effort(-5)
assert result.thinking_enabled is True
assert result.budget_enabled is True
assert result.budget_value == 10000
assert result.original_value == -5
def test_normalize_reasoning_effort_case_insensitive():
"""
Test scenario: reasoning_effort string is case-insensitive
Verify: "NONE", "None", "none" are all correctly handled
"""
from browser_utils.thinking_normalizer import normalize_reasoning_effort
for value in ["NONE", "None", "none"]:
result = normalize_reasoning_effort(value)
assert result.thinking_enabled is True
assert result.budget_enabled is False
assert result.original_value == value
def test_parse_budget_value_positive_int():
"""
Test scenario: _parse_budget_value parses positive integer
Verify: Return original integer value
"""
from browser_utils.thinking_normalizer import _parse_budget_value
assert _parse_budget_value(1000) == 1000
assert _parse_budget_value(5000) == 5000
assert _parse_budget_value(1) == 1
def test_parse_budget_value_zero_returns_none():
"""
Test scenario: _parse_budget_value parses 0
Verify: 0 is not a valid budget, return None
"""
from browser_utils.thinking_normalizer import _parse_budget_value
assert _parse_budget_value(0) is None
def test_parse_budget_value_negative_returns_none():
"""
Test scenario: _parse_budget_value parses negative number
Verify: Negative number is not a valid budget, return None
"""
from browser_utils.thinking_normalizer import _parse_budget_value
assert _parse_budget_value(-100) is None
assert _parse_budget_value(-1) is None
def test_parse_budget_value_string_number():
"""
Test scenario: _parse_budget_value parses string number
Verify: "1000" → 1000
"""
from browser_utils.thinking_normalizer import _parse_budget_value
assert _parse_budget_value("1000") == 1000
assert _parse_budget_value("5000") == 5000
def test_parse_budget_value_string_with_whitespace():
"""
Test scenario: _parse_budget_value parses string with whitespace
Verify: " 1000 " → 1000 (parse after trimming)
"""
from browser_utils.thinking_normalizer import _parse_budget_value
assert _parse_budget_value(" 1000 ") == 1000
def test_parse_budget_value_invalid_string():
"""
Test scenario: _parse_budget_value parses invalid string
Verify: Return None
"""
from browser_utils.thinking_normalizer import _parse_budget_value
assert _parse_budget_value("invalid") is None
assert _parse_budget_value("abc123") is None
assert _parse_budget_value("") is None
def test_format_directive_log_disabled():
"""
Test scenario: Format log (thinking mode disabled)
Verify: Log contains "Disabling thinking mode"
"""
from browser_utils.thinking_normalizer import (
ThinkingDirective,
format_directive_log,
)
directive = ThinkingDirective(
thinking_enabled=False,
budget_enabled=False,
budget_value=None,
original_value=0,
)
log = format_directive_log(directive)
assert "disabled" in log.lower()
assert "0" in log
def test_format_directive_log_enabled_with_budget():
"""
Test scenario: Format log (thinking mode enabled, with budget limit)
Verify: Log contains budget value
"""
from browser_utils.thinking_normalizer import (
ThinkingDirective,
format_directive_log,
)
directive = ThinkingDirective(
thinking_enabled=True,
budget_enabled=True,
budget_value=8000,
original_value="medium",
)
log = format_directive_log(directive)
assert "budget" in log.lower()
assert "8000" in log
assert "medium" in log
def test_format_directive_log_enabled_no_budget():
"""
Test scenario: Format log (thinking mode enabled, no budget limit)
Verify: Log contains "no budget limit"
"""
from browser_utils.thinking_normalizer import (
ThinkingDirective,
format_directive_log,
)
directive = ThinkingDirective(
thinking_enabled=True,
budget_enabled=False,
budget_value=None,
original_value="none",
)
log = format_directive_log(directive)
assert "unlimited" in log.lower()
assert "none" in log.lower()
|