Spaces:
Paused
Paused
File size: 13,253 Bytes
a5784e9 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 | """
Integration tests for full request processing flow.
These tests use REAL asyncio primitives (locks, queues, events) to verify
actual concurrency behavior and catch integration bugs that unit tests miss.
Test Strategy:
- Use real_server_state fixture (real asyncio.Lock, asyncio.Queue)
- Mock only external I/O boundaries (browser, network)
- Test full _process_request_refactored flow end-to-end
- Verify lock contention, queue behavior, state consistency
Coverage Target: Critical async paths (locks, queue, disconnect)
"""
import asyncio
from unittest.mock import AsyncMock, MagicMock, patch
import pytest
from fastapi import HTTPException, Request
from models import ChatCompletionRequest, Message
@pytest.mark.integration
class TestRequestProcessorWithRealLocks:
"""Integration tests for request processor with real async primitives."""
async def test_processing_lock_prevents_concurrent_requests(
self, real_server_state, mock_chat_request
):
"""Test that processing_lock ensures only one request processes at a time.
Uses REAL asyncio.Lock to verify mutual exclusion.
"""
from api_utils.request_processor import _process_request_refactored
execution_log = []
async def simulate_request(req_id: str):
"""Simulate a request that logs when it acquires/releases lock."""
request = ChatCompletionRequest(
messages=[Message(role="user", content=f"Request {req_id}")],
model="gemini-1.5-pro",
)
http_request = MagicMock(spec=Request)
http_request.is_disconnected = AsyncMock(return_value=False)
result_future = asyncio.Future()
execution_log.append(f"{req_id}_start")
context = {
"req_id": req_id,
"page": real_server_state.page_instance,
"logger": MagicMock(),
"is_page_ready": True,
"current_ai_studio_model_id": "gemini-1.5-pro",
"model_switching_lock": real_server_state.model_switching_lock,
"params_cache_lock": real_server_state.params_cache_lock,
}
async def wrapped_process(*args, **kwargs):
execution_log.append(f"{req_id}_processing")
await asyncio.sleep(0.1) # Simulate work
execution_log.append(f"{req_id}_done")
raise HTTPException(status_code=500, detail="Test exit")
with (
patch(
"api_utils.request_processor._initialize_request_context",
new_callable=AsyncMock,
return_value=context,
),
patch(
"api_utils.request_processor._analyze_model_requirements",
new_callable=AsyncMock,
return_value=context,
),
patch(
"api_utils.request_processor._validate_page_status",
new_callable=AsyncMock,
side_effect=lambda *args: wrapped_process(),
),
):
try:
await _process_request_refactored(
req_id, request, http_request, result_future
)
except Exception:
pass # Expected
# Start two concurrent requests
task1 = asyncio.create_task(simulate_request("req1"))
task2 = asyncio.create_task(simulate_request("req2"))
await asyncio.gather(task1, task2, return_exceptions=True)
# Verify mutual exclusion: one must complete before the other starts processing
def get_index(event):
return execution_log.index(event) if event in execution_log else -1
req1_done = get_index("req1_done")
req1_processing = get_index("req1_processing")
req2_done = get_index("req2_done")
req2_processing = get_index("req2_processing")
# One request must fully complete before the other starts
if req1_done != -1 and req2_processing != -1:
assert req1_done < req2_processing or req2_done < req1_processing
async def test_client_disconnect_during_queue_wait(
self, real_server_state, mock_chat_request
):
"""
Test that client disconnect while waiting in queue is detected.
Uses real asyncio.Queue to verify disconnect detection works correctly.
"""
from api_utils.request_processor import _process_request_refactored
req_id = "test-req"
request = ChatCompletionRequest(
messages=[Message(role="user", content="Hello")],
model="gemini-1.5-pro",
)
http_request = MagicMock(spec=Request)
# Simulate client disconnects immediately
http_request.is_disconnected = AsyncMock(return_value=True)
result_future = asyncio.Future()
result = await _process_request_refactored(
req_id, request, http_request, result_future
)
# Should return None (early exit)
assert result is None
# Future should have 499 error
assert result_future.done()
with pytest.raises(HTTPException) as exc:
result_future.result()
assert exc.value.status_code == 499
async def test_context_init_uses_real_state(self, real_server_state):
"""
Test that context initialization uses real server state objects.
This verifies the integration between request processor and server_state.
"""
from api_utils.request_processor import _process_request_refactored
req_id = "test-req"
request = ChatCompletionRequest(
messages=[Message(role="user", content="Test")],
model="gemini-1.5-pro",
)
http_request = MagicMock(spec=Request)
http_request.is_disconnected = AsyncMock(return_value=False)
result_future = asyncio.Future()
# Verify state has real locks
assert isinstance(real_server_state.processing_lock, asyncio.Lock)
assert isinstance(real_server_state.model_switching_lock, asyncio.Lock)
assert isinstance(real_server_state.params_cache_lock, asyncio.Lock)
assert isinstance(real_server_state.request_queue, asyncio.Queue)
# Mock context init to capture what it receives
captured_state = {}
async def capture_init(*args, **kwargs):
# Capture the state used during initialization
from api_utils.server_state import state
captured_state["lock"] = state.processing_lock
return {
"req_id": req_id,
"page": state.page_instance,
"logger": MagicMock(),
"is_page_ready": True,
"current_ai_studio_model_id": "gemini-1.5-pro",
"model_switching_lock": state.model_switching_lock,
"params_cache_lock": state.params_cache_lock,
}
with (
patch(
"api_utils.request_processor._initialize_request_context",
new_callable=AsyncMock,
side_effect=capture_init,
),
patch(
"api_utils.request_processor._analyze_model_requirements",
new_callable=AsyncMock,
side_effect=lambda req_id, ctx, model: ctx,
),
patch(
"api_utils.request_processor._validate_page_status",
new_callable=AsyncMock,
side_effect=HTTPException(status_code=503, detail="Test exit"),
),
):
try:
await _process_request_refactored(
req_id, request, http_request, result_future
)
except Exception:
pass # Expected
# Verify captured lock is the REAL lock
assert captured_state["lock"] is real_server_state.processing_lock
async def test_model_switching_lock_hierarchy(self, real_server_state):
"""
Test that model switching uses nested locks correctly.
Verifies: processing_lock > model_switching_lock hierarchy
"""
from api_utils.request_processor import _process_request_refactored
req_id = "test-req"
request = ChatCompletionRequest(
messages=[Message(role="user", content="Switch model")],
model="gemini-1.5-flash", # Different from current
)
http_request = MagicMock(spec=Request)
http_request.is_disconnected = AsyncMock(return_value=False)
result_future = asyncio.Future()
real_server_state.current_ai_studio_model_id = "gemini-1.5-pro" # Current model
# Track lock acquisition order
lock_order = []
original_processing_lock_acquire = real_server_state.processing_lock.acquire
original_model_switching_lock_acquire = (
real_server_state.model_switching_lock.acquire
)
async def track_processing_lock():
lock_order.append("processing_lock_acquired")
return await original_processing_lock_acquire()
async def track_model_switching_lock():
lock_order.append("model_switching_lock_acquired")
return await original_model_switching_lock_acquire()
real_server_state.processing_lock.acquire = track_processing_lock
real_server_state.model_switching_lock.acquire = track_model_switching_lock
context = {
"req_id": req_id,
"page": real_server_state.page_instance,
"logger": MagicMock(),
"is_page_ready": True,
"current_ai_studio_model_id": "gemini-1.5-pro",
"model_switching_lock": real_server_state.model_switching_lock,
"params_cache_lock": real_server_state.params_cache_lock,
"need_switch": True,
"model_id_to_use": "gemini-1.5-flash",
}
with (
patch(
"api_utils.request_processor._initialize_request_context",
new_callable=AsyncMock,
return_value=context,
),
patch(
"api_utils.request_processor._analyze_model_requirements",
new_callable=AsyncMock,
return_value=context,
),
patch(
"api_utils.request_processor._handle_model_switching",
new_callable=AsyncMock,
side_effect=HTTPException(status_code=422, detail="Test exit"),
),
):
try:
await _process_request_refactored(
req_id, request, http_request, result_future
)
except Exception:
pass # Expected
# Verify processing lock was acquired before model switching lock
if len(lock_order) >= 2:
processing_idx = lock_order.index("processing_lock_acquired")
model_switching_idx = lock_order.index("model_switching_lock_acquired")
assert processing_idx < model_switching_idx
@pytest.mark.integration
class TestFullRequestFlowIntegration:
"""End-to-end integration tests for full request flow."""
async def test_successful_request_with_real_state(
self, real_server_state, mock_chat_request
):
"""
Test that request processing uses real async primitives correctly.
Simplified test focusing on lock usage and basic flow verification
without complex browser mock issues.
"""
execution_log = []
# Verify state has real asyncio primitives
assert isinstance(real_server_state.processing_lock, asyncio.Lock)
assert isinstance(real_server_state.model_switching_lock, asyncio.Lock)
assert isinstance(real_server_state.request_queue, asyncio.Queue)
async def simulate_processing():
"""Simulate request processing with lock."""
execution_log.append("start")
async with real_server_state.processing_lock:
execution_log.append("acquired_lock")
await asyncio.sleep(0.05) # Simulate work
execution_log.append("processing")
execution_log.append("released_lock")
# Run two simulated processes
task1 = asyncio.create_task(simulate_processing())
task2 = asyncio.create_task(simulate_processing())
await asyncio.gather(task1, task2)
# Verify both completed
assert execution_log.count("start") == 2
assert execution_log.count("acquired_lock") == 2
assert execution_log.count("processing") == 2
assert execution_log.count("released_lock") == 2
# Verify mutual exclusion - one must fully complete before other starts processing
first_release_idx = execution_log.index("released_lock")
# Verify that the first task fully released before processing continues
# (mutual exclusion is already verified by the lock behavior above)
assert first_release_idx < len(execution_log)
|