Update app.py

app.py

@@ -1,21 +1,16 @@
 import os
 import logging
 import traceback
-
 import gradio as gr
 import requests
 import pandas as pd
 from openai import OpenAI
-
-# Assuming these imports from smolagents are correct
 from smolagents import CodeAgent, DuckDuckGoSearchTool, tool
 from smolagents.models import OpenAIServerModel
 
-# --- Basic Logging Setup ---
 logging.basicConfig(level=logging.INFO, format="%(asctime)s [%(levelname)s] %(message)s")
 logger = logging.getLogger(__name__)
 
-# --- Configuration ---
 SUBMISSION_URL = "https://agents-course-unit4-scoring.hf.space"
 GITHUB_TOKEN = os.getenv("GITHUB_TOKEN")
 if not GITHUB_TOKEN:
@@ -23,7 +18,6 @@ if not GITHUB_TOKEN:
 GITHUB_ENDPOINT = "https://models.github.ai/inference"
 MODEL_ID = os.getenv("MODEL_ID", "openai/gpt-4o-mini")
 
-# --- Tool Definitions ---
 try:
     search_tool_instance = DuckDuckGoSearchTool()
     logger.info("DuckDuckGoSearchTool initialized successfully.")
@@ -31,7 +25,6 @@ except Exception as e:
     logger.error(f"Failed to instantiate DuckDuckGoSearchTool: {e}. Web search will not work.")
     search_tool_instance = None
 
-# *** FIX: Added Args description to docstrings ***
 @tool
 def web_search(query: str) -> str:
     """
@@ -52,7 +45,6 @@ def web_search(query: str) -> str:
         logger.exception(f"web_search failed for query: {query}")
         return f"Search Error: {e}"
 
-# *** FIX: Added Args description to docstrings ***
 @tool
 def wikipedia_lookup(page_title: str) -> str:
     """
@@ -93,7 +85,6 @@ def wikipedia_lookup(page_title: str) -> str:
         logger.exception(f"wikipedia_lookup failed for page: {page_safe}")
         return f"Wikipedia Error: Unexpected error: {e}"
 
-# --- The ReACT Prompt (ensure this is the *only* main prompt definition) ---
 REACT_INSTRUCTION_PROMPT = """You are a helpful assistant using tools to answer questions.
 
 Available Tools:
@@ -117,24 +108,24 @@ Formatting Rules for FINAL ANSWER:
 Let's begin!
 """
 
-# --- SmolAgent Setup ---
 logger.info(f"Initializing LLM connection: {MODEL_ID} @ {GITHUB_ENDPOINT}")
 try:
+    logger.info("Attempting to configure OpenAIServerModel with 'api_base' instead of 'base_url'...")
     llm_model = OpenAIServerModel(
         model_id=MODEL_ID,
         api_key=GITHUB_TOKEN,
-        base_url=GITHUB_ENDPOINT,
+        api_base=GITHUB_ENDPOINT,
         request_timeout=60
     )
-    logger.info("LLM connection OK.")
+    logger.info("LLM connection configured using 'api_base'.")
 except Exception as e:
-    logger.exception("CRITICAL: Failed to configure OpenAIServerModel")
-    raise RuntimeError(f"Could not configure SmolAgents model: {e}") from e
+    logger.exception("CRITICAL: Failed to configure OpenAIServerModel (tried with api_base)")
+    raise RuntimeError(f"Could not configure SmolAgents model using api_base: {e}") from e
 
 logger.info("Initializing CodeAgent...")
 try:
     agent = CodeAgent(
-        tools=[web_search, wikipedia_lookup], # Pass the functions decorated with @tool
+        tools=[web_search, wikipedia_lookup],
         model=llm_model
     )
     logger.info("CodeAgent initialized OK.")
@@ -142,17 +133,13 @@ except Exception as e:
     logger.exception("CRITICAL: Failed to initialize CodeAgent")
     raise RuntimeError(f"Could not initialize CodeAgent: {e}") from e
 
-# --- Agent Execution Function ---
 def run_agent_on_question(question: str) -> str:
-    """Runs the agent with the CORRECT prompt."""
     question = question.strip()
     if not question: return "AGENT_ERROR: Question cannot be empty."
 
-    # *** CRITICAL: Construct the prompt HERE using the correct variable ***
     full_prompt = REACT_INSTRUCTION_PROMPT.strip() + "\n\nQUESTION: " + question
     logger.info(f"--- Running Agent for Question: '{question}' ---")
-    # *** Add more prominent logging to verify the prompt ***
-    logger.info(f"CRITICAL_DEBUG: Using prompt beginning:\n{full_prompt[:400]}\n...") # Log first 400 chars
+    logger.info(f"CRITICAL_DEBUG: Using prompt beginning:\n{full_prompt[:400]}\n...")
 
     try:
         raw_result = agent.run(full_prompt)
@@ -162,16 +149,12 @@ def run_agent_on_question(question: str) -> str:
         logger.exception(f"Agent run failed for question '{question}'")
         return f"AGENT_ERROR: Exception during run: {e}\n{traceback.format_exc()}"
 
-# --- Gradio Interface & Submission Logic ---
-# Using the version without direct profile input to avoid potential TypeErrors
 def evaluate_and_submit():
-    """Gradio action: Fetches questions, runs agent, submits results."""
     logger.info("🚀 Starting evaluation run...")
-    username = os.getenv("HF_USERNAME", "unknown_user") # Fallback username
+    username = os.getenv("HF_USERNAME", "unknown_user")
     if username == "unknown_user": logger.warning("Could not get HF username reliably.")
     logger.info(f"Running as user (best effort): {username}")
 
-    # 1. Fetch Questions
     try:
         resp = requests.get(f"{SUBMISSION_URL}/questions", timeout=20)
         resp.raise_for_status()
@@ -184,7 +167,6 @@ def evaluate_and_submit():
 
     if not questions: return "ℹ️ No questions fetched.", pd.DataFrame()
 
-    # 2. Run Agent & Collect Results
     results_log = []
     answers_payload = []
     for i, item in enumerate(questions):
@@ -202,7 +184,6 @@ def evaluate_and_submit():
     results_df = pd.DataFrame(results_log)
     if not answers_payload: return "⚠️ Agent ran but produced no answers.", results_df
 
-    # 3. Submit Answers
     logger.info(f"Submitting {len(answers_payload)} answers...")
     space_id = os.getenv("SPACE_ID", "NA"); agent_code_url = f"https://huggingface.co/spaces/{space_id}/tree/main" if space_id != "NA" else "NA"
     submit_data = {"username": username, "agent_code": agent_code_url, "answers": answers_payload}
@@ -219,7 +200,6 @@ def evaluate_and_submit():
         if hasattr(e, 'response') and e.response is not None: err_msg += f" | Response: {e.response.text[:300]}"
         return err_msg, results_df
 
-# --- Build Gradio App ---
 logger.info("Setting up Gradio interface...")
 with gr.Blocks(theme=gr.themes.Soft()) as demo:
     gr.Markdown("# 🚀 Agent Evaluation Runner 🚀\nEnsure `GITHUB_TOKEN` secret is set. Click Run to start.")
@@ -229,9 +209,7 @@ with gr.Blocks(theme=gr.themes.Soft()) as demo:
     run_button.click(fn=evaluate_and_submit, inputs=None, outputs=[status_textbox, results_df_display])
 logger.info("Gradio interface setup complete.")
 
-# --- Launch ---
 if __name__ == "__main__":
     logger.info("Launching Gradio application...")
-    # Setting share=False as recommended for HF Spaces, debug=True for detailed Gradio logs
     demo.launch(debug=True, share=False)
     logger.info("Gradio application launched.")