unnecessary validation check removed.

agents/generator_validator.py

@@ -622,11 +622,6 @@ class LLMNotesGenerator(BaseGenerator):
         """Refine LLM notes generation based on feedback"""
         logger.info(f"Refining LLM notes generation with feedback: {feedback}")
 
-        # For LLM generation, we can try different approaches:
-        # 1. Switch to RLHF if not already using it
-        # 2. Retry with different parameters
-        # 3. Use fallback models
-
         if not self.use_rlhf and "quality" in str(feedback).lower():
             # If quality issues and not using RLHF, try RLHF
             logger.info("Switching to RLHF for better quality")
@@ -640,80 +635,50 @@ class LLMNotesGenerator(BaseGenerator):
             return self.generate(previous_result.data.get("file_path") if previous_result.data else None)
 
 class NotesValidator(BaseValidator):
-    """Validator for financial notes quality"""
+    """Simplified validator for financial notes - passes user validation to interactive feedback system"""
 
     def validate(self, generation_result: GenerationResult) -> ValidationResult:
-        """Validate generated financial notes"""
+        """
+        Simplified validation - since users provide direct feedback through interactive sessions,
+        this validator just does basic file existence checks and always passes validation
+        to let users provide their own feedback.
+        """
         if not generation_result.success or not generation_result.output_path:
             return ValidationResult(
                 is_valid=False,
                 score=0.0,
                 feedback=["Generation failed - no output produced"],
                 suggestions=["Retry generation process"],
-                metadata={"validation_type": "basic"}
+                metadata={"validation_type": "basic_file_check"}
             )
 
-        feedback = []
-        suggestions = []
-        score = 1.0  # Start with perfect score
-
-        try:
-            # Check if output file exists
-            if not os.path.exists(generation_result.output_path):
-                feedback.append("Output file does not exist")
-                suggestions.append("Check file generation process")
-                score -= 0.5
-
-            # Check file size (reasonable minimum)
-            if os.path.exists(generation_result.output_path):
-                file_size = os.path.getsize(generation_result.output_path)
-                if file_size < 1000:  # Less than 1KB
-                    feedback.append("Output file is unusually small")
-                    suggestions.append("Verify data processing and Excel generation")
-                    score -= 0.3
-
-            # Check for common financial notes elements
-            # This would require reading the Excel file, but for now we'll do basic checks
-
-            # Check metadata completeness
-            metadata = generation_result.metadata
-            if not metadata.get("execution_id"):
-                feedback.append("Missing execution ID in metadata")
-                score -= 0.1
-
-            if generation_result.metadata.get("generation_method") == "llm":
-                # Additional checks for LLM-generated content
-                rlhf_metadata = metadata.get("rlhf_metadata", {})
-                if rlhf_metadata and rlhf_metadata.get("predicted_quality", 0) < 0.5:
-                    feedback.append("Low quality score from RLHF validation")
-                    suggestions.append("Consider regenerating with RLHF enabled")
-                    score -= 0.4
-
-            # Ensure score doesn't go below 0
-            score = max(0.0, score)
-
-            return ValidationResult(
-                is_valid=score >= 0.6,  # 60% threshold for validity
-                score=score,
-                feedback=feedback,
-                suggestions=suggestions,
-                metadata={
-                    "validation_type": "comprehensive",
-                    "file_size": os.path.getsize(generation_result.output_path) if os.path.exists(generation_result.output_path) else 0,
-                    "has_rlhf": bool(generation_result.metadata.get("rlhf_metadata"))
-                }
-            )
-
-        except Exception as e:
-            logger.error(f"Validation failed: {e}")
+        # Basic file existence check
+        if not os.path.exists(generation_result.output_path):
             return ValidationResult(
                 is_valid=False,
                 score=0.0,
-                feedback=[f"Validation error: {str(e)}"],
-                suggestions=["Check system logs for detailed error information"],
-                metadata={"validation_type": "error"}
+                feedback=["Output file does not exist"],
+                suggestions=["Check file generation process"],
+                metadata={"validation_type": "basic_file_check"}
             )
 
+        # Get file size for metadata
+        file_size = os.path.getsize(generation_result.output_path) if os.path.exists(generation_result.output_path) else 0
+        
+        # Always pass validation - let users provide feedback through interactive system
+        return ValidationResult(
+            is_valid=True,  # Always pass - user feedback takes precedence
+            score=1.0,      # Perfect score - user will validate
+            feedback=[],    # No automatic feedback - user provides feedback
+            suggestions=[], # No automatic suggestions - user provides direction
+            metadata={
+                "validation_type": "user_feedback_based",
+                "file_size": file_size,
+                "automatic_validation_disabled": True,
+                "reason": "User feedback through interactive sessions replaces automatic validation"
+            }
+        )
+
     def get_validation_criteria(self) -> List[str]:
         """Return list of validation criteria"""
         return [