Update notes/llm_notes_generator.py

notes/llm_notes_generator.py

@@ -66,7 +66,7 @@ class FlexibleFinancialNoteGenerator:
             
             "mistralai/mixtral-8x7b-instruct"
         ]
-
+    
     def load_note_templates(self) -> Dict[str, Any]:
         try:
             if __name__ == "__main__":
@@ -276,13 +276,16 @@ GENERATE VALID JSON NOW (NO ADDITIONAL TEXT):"""
                     self.api_url,
                     headers=self.headers,
                     json=payload,
-                    timeout=60
+                    timeout=180
                 )
                 response.raise_for_status()
                 result = response.json()
                 content = result['choices'][0]['message']['content']
                 logger.info(f"Successful response from {model}")
                 return content
+            except requests.exceptions.Timeout:
+                logger.warning(f"Request to {model} timed out after 180s")
+                continue
             except requests.exceptions.HTTPError as e:
                 if e.response.status_code == 404:
                     logger.warning(f"Model {model} not found (404), trying next model")
@@ -358,6 +361,47 @@ GENERATE VALID JSON NOW (NO ADDITIONAL TEXT):"""
             
             return None, None
     
+    def safe_numeric_value(self, value, default=0.0):
+        """Convert any value to a safe numeric float, defaulting to 0.0 if conversion fails."""
+        if value is None or value == '' or value == '-':
+            return default
+        
+        try:
+            # If already a number, return it as float
+            if isinstance(value, (int, float)):
+                return float(value)
+            
+            # Handle string numbers
+            if isinstance(value, str):
+                # Remove common non-numeric characters
+                cleaned = value.replace(',', '').replace('₹', '').replace('Rs', '').replace('Rs.', '').strip()
+                
+                # Handle parentheses for negative numbers (accounting format)
+                if cleaned.startswith('(') and cleaned.endswith(')'):
+                    cleaned = '-' + cleaned[1:-1]
+                
+                # Handle negative numbers
+                is_negative = cleaned.startswith('-')
+                if is_negative:
+                    cleaned = cleaned[1:]
+                
+                # Remove any remaining non-numeric characters except decimal point
+                cleaned = ''.join(c for c in cleaned if c.isdigit() or c == '.')
+                
+                if not cleaned or cleaned == '.':
+                    return default
+                
+                # Convert to number
+                result = float(cleaned)
+                return -result if is_negative else result
+            
+            # Try direct conversion as last resort
+            return float(value)
+        
+        except (ValueError, TypeError, AttributeError):
+            logger.warning(f"Could not convert value '{value}' to numeric, using default {default}")
+            return default
+    
     def validate_and_fix_json(self, json_data: Dict[str, Any], note_number: str) -> Dict[str, Any]:
         fixed_data = json_data.copy()
         
@@ -377,7 +421,7 @@ GENERATE VALID JSON NOW (NO ADDITIONAL TEXT):"""
         
         metadata_note_num = fixed_data["metadata"].get("note_number")
         try:
-            expected_note_num = int(note_number)
+            expected_note_num = int(note_number);
             
             if (metadata_note_num is None or 
                 metadata_note_num == 0 or 
@@ -436,17 +480,26 @@ GENERATE VALID JSON NOW (NO ADDITIONAL TEXT):"""
                 if "subcategories" not in struct_elem or not isinstance(struct_elem["subcategories"], list):
                     struct_elem["subcategories"] = []
                 
+                # FIX: Ensure all subcategory values are numeric before summing
+                for sub in struct_elem.get("subcategories", []):
+                    if isinstance(sub, dict):
+                        if "value" in sub:
+                            sub["value"] = self.safe_numeric_value(sub["value"])
+                        if "previous_value" in sub:
+                            sub["previous_value"] = self.safe_numeric_value(sub["previous_value"])
+                
+                # Now safely calculate totals
                 if i > 0 and struct_elem.get("subcategories"):
                     if "total" not in struct_elem:
                         struct_elem["total"] = sum(
-                            sub.get("value", 0.0) 
+                            self.safe_numeric_value(sub.get("value", 0.0))
                             for sub in struct_elem["subcategories"] 
                             if isinstance(sub, dict)
                         )
                     
                     if "previous_total" not in struct_elem:
                         struct_elem["previous_total"] = sum(
-                            sub.get("previous_value", 0.0) 
+                            self.safe_numeric_value(sub.get("previous_value", 0.0))
                             for sub in struct_elem["subcategories"] 
                             if isinstance(sub, dict)
                         )