Update app.py

app.py

@@ -33,8 +33,7 @@ def parse_generated_text(text: str) -> dict:
     }
 
 def generate_questions(topic, difficulty, types, count):
-    print("Received input:", topic, difficulty, types, count)  
-
+    print("Received input:", topic, difficulty, types, count)
     try:
         pipe = pipeline(
             task="text-generation",
@@ -48,8 +47,8 @@ def generate_questions(topic, difficulty, types, count):
 
         questions = []
 
-        for _ in range(count):
-            for q_type in types:
+        for q_type in types:
+            for _ in range(count):
                 prompt = (
                     f"Generate a {difficulty} difficulty {q_type} question about {topic}.\n"
                     "Format strictly as follows:\n"
@@ -66,9 +65,6 @@ def generate_questions(topic, difficulty, types, count):
                 generated_text = result[0]['generated_text'].replace(formatted_prompt, "").strip()
                 parsed = parse_generated_text(generated_text)
 
-                print("Parsed Output:", parsed)
-
-                # Safe fallback
                 if not parsed['question']:
                     parsed['question'] = "⚠️ Could not parse question."
                 if not parsed['hint']:
@@ -78,16 +74,16 @@ def generate_questions(topic, difficulty, types, count):
                 questions.append(formatted)
 
         final_output = "\n\n".join(questions)
-        print("Final Output:", final_output)
+        print("Returning this to UI:\n", final_output)
+
+        if not final_output.strip():
+            return "⚠️ No questions were generated."
+
         return final_output
 
     except Exception as e:
         print("Error:", e)
         return f"❌ Something went wrong: {e}"
-    
-    except Exception as e:
-        print("Error:", e)
-        return f"Something went wrong: {e}"
 
 iface = gr.Interface(
     fn=generate_questions,
@@ -103,4 +99,4 @@ iface = gr.Interface(
 )
 
 if __name__ == "__main__":
-    iface.queue().launch()
+    iface.queue().launch()