fix: fix transaction api responses

app/api/routers/transaction.py

@@ -2,7 +2,7 @@ from typing import List
 from fastapi import APIRouter, Depends, HTTPException, status
 from sqlalchemy.ext.asyncio import AsyncSession
 from app.model.transaction import Transaction as TransactionModel
-from app.schema.index import TransactionOutput
+from app.schema.index import TransactionResponse
 from app.engine.postgresdb import get_db_session
 
 transaction_router = r = APIRouter(prefix="/api/v1/transactions", tags=["transactions"])
@@ -10,7 +10,7 @@ transaction_router = r = APIRouter(prefix="/api/v1/transactions", tags=["transac
 
 @r.get(
     "/{user_id}",
-    response_model=List[TransactionOutput],
+    response_model=List[TransactionResponse],
     responses={
         200: {"description": "New user created"},
         400: {"description": "Bad request"},
@@ -23,6 +23,7 @@ async def get_transactions(user_id: int, db: AsyncSession = Depends(get_db_sessi
     Retrieve all transactions.
     """
     result = await TransactionModel.get_by_user(db, user_id)
-    if len(result) == 0:
-        raise HTTPException(status_code=status.HTTP_204_NO_CONTENT)
-    return result.scalars().all()
+    all_rows = result.all()
+    if len(all_rows) == 0:
+        raise HTTPException(status_code=status.HTTP_204_NO_CONTENT, detail="No transactions found for this user")
+    return all_rows

app/model/transaction.py

@@ -23,9 +23,10 @@ class Transaction(Base, BaseModel):
     @classmethod
     async def create(cls: "type[Transaction]", db: AsyncSession, **kwargs) -> "Transaction":
         query = sql.insert(cls).values(**kwargs).returning(cls.id)
-        transactions = await db.execute(query)
+        transactions = await db.scalars(query)
+        transaction = transactions.first()
         await db.commit()
-        return transactions.first()
+        return transaction
 
     @classmethod
     async def update(cls: "type[Transaction]", db: AsyncSession, id: int, **kwargs) -> "Transaction":
@@ -36,12 +37,13 @@ class Transaction(Base, BaseModel):
             .execution_options(synchronize_session="fetch")
             .returning(cls.id)
         )
-        transactions = await db.execute(query)
+        transactions = await db.scalars(query)
+        transaction = transactions.first()
         await db.commit()
-        return transactions.first()
+        return transaction
 
     @classmethod
     async def get_by_user(cls: "type[Transaction]", db: AsyncSession, user_id: int) -> "List[Transaction]":
         query = sql.select(cls).where(cls.user_id == user_id)
-        transactions = await db.execute(query)
+        transactions = await db.scalars(query)
         return transactions

app/schema/index.py

@@ -37,7 +37,7 @@ class User(BaseModel):
     transactions: "List[Transaction]" = []
 
 
-class TransactionOutput(BaseModel):
+class TransactionResponse(PydanticBaseModel):
     transaction_date: datetime
     category: str
     name_description: str
@@ -45,5 +45,5 @@ class TransactionOutput(BaseModel):
     type: TransactionType
 
 
-class Transaction(TransactionOutput):
+class Transaction(TransactionResponse):
     user: User