made changes

Dockerfile

@@ -1,8 +1,7 @@
-# Multi-stage Dockerfile for Dance Movement Analyzer
-# Optimized for Hugging Face Spaces with MediaPipe model pre-download
+# Optimized Dockerfile for Dance Movement Analyzer
+# Fixes MediaPipe model permission issues
 
-# Stage 1: Base image with dependencies
-FROM python:3.10-slim as base
+FROM python:3.10-slim
 
 # Set environment variables
 ENV PYTHONUNBUFFERED=1 \
@@ -13,7 +12,7 @@ ENV PYTHONUNBUFFERED=1 \
 
 # Install system dependencies
 RUN apt-get update && apt-get install -y --no-install-recommends \
-    libgl1 \
+    libgl1-mesa-glx \
     libglib2.0-0 \
     libsm6 \
     libxext6 \
@@ -26,74 +25,63 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
 # Create app directory
 WORKDIR /app
 
-# Stage 2: Dependencies installation
-FROM base as dependencies
-
-# Copy requirements first for better caching
+# Copy and install Python dependencies
 COPY backend/requirements.txt .
-
-# Install Python dependencies
-RUN pip install --no-cache-dir -r requirements.txt
-
-# Pre-download ALL MediaPipe models (as root before user switch)
-# This downloads the models to the pip packages directory
-RUN python3 -c "\
-import mediapipe as mp; \
-print('Downloading MediaPipe Pose models...'); \
-# Model complexity 0 (Lite) \
-pose0 = mp.solutions.pose.Pose(model_complexity=0, min_detection_confidence=0.5); \
-pose0.close(); \
-print('✅ Lite model downloaded'); \
-# Model complexity 1 (Full) \
-pose1 = mp.solutions.pose.Pose(model_complexity=1, min_detection_confidence=0.5); \
-pose1.close(); \
-print('✅ Full model downloaded'); \
-# Model complexity 2 (Heavy) \
-pose2 = mp.solutions.pose.Pose(model_complexity=2, min_detection_confidence=0.5); \
-pose2.close(); \
-print('✅ Heavy model downloaded'); \
-print('✅ All MediaPipe models pre-downloaded successfully'); \
-"
-
-# Stage 3: Production image
-FROM base as production
-
-# Copy installed packages from dependencies stage (includes downloaded models)
-COPY --from=dependencies /usr/local/lib/python3.10/site-packages /usr/local/lib/python3.10/site-packages
-COPY --from=dependencies /usr/local/bin /usr/local/bin
+RUN pip install --no-cache-dir --upgrade pip && \
+    pip install --no-cache-dir -r requirements.txt
+
+# Pre-download MediaPipe models (as root, before creating non-root user)
+RUN echo "Downloading MediaPipe Pose models..." && \
+    python3 -c "import mediapipe as mp; \
+    print('Downloading Lite model...'); \
+    pose0 = mp.solutions.pose.Pose(model_complexity=0, min_detection_confidence=0.5); \
+    pose0.close(); \
+    print('✅ Lite model downloaded'); \
+    print('Downloading Full model...'); \
+    pose1 = mp.solutions.pose.Pose(model_complexity=1, min_detection_confidence=0.5); \
+    pose1.close(); \
+    print('✅ Full model downloaded'); \
+    print('Downloading Heavy model...'); \
+    pose2 = mp.solutions.pose.Pose(model_complexity=2, min_detection_confidence=0.5); \
+    pose2.close(); \
+    print('✅ Heavy model downloaded'); \
+    print('✅ All models pre-downloaded successfully');" && \
+    echo "MediaPipe models downloaded successfully"
+
+# Set proper permissions for MediaPipe models directory
+RUN chmod -R 755 /usr/local/lib/python3.10/site-packages/mediapipe
 
 # Create necessary directories
 RUN mkdir -p /app/uploads /app/outputs /app/logs
 
-# Copy backend application
+# Copy application files
 COPY backend/app /app/app
-
-# Copy frontend files
 COPY frontend /app/frontend
 
 # Copy startup script
 COPY startup.sh /app/startup.sh
-
-# Make startup script executable
 RUN chmod +x /app/startup.sh
 
-# Set permissions for all app files
-RUN chmod -R 755 /app
+# Create non-root user
+RUN useradd -m -u 1000 appuser
+
+# Set ownership of app directory
+RUN chown -R appuser:appuser /app
 
-# Create non-root user for security
-RUN useradd -m -u 1000 appuser && \
-    chown -R appuser:appuser /app
+# IMPORTANT: Keep MediaPipe models readable by non-root user
+RUN chmod -R 755 /usr/local/lib/python3.10/site-packages/mediapipe && \
+    chown -R root:root /usr/local/lib/python3.10/site-packages/mediapipe
 
 # Switch to non-root user
 USER appuser
 
-# Expose ports (7860 for Hugging Face, 8000 for local)
+# Expose ports
 EXPOSE 8000
 EXPOSE 7860
 
-# Health check with 5 minute startup period
+# Health check
 HEALTHCHECK --interval=30s --timeout=10s --start-period=5m --retries=3 \
     CMD python -c "import requests; requests.get('http://localhost:8000/health')" || exit 1
 
-# Run the application using startup script
+# Start application
 CMD ["/app/startup.sh"]

backend/app/main.py

@@ -34,8 +34,7 @@ global_processor: Optional[VideoProcessor] = None
 
 @asynccontextmanager
 async def lifespan(app: FastAPI):
-    """Lifespan event handler - models already downloaded in Docker build"""
-    global global_processor
+    """Lifespan event handler - lazy model loading"""
     
     # Startup
     logger.info("🚀 Starting Dance Movement Analyzer...")
@@ -44,15 +43,9 @@ async def lifespan(app: FastAPI):
     Config.initialize_folders()
     logger.info("✅ Folders initialized")
     
-    # Initialize VideoProcessor (models already downloaded, just instantiate)
-    logger.info("📦 Initializing Video Processor...")
-    try:
-        global_processor = VideoProcessor()
-        logger.info("✅ Video Processor initialized successfully")
-    except Exception as e:
-        logger.error(f"❌ Error initializing Video Processor: {e}")
-        # Continue anyway - will retry on first request
-        global_processor = None
+    # Don't initialize VideoProcessor here - let it lazy load on first request
+    # This avoids the permission error during startup
+    logger.info("📦 Models pre-downloaded, will initialize on first request")
     
     logger.info("🎉 Application startup complete!")
     
@@ -60,9 +53,6 @@ async def lifespan(app: FastAPI):
     
     # Shutdown
     logger.info("👋 Shutting down application...")
-    if global_processor is not None:
-        # Cleanup if needed
-        pass
 
 # Initialize FastAPI app with lifespan
 app = FastAPI(
@@ -175,11 +165,20 @@ async def health_check():
     return {
         "status": "healthy",
         "models_loaded": global_processor is not None,
+        "models_ready": True,  # Models are pre-downloaded
         "timestamp": datetime.now().isoformat(),
-        "active_sessions": len(processing_sessions),
-        "active_connections": len(manager.active_connections)
+        "active_sessions": len(processing_sessions)
     }
 
+def get_video_processor() -> VideoProcessor:
+    """Get or create the global VideoProcessor instance"""
+    global global_processor
+    if global_processor is None:
+        logger.info("Initializing VideoProcessor (first use)...")
+        global_processor = VideoProcessor()
+        logger.info("✅ VideoProcessor initialized")
+    return global_processor
+
 @app.post("/api/upload")
 async def upload_video(file: UploadFile = File(...)):
     """Upload a video file for processing"""

startup.sh

@@ -2,42 +2,13 @@
 set -e
 
 echo "🚀 Starting Dance Movement Analyzer..."
-
-# Verify MediaPipe models are available
-echo "📦 Verifying MediaPipe models..."
-python3 -c "
-import mediapipe as mp
-import logging
-import os
-
-logging.basicConfig(level=logging.INFO)
-logger = logging.getLogger(__name__)
-
-try:
-    # Quick verification that models are accessible
-    logger.info('Checking MediaPipe installation...')
-    
-    # Verify model files exist
-    model_path = '/usr/local/lib/python3.10/site-packages/mediapipe/modules/pose_landmark'
-    if os.path.exists(model_path):
-        logger.info(f'✅ Model directory found: {model_path}')
-        model_files = os.listdir(model_path)
-        logger.info(f'Available models: {len(model_files)} files')
-    else:
-        logger.warning('⚠️ Model directory not found, models will load on first use')
-    
-    logger.info('✅ MediaPipe ready')
-    
-except Exception as e:
-    logger.error(f'❌ Error verifying models: {e}')
-    # Continue anyway - application will handle it
-"
+echo "📦 MediaPipe models pre-downloaded during build"
 
 # Detect port (Hugging Face uses 7860, local uses 8000)
 PORT=${PORT:-8000}
 
 echo "🎬 Starting Uvicorn server on port $PORT..."
-echo "📍 Application will be available at http://0.0.0.0:$PORT"
+echo "📍 Application available at http://0.0.0.0:$PORT"
 echo ""
 
 # Start the application