Spaces:
Running
Running
William Easton commited on
Log tool name on transform validation error (#1238)
Browse files
src/fastmcp/tools/tool_transform.py
CHANGED
|
@@ -445,7 +445,7 @@ class TransformedTool(Tool):
|
|
| 445 |
if unknown_args:
|
| 446 |
raise ValueError(
|
| 447 |
f"Unknown arguments in transform_args: {', '.join(sorted(unknown_args))}. "
|
| 448 |
-
f"Parent tool has: {', '.join(sorted(parent_params))}"
|
| 449 |
)
|
| 450 |
|
| 451 |
# Always create the forwarding transform
|
|
|
|
| 445 |
if unknown_args:
|
| 446 |
raise ValueError(
|
| 447 |
f"Unknown arguments in transform_args: {', '.join(sorted(unknown_args))}. "
|
| 448 |
+
f"Parent tool `{tool.name}` has: {', '.join(sorted(parent_params))}"
|
| 449 |
)
|
| 450 |
|
| 451 |
# Always create the forwarding transform
|
tests/tools/test_tool_transform.py
CHANGED
|
@@ -404,11 +404,13 @@ def test_transform_args_validation_unknown_arg(add_tool):
|
|
| 404 |
"""Test that transform_args with unknown arguments raises ValueError."""
|
| 405 |
with pytest.raises(
|
| 406 |
ValueError, match="Unknown arguments in transform_args: unknown_param"
|
| 407 |
-
):
|
| 408 |
Tool.from_tool(
|
| 409 |
add_tool, transform_args={"unknown_param": ArgTransform(name="new_name")}
|
| 410 |
)
|
| 411 |
|
|
|
|
|
|
|
| 412 |
|
| 413 |
def test_transform_args_creates_duplicate_names(add_tool):
|
| 414 |
"""Test that transform_args creating duplicate parameter names raises ValueError."""
|
|
|
|
| 404 |
"""Test that transform_args with unknown arguments raises ValueError."""
|
| 405 |
with pytest.raises(
|
| 406 |
ValueError, match="Unknown arguments in transform_args: unknown_param"
|
| 407 |
+
) as exc_info:
|
| 408 |
Tool.from_tool(
|
| 409 |
add_tool, transform_args={"unknown_param": ArgTransform(name="new_name")}
|
| 410 |
)
|
| 411 |
|
| 412 |
+
assert "`add`" in str(exc_info.value)
|
| 413 |
+
|
| 414 |
|
| 415 |
def test_transform_args_creates_duplicate_names(add_tool):
|
| 416 |
"""Test that transform_args creating duplicate parameter names raises ValueError."""
|