Generate Question

generateQuestion.py

@@ -63,20 +63,27 @@ COHERE_API_URL = 'https://api.cohere.ai/v1/generate'
 def validate_topic(topic):
 
     validation_prompt = f"""
-    You are an AI grammar expert. Your task is to determine if a given topic is related to **English grammar** or not.
-
-    **Input:** "{topic}"
-
-    ### **Rules:**
-    - If the input is **in the form of a question** (e.g., it asks for an explanation or definition), return `"ask grammar topics"`, even if the topic is related to grammar.
-    - If the topic is **related to English grammar concepts** such as **parts of speech**, **verb tenses**, **sentence structure**, etc., return `"Grammar"`.
-    - If the topic is **not related to grammar**, such as general knowledge, science, math, history, or topics from other fields, return `"Not Grammar"`.
-    - Your response must be based purely on whether the topic relates to grammar, and **not** based on specific words, phrases, or examples.
-
-    **Your response must be exactly either "Grammar", "Not Grammar", or "ask grammar topics". No extra text.**
+   ou are a highly knowledgeable AI grammar expert. Your task is to evaluate whether the given topic relates to **English grammar** or not.
+
+    **Input Topic:** "{topic}"
+
+    ### **Instructions:**
+    - If the input **exactly refers to** grammar concepts (such as **parts of speech**, **verb tenses**, **sentence structure**, **grammar rules**, etc.), respond with `"Grammar"`.
+    - If the input **seems to be a general question or concept** that is **not directly related to grammar**, such as general knowledge, science, history, or unrelated fields, respond with `"Not Grammar"`.
+    - If the input is in the form of a **question** (e.g., "What is subject-verb agreement?"), respond with `"ask grammar topics"`.
+    - If the topic refers to a **specific grammar concept** (e.g., **noun**, **verb**, **preposition**, **past tense**, etc.), always classify it as `"Grammar"`.
+    - **Do not include any explanations or examples**. Your answer must only be `"Grammar"`, `"Not Grammar"`, or `"ask grammar topics"`, depending on whether the topic is relevant to grammar.
+    - If the input is **unclear**, err on the side of classifying it as `"Not Grammar"` rather than `"Grammar"`.
+
+    Your response must only be one of these three options:
+    - `"Grammar"`
+    - `"Not Grammar"`
+    - `"ask grammar topics"`
+    No extra text or explanation.
     """
 
 
+
     
 
 
@@ -135,48 +142,14 @@ def generate_questions_test():
             Generate five **completely new and unique** very basic-level fill-in-the-blank grammar questions **every time** on the topic '{topic}'. 
 
             ### Rules:
-            - **Each question must have a different theme**, ensuring variety.
-            - **Do not repeat** themes from previous generations.
-            - Use **different sentence structures**, avoiding predictable patterns.
-            - **Avoid long words or abstract concepts**
-            - **Focus on the topic '{topic}'**, and ensure the blank is the key part of speech.
-            - Each question should contain **one blank represented by '_______'**, with the correct answer provided in parentheses at the end.
-            - The vocabulary should be **simple and suitable for beginners**.
-            - Ensure that the questions are **always new and distinct**, avoiding previously used themes.
-
-            Do not include any explanations or instructions in the response—only the five unique questions.
-            """
-
-        elif difficulty == 'elementary':
-            prompt = f"""
-            Generate five **completely new and unique** elementary-level fill-in-the-blank grammar questions **every time** on the topic '{topic}'.
-
-            ### Rules:
-            - The questions should be **slightly more challenging than basic-level questions**, incorporating **a wider range of sentence structures and vocabulary**.
-            - **Each question must have a different theme**, ensuring variety.
-            - **Use varied sentence structures**, making them slightly more complex than basic-level questions.
-            - **Ensure that the vocabulary is still simple but slightly broader** than basic-level questions.
-            - **Focus on the topic '{topic}'**, and ensure the blank is the key part of speech.
-            - Each question should contain **one blank represented by '_______'**, with the correct answer provided in parentheses at the end.
-            - Ensure that the questions are **always new and distinct**, avoiding previously used themes.
-    
-            Do not include any explanations or instructions in the response—only the five unique questions.
-            """
-
-        elif difficulty == 'pre-intermediate':
-            prompt = f"""
-            Generate five **completely new and unique** pre-intermediate-level fill-in-the-blank grammar questions **every time** on the topic '{topic}'.
-
-            ### Rules:
-            - The questions should be **more challenging than elementary-level questions**, incorporating **more varied sentence structures and an expanded vocabulary**.
-            - **Each question must have a different theme**, ensuring variety.
-            - **Ensure that the vocabulary is broader than elementary-level**, while keeping it understandable for learners.
-            - **Sentences should be longer and more descriptive** but still clear.
-            - **Focus on the topic '{topic}'**, and ensure the blank is the key part of speech.
-            - Each question should contain **one blank represented by '_______'**, with the correct answer provided in parentheses at the end.
-            - Ensure that the questions are **always new and distinct**, avoiding previously used themes.
-
-            Do not include any explanations or instructions in the response—only the five unique questions.
+            - Generate five unique fill-in-the-blank grammar questions based on the topic '{topic}'.
+            - Each question must have exactly one blank represented by '_______' (not two blanks or underscores inside the sentence).
+            - Each question must have a different theme for variety.
+            - Use different sentence structures; avoid predictable patterns.
+            - Avoid long words or abstract concepts.
+            - Focus on the topic '{topic}', and ensure the blank is the key part of speech.
+            - Each question must include the correct answer in parentheses at the end.
+            - Do not include any explanations or instructions—only the five questions.
             """
 
         elif difficulty == 'intermediate':
@@ -184,62 +157,32 @@ def generate_questions_test():
             Generate five **completely new and unique** intermediate-level fill-in-the-blank grammar questions **every time** on the topic '{topic}'.
 
             ### Rules:
-            - The questions should be **more complex than pre-intermediate-level questions**, incorporating **a wider range of vocabulary and sentence structures**.
-            - **Each question must have a different theme**, ensuring variety.
-            - **Ensure that the vocabulary is more advanced than pre-intermediate-level** while keeping it natural for learners.
-            - **Sentences should be longer and include more detail**, improving reading comprehension.
-            - **Focus on the topic '{topic}'**, and ensure the blank is the key part of speech.
-            - Each question should contain **one blank represented by '_______'**, with the correct answer provided in parentheses at the end.
-            - Ensure that the questions are **always new and distinct**, avoiding previously used themes.
-
-            Do not include any explanations or instructions in the response—only the five unique questions.
-            """
-
-        elif difficulty == 'upper-intermediate':
-            prompt = f"""
-            Generate five **completely new and unique** upper-intermediate-level fill-in-the-blank grammar questions **every time** on the topic '{topic}'.
-
-            ### Rules:
-            - The questions should be **more complex than intermediate-level questions**, incorporating **more advanced sentence structures and vocabulary**.
-            - **Each question must have a different theme**, ensuring variety.
-            - **Ensure that the vocabulary is more refined and diverse** but still understandable for upper-intermediate learners.
-            - **Sentences should be longer and may introduce more nuanced contexts**, requiring a deeper understanding.
-            - **Focus on the topic '{topic}'**, and ensure the blank is the key part of speech.
-            - Each question should contain **one blank represented by '_______'**, with the correct answer provided in parentheses at the end.
-            - Ensure that the questions are **always new and distinct**, avoiding previously used themes.
-
-            Do not include any explanations or instructions in the response—only the five unique questions.
+            - Generate five unique fill-in-the-blank grammar questions based on the topic '{topic}'.
+            - Each question must have exactly one blank represented by '_______'.
+            - Slightly more challenging than basic-level; use a wider range of sentence structures and vocabulary.
+            - Each question must have a different theme.
+            - Sentences should be longer and include more detail.
+            - Focus on the topic '{topic}', and ensure the blank is the key part of speech.
+            - Each question must include the correct answer in parentheses at the end.
+            - Do not include any explanations or instructions—only the five questions.
             """
 
-        elif difficulty == 'advanced':
+        elif difficulty == 'expert':
             prompt = f"""
             Generate five **completely new and unique** advanced-level (C1) fill-in-the-blank grammar questions **every time** on the topic '{topic}'.
 
             ### Rules:
-            - The questions should be **more challenging than upper-intermediate (B2) level**, requiring a deep understanding of grammar, context, and vocabulary.
-            - **Ensure varied and sophisticated vocabulary**, avoiding basic words.
-            - **Each question should require nuanced comprehension**, testing knowledge of advanced grammar patterns.
-            - **The blank must be the key part of the sentence** (not an obvious answer).
-            - Each question should contain **one blank represented by '_______'**, with the correct answer provided in parentheses at the end.
-            - Ensure that the questions are **always new and distinct**, avoiding repetition of themes.
-
-            Do not include any explanations or instructions in the response—only the five unique questions.
+            - Generate five unique fill-in-the-blank grammar questions based on the topic '{topic}'.
+            - Each question must have exactly one blank represented by '_______'.
+            - More challenging than intermediate (C1); require expert-level mastery of grammar and context.
+            - Ensure varied and sophisticated vocabulary; avoid basic words.
+            - Each question should require nuanced comprehension; test advanced grammar patterns.
+            - The blank must be the key part of the sentence (not an obvious answer).
+            - Each question must include the correct answer in parentheses at the end.
+            - Do not include any explanations or instructions—only the five questions.
             """
 
-        elif difficulty == 'hard':
-            prompt = f"""
-            Generate five **completely new and unique** hard-level (C2) fill-in-the-blank grammar questions **every time** on the topic '{topic}'.
-
-            ### Rules:
-            - The questions should be **more challenging than advanced(C1) level**, requiring a deep understanding of grammar, context, and vocabulary.
-            - **Ensure varied and sophisticated vocabulary**, avoiding basic words.
-            - **Each question should require nuanced comprehension**, testing knowledge of advanced grammar patterns.
-            - **The blank must be the key part of the sentence** (not an obvious answer).
-            - Each question should contain **one blank represented by '_______'**, with the correct answer provided in parentheses at the end.
-            - Ensure that the questions are **always new and distinct**, avoiding repetition of themes.
-
-            Do not include any explanations or instructions in the response—only the five unique questions.
-            """
+ 
 
         else:
             return jsonify({"error": "Invalid difficulty level"}), 400

writting.py

@@ -109,12 +109,35 @@ def validate_response():
             return jsonify({"error": "Both 'topic' and 'response' fields are required."}), 400
 
         # Define the prompt for GPT to evaluate the response
-        validation_prompt = (
-            f"You are a writing teacher. Evaluate the sentence formation, grammar, and overall writing quality of the following response. "
-            f"Provide constructive feedback highlighting any errors in grammar, spelling, punctuation, and sentence structure. "
-            f"If the response is well-written, acknowledge its strengths. "
-            f"Topic: '{topic}'. Response: '{response_text}'."
-        )
+        # validation_prompt = (
+        #     f"You are a writing teacher. Evaluate the sentence formation, grammar, and overall writing quality of the following response. "
+        #     f"Provide constructive feedback highlighting any errors in grammar, spelling, punctuation, and sentence structure. "
+        #     f"If the response is well-written, acknowledge its strengths. "
+        #     f"Topic: '{topic}'. Response: '{response_text}'."
+        # )
+
+
+
+            validation_prompt = (
+                "You are a kind writing teacher for children (age 9–12). "
+                "Use very simple English (CEFR A2). "
+                "Give feedback in at most 8 lines; each line under 12 words. "
+                "Use active voice. Avoid hard words (no 'analyze', 'implications', etc.). "
+                "If the student copied the topic or wrote too little, say: "
+                "'Please write in your own words.' and give one starter line. "
+                "Format EXACTLY like this:\n"
+                "Title: Simple Feedback\n"
+                "What is good:\n"
+                "- <two short points>\n"
+                "Needs fixing:\n"
+                "- <two short points>\n"
+                "Example fix:\n"
+                "- <rewrite one short sentence>\n"
+                "Score: <number>/10\n"
+                "Rules: Do not use angle brackets in the output. "
+                f"Topic: {topic}\n"
+                f"Student response: {response_text}"
+            )
 
         messages = [
             {"role": "system", "content": "You are a helpful writing teacher."},