Update main.py

main.py

@@ -749,60 +749,114 @@ def admin_remove_member_from_org(org_id, member_uid):
 @app.route('/api/admin/dashboard/stats', methods=['GET'])
 def get_admin_dashboard_stats():
     """
-    Retrieves global statistics for the admin dashboard with correct profit calculation.
-    **FIXED**: Multiplies price and cost by quantity for accurate financial totals.
+    Retrieves global statistics for the admin dashboard, including leaderboards
+    for top users, items, and expenses.
     """
     try:
         verify_admin_and_get_uid(request.headers.get('Authorization'))
 
+        # --- Initialization ---
         all_users_docs = list(db.collection('users').stream())
         all_orgs_docs = list(db.collection('organizations').stream())
         
+        # Data structures for leaderboards
+        user_sales_data = {} # {phone: {'total_revenue': X, 'item_sales': {item: revenue}}}
+        global_item_revenue = {} # {item_name: total_revenue}
+        global_expense_totals = {} # {category: total_amount}
+        phone_to_user_map = {} # Helper to get user info from phone
+
+        # --- First Pass: Get user info and list of approved phones ---
         pending_approvals, approved_users, admin_count = 0, 0, 0
         approved_phone_numbers = []
 
         for doc in all_users_docs:
             user_data = doc.to_dict()
+            phone = user_data.get('phone')
             if user_data.get('phoneStatus') == 'pending':
                 pending_approvals += 1
-            elif user_data.get('phoneStatus') == 'approved':
+            elif user_data.get('phoneStatus') == 'approved' and phone:
                 approved_users += 1
-                if user_data.get('phone'):
-                    approved_phone_numbers.append(user_data.get('phone'))
+                approved_phone_numbers.append(phone)
+                phone_to_user_map[phone] = {
+                    'displayName': user_data.get('displayName', 'N/A'),
+                    'uid': user_data.get('uid')
+                }
             if user_data.get('isAdmin', False):
                 admin_count += 1
         
-        user_stats = {
-            'total': len(all_users_docs), 'admins': admin_count,
-            'approvedForBot': approved_users, 'pendingApproval': pending_approvals,
-        }
+        user_stats = {'total': len(all_users_docs), 'admins': admin_count, 'approvedForBot': approved_users, 'pendingApproval': pending_approvals}
         org_stats = {'total': len(all_orgs_docs)}
 
-        # --- THE FIX IS HERE ---
+        # --- Second Pass: Aggregate financial data for all approved users ---
         total_sales_revenue, total_cogs, total_expenses, sales_count = 0, 0, 0, 0
         
         for phone in approved_phone_numbers:
             try:
                 bot_data_id = phone.lstrip('+')
                 bot_user_ref = db.collection('users').document(bot_data_id)
+                
+                # Initialize user's entry for leaderboard tracking
+                user_sales_data[phone] = {'total_revenue': 0, 'item_sales': {}}
 
+                # Process Sales
                 sales_docs = bot_user_ref.collection('sales').stream()
                 for sale_doc in sales_docs:
                     details = sale_doc.to_dict().get('details', {})
                     quantity = int(details.get('quantity', 1))
                     price = float(details.get('price', 0))
                     cost = float(details.get('cost', 0))
+                    item_name = details.get('item', 'Unknown Item')
+                    sale_revenue = price * quantity
 
-                    total_sales_revenue += price * quantity
+                    # Aggregate for global system stats
+                    total_sales_revenue += sale_revenue
                     total_cogs += cost * quantity
                     sales_count += 1
-                
+                    
+                    # Aggregate for leaderboards
+                    user_sales_data[phone]['total_revenue'] += sale_revenue
+                    user_sales_data[phone]['item_sales'][item_name] = user_sales_data[phone]['item_sales'].get(item_name, 0) + sale_revenue
+                    global_item_revenue[item_name] = global_item_revenue.get(item_name, 0) + sale_revenue
+
+                # Process Expenses
                 expenses_docs = bot_user_ref.collection('expenses').stream()
-                total_expenses += sum(float(doc.to_dict().get('details', {}).get('amount', 0)) for doc in expenses_docs)
+                for expense_doc in expenses_docs:
+                    details = expense_doc.to_dict().get('details', {})
+                    amount = float(details.get('amount', 0))
+                    category = details.get('category', 'Uncategorized')
+                    
+                    total_expenses += amount
+                    global_expense_totals[category] = global_expense_totals.get(category, 0) + amount
+
             except Exception as e:
                 logging.error(f"Admin stats: Could not process data for phone {phone}. Error: {e}")
                 continue
         
+        # --- Post-Processing: Calculate and Rank Leaderboards ---
+
+        # Rank Top Users by Revenue
+        sorted_users = sorted(user_sales_data.items(), key=lambda item: item[1]['total_revenue'], reverse=True)
+        top_users_by_revenue = []
+        for phone, data in sorted_users[:5]:
+            user_info = phone_to_user_map.get(phone, {})
+            # Find this user's top selling item
+            top_item = max(data['item_sales'], key=data['item_sales'].get) if data['item_sales'] else 'N/A'
+            top_users_by_revenue.append({
+                'displayName': user_info.get('displayName'),
+                'uid': user_info.get('uid'),
+                'totalRevenue': round(data['total_revenue'], 2),
+                'topSellingItem': top_item
+            })
+
+        # Rank Top Selling Items Globally
+        sorted_items = sorted(global_item_revenue.items(), key=lambda item: item[1], reverse=True)
+        top_selling_items = [{'item': name, 'totalRevenue': round(revenue, 2)} for name, revenue in sorted_items[:5]]
+
+        # Rank Top Expenses Globally
+        sorted_expenses = sorted(global_expense_totals.items(), key=lambda item: item[1], reverse=True)
+        top_expenses = [{'category': name, 'totalAmount': round(amount, 2)} for name, amount in sorted_expenses[:5]]
+
+        # --- Final Assembly ---
         gross_profit = total_sales_revenue - total_cogs
         net_profit = gross_profit - total_expenses
         
@@ -813,9 +867,17 @@ def get_admin_dashboard_stats():
             'totalNetProfit': round(net_profit, 2),
             'totalSalesCount': sales_count,
         }
-        # --- END OF FIX ---
 
-        return jsonify({'userStats': user_stats, 'organizationStats': org_stats, 'systemStats': system_stats}), 200
+        return jsonify({
+            'userStats': user_stats, 
+            'organizationStats': org_stats,
+            'systemStats': system_stats,
+            'leaderboards': {  # Add the new leaderboards to the response
+                'topUsersByRevenue': top_users_by_revenue,
+                'topSellingItems': top_selling_items,
+                'topExpenses': top_expenses
+            }
+        }), 200
 
     except PermissionError as e:
         return jsonify({'error': str(e)}), 403