Update main.py

main.py

@@ -450,33 +450,59 @@ def admin_get_pending_roles():
         return jsonify(pending_apps or {}), 200
     except Exception as e: return handle_route_errors(e, uid_context=admin_uid)
 
-@app.route('/api/admin/roles/action/<application_id>', methods=['POST'])
-def admin_action_on_role(application_id):
+@app.route('/api/admin/roles/<application_id>/<action>', methods=['POST'])
+def admin_action_on_role(application_id, action):
     auth_header = request.headers.get('Authorization')
     admin_uid = None
     try:
         admin_uid = verify_admin(auth_header)
-        if not FIREBASE_INITIALIZED: return jsonify({'error': 'Server configuration error: Firebase not ready.'}), 503
-        data = request.get_json(); action = data.get('action')
-        if action not in ['approve', 'reject']: return jsonify({'error': 'Invalid action.'}), 400
-        app_ref = db.reference(f'role_applications/{application_id}', app=db_app); application = app_ref.get()
-        if not application or application.get('status') != 'pending': return jsonify({'error': 'App not found or not pending.'}), 404
-        user_id, role = application['user_id'], application['role']
+        if not FIREBASE_INITIALIZED: 
+            return jsonify({'error': 'Server configuration error: Firebase not ready.'}), 503
+        
+        if action not in ['approve', 'reject']: 
+            return jsonify({'error': 'Invalid action.'}), 400
+        
+        app_ref = db.reference(f'role_applications/{application_id}', app=db_app)
+        application = app_ref.get()
+        
+        if not application or application.get('status') != 'pending': 
+            return jsonify({'error': 'App not found or not pending.'}), 404
+        
+        user_id = application['user_id']
+        role = application['role']
         user_profile_ref = db.reference(f'users/{user_id}', app=db_app)
         update_time = datetime.now(timezone.utc).isoformat()
         message_text = ""
+        
         if action == 'approve':
-            app_ref.update({'status': 'approved', 'reviewed_by': admin_uid, 'reviewed_at': update_time})
+            app_ref.update({
+                'status': 'approved', 
+                'reviewed_by': admin_uid, 
+                'reviewed_at': update_time
+            })
             user_profile_ref.child('roles').update({role: True})
             user_profile_ref.child('role_applications').update({role: 'approved'})
             message_text = f"Role {role} for user {user_id} approved."
-        else: # reject
-            app_ref.update({'status': 'rejected', 'reviewed_by': admin_uid, 'reviewed_at': update_time})
+        else:  # reject
+            app_ref.update({
+                'status': 'rejected', 
+                'reviewed_by': admin_uid, 
+                'reviewed_at': update_time
+            })
             user_profile_ref.child('role_applications').update({role: 'rejected'})
             message_text = f"Role {role} for user {user_id} rejected."
-        _send_system_notification(user_id, f"Your application for the '{role}' role has been {action}d.", "role_status", f"/profile/roles")
+        
+        _send_system_notification(
+            user_id, 
+            f"Your application for the '{role}' role has been {action}d.", 
+            "role_status", 
+            f"/profile/roles"
+        )
+        
         return jsonify({'success': True, 'message': message_text}), 200
-    except Exception as e: return handle_route_errors(e, uid_context=admin_uid)
+        
+    except Exception as e: 
+        return handle_route_errors(e, uid_context=admin_uid)
 
 #--- Marketplace Endpoints ---
 def _create_listing(uid_lister, listing_type, data):