Update main.py

main.py

@@ -1271,40 +1271,28 @@ def view_quizzes():
 
 @app.route('/api/user/performance', methods=['GET'])
 def get_user_performance():
-    """Retrieves user's quiz performance grouped by quiz"""
+    """Retrieves user's quiz performance and provides simple suggestions."""
     try:
-        # Authentication
+        # --- Authentication ---
         user, error = verify_token(request.headers.get('Authorization'))
         if error: 
             return jsonify({'error': error['error']}), error['status']
         
-        # Get all quiz attempts with related data
+        # --- Query Attempts with Proper Error Handling ---
         attempts_res = supabase.table('quiz_attempts') \
-            .select('''
-                id,
-                quiz_id,
-                score,
-                submitted_at,
-                quizzes(
-                    id,
-                    difficulty,
-                    created_at,
-                    notes!inner(
-                        id,
-                        study_materials!inner(title)
-                    )
-                )
-            ''') \
+            .select('id, quiz_id, score, submitted_at, quizzes(id, difficulty, created_at, notes(study_materials(title)))') \
             .eq('user_id', user.id) \
             .order('submitted_at', desc=True) \
             .execute()
-
-        if attempts_res.error:
+        
+        if hasattr(attempts_res, 'error') and attempts_res.error:
             raise Exception(attempts_res.error.message)
+        
+        attempts_data = attempts_res.data
 
-        # Group attempts by quiz
+        # --- Group Attempts by Quiz ---
         quizzes = {}
-        for attempt in attempts_res.data:
+        for attempt in attempts_data:
             quiz_id = attempt['quizzes']['id']
             if quiz_id not in quizzes:
                 quizzes[quiz_id] = {
@@ -1314,39 +1302,52 @@ def get_user_performance():
                         'difficulty': attempt['quizzes']['difficulty'],
                         'created_at': attempt['quizzes']['created_at']
                     },
-                    'attempts': [],
-                    'average_score': 0
+                    'attempts': []
                 }
             quizzes[quiz_id]['attempts'].append(attempt)
 
-        # Calculate averages and format
+        # --- Calculate Averages ---
         performance_data = []
-        for quiz in quizzes.values():
-            scores = [a['score'] for a in quiz['attempts']]
-            quiz['average_score'] = sum(scores) / len(scores) if scores else 0
-            quiz['attempt_count'] = len(scores)
-            performance_data.append(quiz)
-
-        # Sort quizzes by most recent attempt
-        performance_data.sort(
-            key=lambda x: max(a['submitted_at'] for a in x['attempts']), 
-            reverse=True
-        )
+        overall_scores = []
+        
+        for quiz_id, quiz_data in quizzes.items():
+            scores = [a['score'] for a in quiz_data['attempts']]
+            avg_score = sum(scores) / len(scores) if scores else 0
+            overall_scores.extend(scores)
+            
+            performance_data.append({
+                **quiz_data,
+                'average_score': avg_score,
+                'attempt_count': len(scores)
+            })
 
-        # Generate suggestions
-        overall_avg = sum(q['average_score'] for q in performance_data) / len(performance_data) if performance_data else 0
-        suggestions = generate_suggestions(performance_data, overall_avg)
+        # --- Calculate Overall Average ---
+        average_score = sum(overall_scores) / len(overall_scores) if overall_scores else 0
+
+        # --- Generate Suggestions ---
+        suggestions = []
+        if performance_data:
+            if average_score < 60:
+                suggestions.append("Your average score is a bit low. Try reviewing the notes more thoroughly before taking quizzes.")
+                # Find lowest scoring quiz
+                weakest_quiz = min(performance_data, key=lambda x: x['average_score'])
+                suggestions.append(f"Focus on: '{weakest_quiz['quiz_info']['title']}' (current average: {weakest_quiz['average_score']:.0f}%)")
+            elif average_score > 85:
+                suggestions.append("Great job! Try some 'hard' difficulty quizzes.")
+            else:
+                suggestions.append("You're making good progress! Keep practicing.")
 
         return jsonify({
             'success': True,
-            'average_score': round(overall_avg, 2),
-            'quizzes': performance_data,
+            'average_score': round(average_score, 2),
+            'quizzes': performance_data,  # Changed from recent_attempts to quizzes
             'suggestions': suggestions
         })
 
     except Exception as e:
-        logging.error(f"Performance error: {traceback.format_exc()}")
-        return jsonify({'error': str(e)}), 500
+        logging.error(f"Performance endpoint error: {str(e)}")
+        logging.error(traceback.format_exc())
+        return jsonify({'error': 'Internal server error'}), 500
 
 def generate_suggestions(quizzes, overall_avg):
     """Generate personalized suggestions based on quiz performance"""