Update Dockerfile

Dockerfile

@@ -1,5 +1,4 @@
 # 1. Base image
-# Using a more specific Python version is good practice
 FROM python:3.9-slim
 
 # 2. Prevent __pycache__, buffer logs
@@ -7,28 +6,25 @@ ENV PYTHONDONTWRITEBYTECODE=1
 ENV PYTHONUNBUFFERED=1
 
 # 3. Define where uploads go and where the database file will live
-# Use /tmp for directories the non-root user needs to write to.
+#    Both should be in a writable location like /tmp
 ENV UPLOAD_DIR=/tmp/uploads
-# Specify the absolute path for the database file in /tmp
-ENV DATABASE_URL=sqlite:////tmp/patients.db
-# Also explicitly tell Flask where the instance path is, resolving the PermissionError
-ENV FLASK_INSTANCE_PATH=/tmp
+# Define the database URL. With instance_path=/tmp in app.py,
+# 'sqlite:///patients.db' will resolve to /tmp/patients.db
+ENV DATABASE_URL=sqlite:///patients.db
 
 # 4. Set working dir
 WORKDIR /app
 
 # 5. System deps
 # Install build-essential (for compiling packages), zlib1g-dev and libjpeg-dev
-# (often needed by reportlab for image/compression support), and any other
-# libs required by your specific python packages (check their docs).
-# Add libpq-dev if you were using PostgreSQL later.
-# Add libsqlite3-dev if encountering issues with the sqlite driver (usually not needed for basic usage).
+# (often needed by reportlab for image/compression support).
+# libsqlite3-dev might be needed for some advanced sqlite features or drivers,
+# uncomment if you hit db issues, but usually not required for basic sqlite3.
 RUN apt-get update \
  && apt-get install -y --no-install-recommends \
     build-essential \
     zlib1g-dev \
     libjpeg-dev \
-    # Potentially add libsqlite3-dev if you encounter driver issues:
     # libsqlite3-dev \
  && rm -rf /var/lib/apt/lists/*
 
@@ -38,24 +34,20 @@ COPY requirements.txt .
 RUN pip install --no-cache-dir -r requirements.txt
 
 # 7. Copy app code
-# This includes app.py, index.html, doctor_dashboard.html, etc.
 COPY . .
 
-# 8. Pre-create the uploads directory and the database parent directory in /tmp
-# /tmp itself usually exists and is writable, but explicit creation is safer.
-# Also explicitly create the Flask instance path directory.
-RUN mkdir -p "${UPLOAD_DIR}/pdfs" "${FLASK_INSTANCE_PATH}"
+# 8. Pre-create the uploads directory in /tmp
+#    The Flask instance path (/tmp) will be created by Flask itself when needed
+#    within the writable /tmp directory.
+RUN mkdir -p "${UPLOAD_DIR}/pdfs"
 
 # 9. Entrypoint: Ensure runtime directories exist, then launch gunicorn
 #    The database file and tables will be created automatically by db.create_all()
 #    when the Flask app context is first used (which Gunicorn does on boot).
 RUN printf '#!/bin/sh\n\
 # Ensure the upload directory exists at runtime (redundant but safe for /tmp)
+# Flask instance_path=/tmp is handled by app.py and directory creation within /tmp\n\
 mkdir -p "${UPLOAD_DIR}/pdfs"\n\
-# Ensure the Flask instance path exists (redundant but safe for /tmp)
-mkdir -p "${FLASK_INSTANCE_PATH}"\n\
-# Ensure the database file\'s parent directory exists (redundant for /tmp)
-# mkdir -p "$(dirname "${DATABASE_URL#sqlite:////}")"\n\
 \n\
 # Execute Gunicorn to run the Flask app\n\
 # Pass environment variables explicitly or rely on Docker --env flags\n\
@@ -71,22 +63,12 @@ EXPOSE 7860
 ENTRYPOINT ["/entrypoint.sh"]
 
 # Important note for production persistence with SQLite:
-# The patients.db file will be created inside the container\'s /tmp directory.
+# The patients.db file and uploaded PDFs will be created inside the container\'s /tmp directory.
 # To persist this data between container runs or updates, you MUST mount a Docker Volume
-# to the directory where the database file is located (in this case, /tmp).
-# NOTE: Mounting /tmp is a common pattern but means EVERYTHING in /tmp is persisted.
-# A safer approach for SQLite persistence is often to use a dedicated volume just
-# for the database file's directory, e.g., placing it in a custom directory like /data
-# instead of /tmp, and mounting a volume to /data.
+# to the /tmp directory when you run the container.
 #
-# Example using docker run (mounting /tmp for persistence - includes DB and Uploads):
+# Example using docker run:
 # docker run -d -p 7860:7860 -v my_tmp_volume:/tmp -e GENAI_API_KEY="your_key" -e TWILIO_ACCOUNT_SID="..." your_image_name
 #
-# Example using docker run (more secure: create a custom data dir in the Dockerfile and mount a volume there)
-# Dockerfile addition: RUN mkdir /data && chown youruser:yourgroup /data (if using a specific user)
-# Flask config change: ENV DATABASE_URL=sqlite:////data/patients.db
-# Docker run command: docker run -d -p 7860:7860 -v my_db_volume:/data ... your_image_name
-# (For this specific Dockerfile, mounting /tmp is the easiest fix.)
-#
 # For production deployments with orchestration (Docker Compose, Kubernetes),
 # define volumes and environment variables in their configuration files.