rajkumarrawal commited on
Commit
75e5187
·
1 Parent(s): 10654cb

refactor(AgentManager): rename public attributes to private

Browse files

- Changed `performance_metrics` to `_performance_metrics` and `request_queue` to `_request_queue`
- Set `request_queue` to `None` in `__init__` for lazy initialization
- Updated references in `update_performance_metrics`, `get_performance_summary`, and `SpacesApp`
- Improves encapsulation by indicating internal state

Files changed (1) hide show
  1. app.py +17 -17
app.py CHANGED
@@ -211,8 +211,8 @@ class AgentManager:
211
  self.config = config
212
  self.agents = {}
213
  self.agent_stats = {}
214
- self.request_queue = asyncio.Queue(maxsize=config.config["max_concurrent_requests"])
215
- self.performance_metrics = {
216
  "total_requests": 0,
217
  "successful_requests": 0,
218
  "failed_requests": 0,
@@ -288,12 +288,12 @@ class AgentManager:
288
 
289
  def update_performance_metrics(self, agent_type: str, response_time: float, success: bool):
290
  """Update performance metrics for monitoring."""
291
- self.performance_metrics["total_requests"] += 1
292
 
293
  if success:
294
- self.performance_metrics["successful_requests"] += 1
295
  else:
296
- self.performance_metrics["failed_requests"] += 1
297
 
298
  # Update agent-specific stats
299
  if agent_type in self.agent_stats:
@@ -314,30 +314,30 @@ class AgentManager:
314
  )
315
 
316
  # Update global metrics
317
- self.performance_metrics["average_response_time"] = (
318
- (self.performance_metrics["average_response_time"] * (self.performance_metrics["total_requests"] - 1) + response_time)
319
- / self.performance_metrics["total_requests"]
320
  )
321
 
322
  # Add system metrics
323
- self.performance_metrics["memory_usage"].append(psutil.virtual_memory().percent)
324
- self.performance_metrics["cpu_usage"].append(psutil.cpu_percent())
325
- self.performance_metrics["timestamps"].append(datetime.utcnow().isoformat())
326
 
327
  # Keep only recent metrics
328
  max_metrics = 1000
329
  for key in ["memory_usage", "cpu_usage", "timestamps"]:
330
- if len(self.performance_metrics[key]) > max_metrics:
331
- self.performance_metrics[key] = self.performance_metrics[key][-max_metrics:]
332
 
333
  def get_performance_summary(self) -> Dict[str, Any]:
334
  """Get performance summary for monitoring."""
335
  return {
336
- "total_requests": self.performance_metrics["total_requests"],
337
  "success_rate": (
338
- self.performance_metrics["successful_requests"] / max(1, self.performance_metrics["total_requests"])
339
  ),
340
- "average_response_time": self.performance_metrics["average_response_time"],
341
  "current_memory_usage": psutil.virtual_memory().percent,
342
  "current_cpu_usage": psutil.cpu_percent(),
343
  "agent_stats": self.agent_stats,
@@ -777,7 +777,7 @@ class SpacesApp:
777
  """Get analytics data for plots and tables."""
778
  try:
779
  # Get performance metrics
780
- metrics = self.agent_manager.performance_metrics
781
 
782
  # Create metrics plot
783
  if len(metrics["timestamps"]) > 1:
 
211
  self.config = config
212
  self.agents = {}
213
  self.agent_stats = {}
214
+ self._request_queue = None
215
+ self._performance_metrics = {
216
  "total_requests": 0,
217
  "successful_requests": 0,
218
  "failed_requests": 0,
 
288
 
289
  def update_performance_metrics(self, agent_type: str, response_time: float, success: bool):
290
  """Update performance metrics for monitoring."""
291
+ self._performance_metrics["total_requests"] += 1
292
 
293
  if success:
294
+ self._performance_metrics["successful_requests"] += 1
295
  else:
296
+ self._performance_metrics["failed_requests"] += 1
297
 
298
  # Update agent-specific stats
299
  if agent_type in self.agent_stats:
 
314
  )
315
 
316
  # Update global metrics
317
+ self._performance_metrics["average_response_time"] = (
318
+ (self._performance_metrics["average_response_time"] * (self._performance_metrics["total_requests"] - 1) + response_time)
319
+ / self._performance_metrics["total_requests"]
320
  )
321
 
322
  # Add system metrics
323
+ self._performance_metrics["memory_usage"].append(psutil.virtual_memory().percent)
324
+ self._performance_metrics["cpu_usage"].append(psutil.cpu_percent())
325
+ self._performance_metrics["timestamps"].append(datetime.utcnow().isoformat())
326
 
327
  # Keep only recent metrics
328
  max_metrics = 1000
329
  for key in ["memory_usage", "cpu_usage", "timestamps"]:
330
+ if len(self._performance_metrics[key]) > max_metrics:
331
+ self._performance_metrics[key] = self._performance_metrics[key][-max_metrics:]
332
 
333
  def get_performance_summary(self) -> Dict[str, Any]:
334
  """Get performance summary for monitoring."""
335
  return {
336
+ "total_requests": self._performance_metrics["total_requests"],
337
  "success_rate": (
338
+ self._performance_metrics["successful_requests"] / max(1, self._performance_metrics["total_requests"])
339
  ),
340
+ "average_response_time": self._performance_metrics["average_response_time"],
341
  "current_memory_usage": psutil.virtual_memory().percent,
342
  "current_cpu_usage": psutil.cpu_percent(),
343
  "agent_stats": self.agent_stats,
 
777
  """Get analytics data for plots and tables."""
778
  try:
779
  # Get performance metrics
780
+ metrics = self.agent_manager._performance_metrics
781
 
782
  # Create metrics plot
783
  if len(metrics["timestamps"]) > 1: