Update app.py

app.py

@@ -83,12 +83,9 @@ class SimpleChromeController:
     def is_chrome_accessible(self):
         """Check if Chrome debugging port is accessible"""
         try:
-            sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-            sock.settimeout(2)
-            result = sock.connect_ex(('127.0.0.1', 9222))
-            sock.close()
-            return result == 0
-        except Exception:
+            with socket.create_connection(("127.0.0.1", 9222), timeout=2) as sock:
+                return True
+        except (socket.timeout, ConnectionRefusedError):
             return False
 
     def start_chrome(self):
@@ -135,6 +132,7 @@ class SimpleChromeController:
         chrome_options.add_argument("--no-sandbox")
         chrome_options.add_argument("--disable-dev-shm-usage")
         
+        # Use a cached driver install
         service = Service(ChromeDriverManager().install())
         return webdriver.Chrome(service=service, options=chrome_options)
 
@@ -146,17 +144,15 @@ class SimpleChromeController:
         if not self.is_chrome_accessible():
             return "❌ Chrome is not running. Please start Chrome first."
         
-        # Add protocol if missing
         if not url.startswith(('http://', 'https://')):
             url = 'https://' + url.strip()
         
         driver = None
         try:
             driver = self.get_driver()
-            driver.set_window_size(1920, 1080)
+            driver.set_page_load_timeout(20)
             driver.get(url)
             
-            # Wait for page to load
             WebDriverWait(driver, 10).until(
                 lambda d: d.execute_script("return document.readyState") == "complete"
             )
@@ -168,10 +164,7 @@ class SimpleChromeController:
             return f"❌ Error navigating to URL: {str(e)}"
         finally:
             if driver:
-                try:
-                    driver.quit()
-                except:
-                    pass
+                driver.quit()
 
     def take_screenshot(self):
         """Take a screenshot of the current page"""
@@ -181,9 +174,7 @@ class SimpleChromeController:
         driver = None
         try:
             driver = self.get_driver()
-            driver.set_window_size(1920, 1080)
             
-            # Get current page info
             current_url = driver.current_url
             if not current_url or current_url == "data:,":
                 driver.get("https://www.google.com")
@@ -191,13 +182,9 @@ class SimpleChromeController:
                     lambda d: d.execute_script("return document.readyState") == "complete"
                 )
             
-            # Take screenshot
             screenshot_data = driver.get_screenshot_as_png()
-            
-            # Convert to PIL Image
             screenshot_image = Image.open(io.BytesIO(screenshot_data))
             
-            # Get page info
             page_title = driver.title or "Unknown"
             page_url = driver.current_url or "Unknown"
             
@@ -207,10 +194,7 @@ class SimpleChromeController:
             return None, f"❌ Error taking screenshot: {str(e)}"
         finally:
             if driver:
-                try:
-                    driver.quit()
-                except:
-                    pass
+                driver.quit()
 
     def execute_javascript(self, js_code):
         """Execute JavaScript code in the browser"""
@@ -230,55 +214,34 @@ class SimpleChromeController:
             return f"❌ Error executing JavaScript: {str(e)}"
         finally:
             if driver:
-                try:
-                    driver.quit()
-                except:
-                    pass
+                driver.quit()
 
     def kill_chrome(self):
         """Kill all Chrome processes"""
         self.is_running = False
-        
-        killed_processes = []
-        
-        # Kill Chrome processes by name
+        killed_processes = 0
+
         try:
             for proc in psutil.process_iter(['pid', 'name']):
-                if proc.info['name'] and 'chrome' in proc.info['name'].lower():
+                if 'chrome' in proc.info['name'].lower():
                     try:
                         proc.terminate()
-                        killed_processes.append(f"PID {proc.info['pid']}")
+                        killed_processes += 1
                     except (psutil.NoSuchProcess, psutil.AccessDenied):
                         pass
         except Exception:
             pass
         
-        # Kill the main process if it exists
         if self.chrome_process:
             try:
-                if hasattr(os, 'killpg'):
-                    os.killpg(os.getpgid(self.chrome_process.pid), 15)
-                else:
-                    self.chrome_process.terminate()
-                
-                self.chrome_process.wait(timeout=5)
+                os.killpg(os.getpgid(self.chrome_process.pid), 9)
             except:
-                try:
-                    if hasattr(os, 'killpg'):
-                        os.killpg(os.getpgid(self.chrome_process.pid), 9)
-                    else:
-                        self.chrome_process.kill()
-                except:
-                    pass
+                 pass
             self.chrome_process = None
         
         time.sleep(1)
         
-        result = "🛑 Chrome processes terminated"
-        if killed_processes:
-            result += f" (killed: {', '.join(killed_processes)})"
-        
-        return result
+        return f"🛑 Chrome processes terminated ({killed_processes} killed)"
 
     def get_status(self):
         """Get current Chrome status"""
@@ -287,114 +250,72 @@ class SimpleChromeController:
         else:
             return "⭕ Chrome is not running or not accessible"
 
-# Initialize the controller
 chrome_controller = SimpleChromeController()
 
-# Create simple Gradio interface using only basic components
-def create_simple_interface():
-    
-    with gr.Blocks(title="Chrome Controller") as demo:
-        
-        gr.Markdown("# 🌐 Chrome Controller for Hugging Face Spaces")
-        gr.Markdown("Control a headless Chrome instance - Simple & Stable Version")
-        
-        # Browser Control Section
-        gr.Markdown("## 🚀 Browser Control")
-        with gr.Row():
-            start_btn = gr.Button("🚀 Start Chrome", variant="primary")
-            status_btn = gr.Button("📊 Check Status")
-            stop_btn = gr.Button("🛑 Stop Chrome", variant="stop")
-        
-        status_output = gr.Textbox(
-            label="Status", 
-            interactive=False,
-            lines=4,
-            value="Chrome Controller ready. Click 'Start Chrome' to begin."
-        )
-        
-        # Navigation Section
-        gr.Markdown("## 🧭 Navigation & Screenshots")
-        with gr.Row():
-            url_input = gr.Textbox(
-                label="URL to Navigate",
-                value="google.com",
-                lines=1
-            )
-            navigate_btn = gr.Button("🧭 Navigate", variant="primary")
-            screenshot_btn = gr.Button("📸 Take Screenshot", variant="secondary")
-        
-        screenshot_output = gr.Image(
-            label="Screenshot",
-            height=400
-        )
-        
-        # JavaScript Section
-        gr.Markdown("## ⚡ JavaScript Execution")
-        js_input = gr.Textbox(
-            label="JavaScript Code",
-            lines=6,
-            value="// Enter JavaScript code here\n// Example: document.title"
-        )
-        execute_btn = gr.Button("⚡ Execute JavaScript", variant="primary")
-        js_output = gr.Textbox(
-            label="Execution Result",
-            interactive=False,
-            lines=6
-        )
-        
-        # Event handlers
-        start_btn.click(
-            fn=chrome_controller.start_chrome,
-            outputs=status_output
-        )
+def create_interface():
+    with gr.Blocks(theme=gr.themes.Soft(), title="Chrome Controller") as demo:
+        gr.Markdown("# 🌐 Chrome Controller Pro")
+        gr.Markdown("Control a headless Chrome instance for advanced web automation.")
+
+        with gr.Tabs():
+            with gr.TabItem("🚀 Control & Status"):
+                with gr.Row():
+                    start_btn = gr.Button("🚀 Start Chrome", variant="primary", scale=1)
+                    stop_btn = gr.Button("🛑 Stop Chrome", variant="stop", scale=1)
+                    status_btn = gr.Button("📊 Check Status", scale=1)
+                
+                status_output = gr.Textbox(
+                    label="Status", 
+                    interactive=False,
+                    lines=5,
+                    value="Chrome is not running. Click 'Start Chrome' to begin."
+                )
+
+            with gr.TabItem("🧭 Navigate & Screenshot"):
+                with gr.Row():
+                    url_input = gr.Textbox(label="URL", placeholder="e.g., google.com", scale=4)
+                    navigate_btn = gr.Button("🧭 Navigate", variant="primary", scale=1)
+                
+                screenshot_btn = gr.Button("📸 Take Screenshot", variant="secondary")
+                
+                screenshot_output = gr.Image(label="Screenshot", type="pil", height=500)
+                screenshot_status = gr.Textbox(label="Action Status", interactive=False)
+
+            with gr.TabItem("⚡ Execute JavaScript"):
+                js_input = gr.Textbox(
+                    label="JavaScript Code",
+                    lines=8,
+                    value="// Example: return document.title;"
+                )
+                execute_btn = gr.Button("⚡ Execute JS", variant="primary")
+                js_output = gr.Textbox(label="JS Execution Result", interactive=False, lines=8)
         
-        status_btn.click(
-            fn=chrome_controller.get_status,
-            outputs=status_output
-        )
+        # Event Handlers
+        start_btn.click(chrome_controller.start_chrome, outputs=status_output)
+        stop_btn.click(chrome_controller.kill_chrome, outputs=status_output)
+        status_btn.click(chrome_controller.get_status, outputs=status_output)
         
         navigate_btn.click(
-            fn=chrome_controller.navigate_to_url,
-            inputs=url_input,
-            outputs=status_output
+            chrome_controller.navigate_to_url, 
+            inputs=url_input, 
+            outputs=screenshot_status
         )
-        
         screenshot_btn.click(
-            fn=chrome_controller.take_screenshot,
-            outputs=[screenshot_output, status_output]
+            chrome_controller.take_screenshot, 
+            outputs=[screenshot_output, screenshot_status]
         )
-        
         execute_btn.click(
-            fn=chrome_controller.execute_javascript,
+            chrome_controller.execute_javascript,
             inputs=js_input,
             outputs=js_output
         )
-        
-        stop_btn.click(
-            fn=chrome_controller.kill_chrome,
-            outputs=status_output
-        )
-        
-        # Help section
-        gr.Markdown("""
-        ### 💡 Example JavaScript Commands:
-        - `document.title` - Get page title
-        - `window.location.href` - Get current URL  
-        - `document.body.innerHTML` - Get page HTML
-        - `document.querySelectorAll('a').length` - Count links
-        - `window.scrollTo(0, document.body.scrollHeight)` - Scroll to bottom
-        """)
-    
+
     return demo
 
 if __name__ == "__main__":
-    # Create and launch the interface
-    demo = create_simple_interface()
-    
-    # Launch with settings that work reliably on HF Spaces
+    demo = create_interface()
     demo.launch(
         server_name="0.0.0.0",
         server_port=7860,
-        share=False,
-        show_error=True
+        share=True  # Important for Hugging Face Spaces
     )