Spaces:
Running
Running
File size: 27,581 Bytes
b8277c4 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 | """Simplified API tests for the data federation endpoints.
This module tests the core API functionality with proper mocking.
"""
import json
import pytest
import sys
import os
from unittest.mock import MagicMock, patch
from datetime import datetime
from fastapi.testclient import TestClient
from fastapi import FastAPI
# Add parent to path for imports
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '../..')))
from backend.data_sources.api import router, get_redis_client, get_minio_client
from backend.core.auth import AuthUser, get_current_user
from backend.data_sources.jobs import JobStatus
# Create test app
app = FastAPI()
app.include_router(router)
# Mock get_current_user to always return a valid AuthUser
def mock_get_current_user():
return AuthUser({
"id": "test_user",
"user_metadata": {
"tenant_id": "test_tenant",
"role": "user"
}
})
app.dependency_overrides[get_current_user] = mock_get_current_user
# Mock get_tenant_config to always return a valid data source for test_tenant
def mock_get_tenant_config(tenant_id, redis_client):
if tenant_id == "test_tenant":
return [{
"source_name": "sample_db",
"source_type": "ibis",
"config": {
"uri": "mysql+pymysql://root:bwgadmin%402023@65.0.127.253:3306/bookwedgo"
}
}]
return []
import backend.data_sources.api as api_module
app.dependency_overrides[api_module.get_tenant_config] = mock_get_tenant_config
client = TestClient(app)
class TestJobSchemas:
"""Tests for Pydantic schema validation."""
def test_valid_job_schema(self):
"""Test that a valid job request passes validation."""
job_request = {
"payload": {
"plan": [
{
"source": "test_db",
"query": {
"operation": "table",
"name": "orders"
}
}
],
"tenant_id": "test_tenant"
}
}
# This should not raise validation errors
with patch('backend.data_sources.api.get_tenant_config') as mock_config, \
patch('backend.data_sources.worker.process_federated_job.delay') as mock_celery:
mock_config.return_value = [{"source_name": "test_db", "source_type": "ibis", "config": {"uri": "duckdb:///:memory:"}}]
response = client.post("/api/v1/data-sources/jobs", json=job_request)
assert response.status_code == 201
mock_celery.assert_called_once()
def test_invalid_ast_operation(self):
"""Test that invalid AST operations are rejected."""
job_request = {
"payload": {
"plan": [
{
"source": "test_db",
"query": {
"operation": "delete_all", # Invalid operation
"name": "orders"
}
}
],
"tenant_id": "test_tenant"
}
}
response = client.post("/api/v1/data-sources/jobs", json=job_request)
assert response.status_code == 422
def test_table_operation_missing_name(self):
"""Test that table operations require a name field."""
job_request = {
"payload": {
"plan": [
{
"source": "test_db",
"query": {
"operation": "table"
# Missing 'name' field
}
}
],
"tenant_id": "test_tenant"
}
}
# This should fail at Pydantic validation level (before processing)
response = client.post("/api/v1/data-sources/jobs", json=job_request)
assert response.status_code == 422
def test_filter_operation_requires_predicate(self):
"""Test that filter operations require a predicate."""
job_request = {
"payload": {
"plan": [
{
"source": "test_db",
"query": {
"operation": "filter",
"source": {"operation": "table", "name": "orders"}
# Missing 'predicate' field
}
}
],
"tenant_id": "test_tenant"
}
}
response = client.post("/api/v1/data-sources/jobs", json=job_request)
assert response.status_code == 422
def test_valid_filter_operation(self):
"""Test that valid filter operations pass validation."""
job_request = {
"payload": {
"plan": [
{
"source": "test_db",
"query": {
"operation": "filter",
"source": {"operation": "table", "name": "orders"},
"predicate": {
"column": "amount",
"operation": "gt",
"value": 100
}
}
}
],
"tenant_id": "test_tenant"
}
}
with patch('backend.data_sources.api.get_tenant_config') as mock_config, \
patch('backend.data_sources.worker.process_federated_job.delay') as mock_celery:
mock_config.return_value = [{"source_name": "test_db", "source_type": "ibis", "config": {"uri": "duckdb:///:memory:"}}]
response = client.post("/api/v1/data-sources/jobs", json=job_request)
assert response.status_code == 201
mock_celery.assert_called_once()
def test_empty_plan_rejected(self):
"""Test that empty plans are rejected."""
job_request = {
"payload": {
"plan": [], # Empty plan
"tenant_id": "test_tenant"
}
}
response = client.post("/api/v1/data-sources/jobs", json=job_request)
assert response.status_code == 422
class TestJobEndpoints:
"""Tests for job-related endpoints with proper mocking."""
@patch('backend.data_sources.api.get_redis_client')
@patch('backend.data_sources.api.get_minio_client')
@patch('backend.data_sources.api.get_tenant_config')
@patch('backend.data_sources.worker.process_federated_job.delay')
def test_create_job_success(self, mock_celery, mock_config, mock_minio, mock_redis):
"""Test successful job creation."""
# Setup mocks
mock_redis.return_value = MagicMock()
mock_minio.return_value = MagicMock()
mock_config.return_value = [{"source_name": "test_db", "source_type": "ibis", "config": {"uri": "duckdb:///:memory:"}}]
job_request = {
"payload": {
"plan": [{"source": "test_db", "query": {"operation": "table", "name": "orders"}}],
"tenant_id": "test_tenant"
}
}
response = client.post("/api/v1/data-sources/jobs", json=job_request)
assert response.status_code == 201
data = response.json()
assert "job_id" in data
assert data["status"] == "pending"
mock_celery.assert_called_once()
def test_get_job_results(self):
"""Test getting job results."""
mock_redis_instance = MagicMock()
# Mock completed job
metadata = {
"job_id": "test-job-123",
"tenant_id": "test_tenant",
"status": "completed",
"created_at": datetime.utcnow().isoformat(),
"completed_at": datetime.utcnow().isoformat(),
"result_location": "redis://job:test-job-123:results"
}
results = {"step_1": [{"id": 1, "amount": 100}]}
mock_redis_instance.get.side_effect = [
json.dumps(metadata),
json.dumps(results)
]
# Override the dependency
app.dependency_overrides[get_redis_client] = lambda: mock_redis_instance
try:
response = client.get("/api/v1/data-sources/results/test-job-123")
assert response.status_code == 200
data = response.json()
assert data["job_id"] == "test-job-123"
assert data["status"] == "completed"
assert "results" in data
finally:
# Clean up dependency override
app.dependency_overrides.pop(get_redis_client, None)
@patch('backend.data_sources.api.get_redis_client')
def test_get_job_not_found(self, mock_redis):
"""Test getting results for non-existent job."""
mock_redis_instance = MagicMock()
mock_redis.return_value = mock_redis_instance
mock_redis_instance.get.return_value = None
response = client.get("/api/v1/data-sources/results/nonexistent")
assert response.status_code == 404
@patch('backend.data_sources.api.get_redis_client')
@patch('backend.data_sources.api.get_minio_client')
@patch('backend.data_sources.api.get_tenant_config')
@patch('backend.data_sources.api.FederationAgent')
def test_get_schema(self, mock_agent, mock_config, mock_minio, mock_redis):
"""Test getting schema for a data source."""
# Setup mocks
mock_redis_instance = MagicMock()
mock_redis.return_value = mock_redis_instance
mock_redis_instance.get.return_value = None # No cache
mock_config.return_value = [{"source_name": "test_db", "source_type": "ibis", "config": {"uri": "duckdb:///:memory:"}}]
mock_connector = MagicMock()
mock_connector.get_schema.return_value = '{"tables": ["orders"]}'
mock_agent_instance = MagicMock()
mock_agent_instance.connectors = {"test_db": mock_connector}
mock_agent.return_value = mock_agent_instance
response = client.get("/api/v1/data-sources/schema/test_db?tenant_id=test_tenant")
assert response.status_code == 200
data = response.json()
assert data["source_name"] == "test_db"
assert "tables" in data["schema"]
# ============================================================================
# Test Schema Search Endpoint (Section 3.7 - Hybrid Agent)
# ============================================================================
class TestSchemaSearchEndpoint:
"""Tests for the /schema/search endpoint with metadata support."""
@patch('backend.data_sources.schema_search.format_search_results')
@patch('backend.data_sources.schema_search.rank_tables_for_keywords')
@patch('backend.data_sources.schema_search.build_relationship_graph')
@patch('backend.data_sources.schema_search.build_keyword_index')
@patch('backend.data_sources.schema_search.flatten_schema')
@patch('backend.data_sources.connectors.ibis_connector.IbisConnector')
@patch('data_sources.api.get_redis_client')
@patch('data_sources.api.get_minio_client')
@patch('data_sources.api.get_tenant_config')
@patch('data_sources.api.FederationAgent')
def test_schema_search_basic(self, mock_agent, mock_config, mock_minio, mock_redis,
mock_ibis_connector, mock_flatten, mock_build_index,
mock_build_graph, mock_rank_tables, mock_format_results):
"""Test basic schema search with keywords only."""
# Setup mocks
mock_redis_instance = MagicMock()
mock_redis.return_value = mock_redis_instance
mock_redis_instance.get.return_value = None # No cache
mock_config.return_value = [
{"source_name": "sample_db", "source_type": "ibis", "config": {"uri": "mysql+pymysql://root:bwgadmin%402023@65.0.127.253:3306/bookwedgo"}}
]
# Mock schema search module functions
mock_flatten.return_value = {
'schema_name': 'public',
'tables': [{'table_name': 'customers', 'fields': [{'name': 'id', 'type': 'int'}]}]
}
mock_build_index.return_value = {'customer': {'customers': {'id'}}}
mock_build_graph.return_value = {}
mock_rank_tables.return_value = [
('customers', 15.0, {'id'})
]
mock_format_results.return_value = {
'formatted_string': 'Table: customers',
'table_matches': [{'table_name': 'customers', 'score': 15.0, 'matched_columns': ['id']}],
'total_matches': 1
}
# Mock connector
mock_connector_instance = MagicMock()
mock_connector_instance.get_schema.return_value = '[{"schema_name": "public", "tables": []}]'
mock_ibis_connector.return_value = mock_connector_instance
mock_agent_instance = MagicMock()
mock_agent_instance.connectors = {"sample_db": mock_connector_instance}
mock_agent.return_value = mock_agent_instance
# Make request
request_data = {
"tenant_id": "test_tenant",
"keywords": ["customer", "revenue"]
}
response = client.post("/api/v1/data-sources/schema/search", json=request_data)
assert response.status_code == 200
data = response.json()
assert "available_sources" in data
assert "matches" in data
assert "formatted_schema_string" in data
assert "total_matches" in data
@patch('backend.data_sources.schema_search.format_search_results')
@patch('backend.data_sources.schema_search.rank_tables_for_keywords')
@patch('backend.data_sources.schema_search.build_relationship_graph')
@patch('backend.data_sources.schema_search.build_keyword_index')
@patch('backend.data_sources.schema_search.flatten_schema')
@patch('backend.data_sources.connectors.ibis_connector.IbisConnector')
@patch('data_sources.api.get_redis_client')
@patch('data_sources.api.get_minio_client')
@patch('data_sources.api.get_tenant_config')
@patch('data_sources.api.FederationAgent')
def test_schema_search_with_original_question(self, mock_agent, mock_config, mock_minio,
mock_redis, mock_ibis_connector, mock_flatten,
mock_build_index, mock_build_graph,
mock_rank_tables, mock_format_results, caplog):
"""Test schema search with original_question metadata (NEW FIELD)."""
import logging
caplog.set_level(logging.INFO)
# Setup mocks
mock_redis_instance = MagicMock()
mock_redis.return_value = mock_redis_instance
mock_redis_instance.get.return_value = None
mock_config.return_value = [
{"source_name": "sample_db", "source_type": "ibis", "config": {"uri": "mysql+pymysql://root:bwgadmin%402023@65.0.127.253:3306/bookwedgo"}}
]
# Mock schema search functions
mock_flatten.return_value = {'schema_name': 'public', 'tables': []}
mock_build_index.return_value = {}
mock_build_graph.return_value = {}
mock_rank_tables.return_value = []
mock_format_results.return_value = {
'formatted_string': '',
'table_matches': [],
'total_matches': 0
}
# Mock connector
mock_connector_instance = MagicMock()
mock_connector_instance.get_schema.return_value = '[{"schema_name": "public", "tables": []}]'
mock_ibis_connector.return_value = mock_connector_instance
mock_agent_instance = MagicMock()
mock_agent_instance.connectors = {"sample_db": mock_connector_instance}
mock_agent.return_value = mock_agent_instance
# Make request with original_question
request_data = {
"tenant_id": "test_tenant",
"keywords": ["revenue", "premium", "customers"],
"original_question": "What was revenue from premium customers last quarter?"
}
response = client.post("/api/v1/data-sources/schema/search", json=request_data)
assert response.status_code == 200
# Verify original_question was logged
assert any("Schema search for question" in record.message for record in caplog.records)
assert any("What was revenue from premium customers" in record.message for record in caplog.records)
@patch('backend.data_sources.schema_search.format_search_results')
@patch('backend.data_sources.schema_search.rank_tables_for_keywords')
@patch('backend.data_sources.schema_search.build_relationship_graph')
@patch('backend.data_sources.schema_search.build_keyword_index')
@patch('backend.data_sources.schema_search.flatten_schema')
@patch('backend.data_sources.connectors.ibis_connector.IbisConnector')
@patch('data_sources.api.get_redis_client')
@patch('data_sources.api.get_minio_client')
@patch('data_sources.api.get_tenant_config')
@patch('data_sources.api.FederationAgent')
def test_schema_search_with_keyword_metadata(self, mock_agent, mock_config, mock_minio,
mock_redis, mock_ibis_connector, mock_flatten,
mock_build_index, mock_build_graph,
mock_rank_tables, mock_format_results, caplog):
"""Test schema search with keyword_metadata breakdown (NEW FIELD)."""
import logging
caplog.set_level(logging.INFO)
# Setup mocks
mock_redis_instance = MagicMock()
mock_redis.return_value = mock_redis_instance
mock_redis_instance.get.return_value = None
mock_config.return_value = [
{"source_name": "sample_db", "source_type": "ibis", "config": {"uri": "mysql+pymysql://root:bwgadmin%402023@65.0.127.253:3306/bookwedgo"}}
]
# Mock schema search functions
mock_flatten.return_value = {'schema_name': 'public', 'tables': []}
mock_build_index.return_value = {}
mock_build_graph.return_value = {}
mock_rank_tables.return_value = []
mock_format_results.return_value = {
'formatted_string': '',
'table_matches': [],
'total_matches': 0
}
# Mock connector
mock_connector_instance = MagicMock()
mock_connector_instance.get_schema.return_value = '[{"schema_name": "public", "tables": []}]'
mock_ibis_connector.return_value = mock_connector_instance
mock_agent_instance = MagicMock()
mock_agent_instance.connectors = {"sample_db": mock_connector_instance}
mock_agent.return_value = mock_agent_instance
# Make request with keyword_metadata
request_data = {
"tenant_id": "test_tenant",
"keywords": ["premium", "revenue", "customers", "financial metrics"],
"keyword_metadata": {
"base": ["revenue", "customers"],
"semantic": ["financial metrics"],
"concepts": ["premium"]
}
}
response = client.post("/api/v1/data-sources/schema/search", json=request_data)
assert response.status_code == 200
# Verify keyword_metadata was logged
assert any("Keyword breakdown" in record.message for record in caplog.records)
assert any("Base: 2" in record.message for record in caplog.records)
assert any("Semantic: 1" in record.message for record in caplog.records)
assert any("Concepts: 1" in record.message for record in caplog.records)
@patch('backend.data_sources.schema_search.format_search_results')
@patch('backend.data_sources.schema_search.rank_tables_for_keywords')
@patch('backend.data_sources.schema_search.build_relationship_graph')
@patch('backend.data_sources.schema_search.build_keyword_index')
@patch('backend.data_sources.schema_search.flatten_schema')
@patch('backend.data_sources.connectors.ibis_connector.IbisConnector')
@patch('data_sources.api.get_redis_client')
@patch('data_sources.api.get_minio_client')
@patch('data_sources.api.get_tenant_config')
@patch('data_sources.api.FederationAgent')
def test_schema_search_with_all_metadata(self, mock_agent, mock_config, mock_minio,
mock_redis, mock_ibis_connector, mock_flatten,
mock_build_index, mock_build_graph,
mock_rank_tables, mock_format_results, caplog):
"""Test schema search with both original_question and keyword_metadata."""
import logging
caplog.set_level(logging.INFO)
# Setup mocks
mock_redis_instance = MagicMock()
mock_redis.return_value = mock_redis_instance
mock_redis_instance.get.return_value = None
mock_config.return_value = [
{"source_name": "sample_db", "source_type": "ibis", "config": {"uri": "mysql+pymysql://root:bwgadmin%402023@65.0.127.253:3306/bookwedgo"}}
]
# Mock schema search functions
mock_flatten.return_value = {'schema_name': 'public', 'tables': []}
mock_build_index.return_value = {}
mock_build_graph.return_value = {}
mock_rank_tables.return_value = []
mock_format_results.return_value = {
'formatted_string': '',
'table_matches': [],
'total_matches': 0
}
# Mock connector
mock_connector_instance = MagicMock()
mock_connector_instance.get_schema.return_value = '[{"schema_name": "public", "tables": []}]'
mock_ibis_connector.return_value = mock_connector_instance
mock_agent_instance = MagicMock()
mock_agent_instance.connectors = {"sample_db": mock_connector_instance}
mock_agent.return_value = mock_agent_instance
# Make request with all metadata
request_data = {
"tenant_id": "test_tenant",
"keywords": ["sales", "monthly", "trend"],
"original_question": "Show monthly sales trends",
"keyword_metadata": {
"base": ["sales", "monthly", "trend"],
"semantic": ["time series"],
"concepts": []
}
}
response = client.post("/api/v1/data-sources/schema/search", json=request_data)
assert response.status_code == 200
# Verify both pieces of metadata were logged
log_messages = [record.message for record in caplog.records]
assert any("Show monthly sales trends" in msg for msg in log_messages)
assert any("Keyword breakdown" in msg for msg in log_messages)
@patch('backend.data_sources.schema_search.format_search_results')
@patch('backend.data_sources.schema_search.rank_tables_for_keywords')
@patch('backend.data_sources.schema_search.build_relationship_graph')
@patch('backend.data_sources.schema_search.build_keyword_index')
@patch('backend.data_sources.schema_search.flatten_schema')
@patch('backend.data_sources.connectors.ibis_connector.IbisConnector')
@patch('data_sources.api.get_redis_client')
@patch('data_sources.api.get_minio_client')
@patch('data_sources.api.get_tenant_config')
@patch('data_sources.api.FederationAgent')
def test_schema_search_backward_compatible(self, mock_agent, mock_config, mock_minio,
mock_redis, mock_ibis_connector, mock_flatten,
mock_build_index, mock_build_graph,
mock_rank_tables, mock_format_results):
"""Test that schema search is backward compatible (metadata fields optional)."""
# Setup mocks
mock_redis_instance = MagicMock()
mock_redis.return_value = mock_redis_instance
mock_redis_instance.get.return_value = None
mock_config.return_value = [
{"source_name": "sample_db", "source_type": "ibis", "config": {"uri": "mysql+pymysql://root:bwgadmin%402023@65.0.127.253:3306/bookwedgo"}}
]
# Mock schema search functions
mock_flatten.return_value = {'schema_name': 'public', 'tables': []}
mock_build_index.return_value = {}
mock_build_graph.return_value = {}
mock_rank_tables.return_value = []
mock_format_results.return_value = {
'formatted_string': '',
'table_matches': [],
'total_matches': 0
}
# Mock connector
mock_connector_instance = MagicMock()
mock_connector_instance.get_schema.return_value = '[{"schema_name": "public", "tables": []}]'
mock_ibis_connector.return_value = mock_connector_instance
mock_agent_instance = MagicMock()
mock_agent_instance.connectors = {"sample_db": mock_connector_instance}
mock_agent.return_value = mock_agent_instance
# Make request WITHOUT optional metadata fields (old API behavior)
request_data = {
"tenant_id": "test_tenant",
"keywords": ["customer"]
# NO original_question
# NO keyword_metadata
}
response = client.post("/api/v1/data-sources/schema/search", json=request_data)
# Should still work (backward compatible)
assert response.status_code == 200
data = response.json()
assert "available_sources" in data
assert "matches" in data
def test_schema_search_missing_tenant_id(self):
"""Test that missing tenant_id returns validation error."""
request_data = {
# Missing tenant_id
"keywords": ["customer"]
}
response = client.post("/api/v1/data-sources/schema/search", json=request_data)
assert response.status_code == 422 # Validation error
def test_schema_search_missing_keywords(self):
"""Test that missing keywords returns validation error."""
request_data = {
"tenant_id": "tenant-123"
# Missing keywords
}
response = client.post("/api/v1/data-sources/schema/search", json=request_data)
assert response.status_code == 422 # Validation error
def test_schema_search_empty_keywords(self):
"""Test that empty keywords list returns validation error."""
request_data = {
"tenant_id": "tenant-123",
"keywords": [] # Empty list
}
response = client.post("/api/v1/data-sources/schema/search", json=request_data)
assert response.status_code == 422 # Validation error
if __name__ == "__main__":
pytest.main([__file__, "-v"]) |