Update app.py

app.py

@@ -734,22 +734,15 @@ elif input_method == "Upload Video":
                     
                     status_text.text("Creating processed video...")
                     
-                    # Create a file in the Streamlit static directory (will be accessible via URL)
-                    # This is a directory that Streamlit serves statically
+                    # Create a temporary file in the system's temp directory
                     timestamp = int(time.time())
                     filename = f"processed_video_{timestamp}.mp4"
+                    temp_output_path = os.path.join(tempfile.gettempdir(), filename)
                     
-                    # For Hugging Face Spaces, use a publicly accessible directory
-                    # First try to create within the app directory
-                    static_dir = "static"
-                    os.makedirs(static_dir, exist_ok=True)
-                    
-                    output_path = os.path.join(static_dir, filename)
-                    
-                    # Create video writer with H.264 codec (most compatible)
-                    fourcc = cv2.VideoWriter_fourcc(*'avc1')
+                    # Create video writer
+                    fourcc = cv2.VideoWriter_fourcc(*'mp4v')  # Use mp4v codec which is widely compatible
                     out = cv2.VideoWriter(
-                        output_path, 
+                        temp_output_path, 
                         fourcc, 
                         fps, 
                         (frame_width, frame_height)
@@ -762,39 +755,48 @@ elif input_method == "Upload Video":
                     # Release the writer
                     out.release()
                     
-                    # Try multiple approaches to display the video
-                    
-                    try:
-                        # First attempt: Try to display using st.video
-                        with open(output_path, 'rb') as video_file:
+                    # Verify file exists before proceeding
+                    if os.path.exists(temp_output_path) and os.path.getsize(temp_output_path) > 0:
+                        # Read the processed video into memory
+                        with open(temp_output_path, 'rb') as video_file:
                             video_bytes = video_file.read()
-                            st.video(video_bytes)
-                    except Exception as e:
-                        st.warning(f"Could not display video directly: {e}")
                         
-                        # Fallback: Provide a download link
-                        with open(output_path, "rb") as file:
-                            btn = st.download_button(
+                        # Create a frame display interface
+                        display_option = st.radio(
+                            "Display Option",
+                            ["View Frames", "Download Video"],
+                            horizontal=True
+                        )
+                        
+                        if display_option == "View Frames":
+                            # Display frames with a slider
+                            st.write("Navigate through processed frames:")
+                            selected_frame = st.slider("Frame", 0, len(processed_frames)-1, 0)
+                            st.image(
+                                processed_frames[selected_frame]["frame"], 
+                                channels="BGR", 
+                                use_column_width=True,
+                                caption=f"Frame {selected_frame}"
+                            )
+                        else:
+                            # Provide a download button for the video
+                            st.download_button(
                                 label="Download Processed Video",
-                                data=file,
+                                data=video_bytes,
                                 file_name=filename,
                                 mime="video/mp4"
                             )
+                            
+                            # Try to display the video directly as well
+                            try:
+                                st.video(video_bytes)
+                            except:
+                                st.info("Video preview not available. Please use the download button.")
                         
-                        # Also display frames with a slider as another option
-                        st.write("Preview frames:")
-                        
-                        # Create a slider to navigate through frames
-                        selected_frame = st.slider("Navigate Frames", 0, len(processed_frames)-1, 0)
-                        
-                        # Display the selected frame
-                        st.image(processed_frames[selected_frame]["frame"], 
-                               channels="BGR", 
-                               use_column_width=True,
-                               caption=f"Frame {selected_frame}")
-                    
-                    # Analysis complete, display results
-                    st.success(f"Video analysis complete. {len(processed_frames)} frames processed, {len(crash_frames)} crashes detected.")
+                        # Analysis complete, display results
+                        st.success(f"Video analysis complete. {len(processed_frames)} frames processed, {len(crash_frames)} crashes detected.")
+                    else:
+                        st.error(f"Failed to create video file at {temp_output_path}")
                     
                     # After video display, process the last detected crash (if any)
                     if crash_frames:
@@ -846,6 +848,12 @@ elif input_method == "Upload Video":
                     else:
                         st.info("No crashes detected in this video.")
                     
+                    # Clean up temporary file
+                    try:
+                        if os.path.exists(temp_output_path):
+                            os.remove(temp_output_path)
+                    except:
+                        pass
             except Exception as e:
                 st.error(f"Error processing video: {e}")
                 st.exception(e)  # Show the full traceback for debugging